RFR 8129843: JShell: method cannot call method with different number of arguments

[Robert Field]

This is an important bug to fix -- not common but confusing and can't be 
easily worked around.  Nice work.


Eval --

Nit: 950 don't know why this setWrap is being called again, was just 
done on line 941.

Using the Iterable forEach rather than Stream's is good.

Nit: the layout of 1048-1050 looks like overloadMethods() uses Result.  
Another //where after Result would be one approach.

Every eval is going to go through overloadMethods() which will loop 
through all methods, even when the eval contains no methods. Adding a 
cut-off would be good.

The code needs more documentation


JShell --

JShell is for conceptually very central functionality -- public and 
support of public.  I don't think this is the right place for 
matchedMethods().


Thanks,
Robert



On 03/24/18 06:55, ShinyaYoshida wrote:
> Hi,
> Please review following:
>
> Bugs: https://bugs.openjdk.java.net/browse/JDK-8129843
> Webrev: http://cr.openjdk.java.net/~shinyafox/kulla/8129843/webrev/
>
> Regards,
> shinyafox(Shinya Yoshida)