RFR: JDK-8203827: Upgrade JLine to 2.14.6

[Jan Lahoda]

On 28.5.2018 23:51, Robert Field wrote:
> I've been working on reviewing this.
>
> To the extent I can tell, it looks fine.

Thanks!

>
> But, Ugh! Untangling what came from where is painful.
>
> There is a reason that internal deltas to external packages is
> considered a nightmare.
>
> It would be good to reconsider how we handle this in the future.
>
> To the extent we can contribute fixes and additions to jline, that would
> be a win-win: others would be interested in usage with constrained
> native library access, and simple fixes, like the @SuppressWarnings
> additions, etc...

I'll see what can be done.

Thanks,
     Jan

>
> Maybe a radical thought, with (internal) modules, is there still a need
> to do package renaming?  Doing so creates most of the noise.
>
> -Robert
>
>
>
> On 05/25/18 13:20, Jan Lahoda wrote:
>> Hi,
>>
>> I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to
>> 2.14.6.
>>
>> The complete webrev is here:
>> http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/
>>
>> To simplify reviewing, there is:
>> -an antipatch that removes the JDK-specific changes and restores the
>> vanilla 2.12.1 content:
>> http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/undo-jdk-extras/
>> -a patch that replaces the 2.12.1 content with 2.14.6:
>> http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/upgrade-jline/
>> -a patch that re-applies the JDK-specific changes (like including
>> adjusting packages, and removal/commenting out of usage of features
>> that would require undesirable dependencies, and any changes that had
>> to be done to other modules):
>> http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/adding-jdk-extras/
>>
>> JBS entry: https://bugs.openjdk.java.net/browse/JDK-8203827
>>
>> How does this look?
>>
>> Thanks,
>>     Jan
>