From robert.field at oracle.com Wed Nov 14 05:34:29 2018 From: robert.field at oracle.com (Robert Field) Date: Tue, 13 Nov 2018 21:34:29 -0800 Subject: RFR 8213725: JShell NullPointerException due to class file with unexpected package Message-ID: Please review: Bug: ??? https://bugs.openjdk.java.net/browse/JDK-8213725 Webrev: ??? http://cr.openjdk.java.net/~rfield/8213725v0.webrev/ Thanks, Robert From jan.lahoda at oracle.com Thu Nov 29 19:28:30 2018 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Thu, 29 Nov 2018 20:28:30 +0100 Subject: RFR 8213725: JShell NullPointerException due to class file with unexpected package In-Reply-To: References: Message-ID: <5C003DDE.20503@oracle.com> Looks OK to me. Jan On 14.11.2018 06:34, Robert Field wrote: > Please review: > > Bug: > > https://bugs.openjdk.java.net/browse/JDK-8213725 > > Webrev: > > http://cr.openjdk.java.net/~rfield/8213725v0.webrev/ > > > Thanks, > Robert > > From jan.lahoda at oracle.com Thu Nov 29 21:06:23 2018 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Thu, 29 Nov 2018 22:06:23 +0100 Subject: RFR: JDK-8214491: Upgrade to JLine 3.9.0 Message-ID: <5C0054CF.3040009@oracle.com> Hi, I'd like to update the internal JLine used by JShell and jjs to JLine 3.9.0. Two notable advantages of this version is multi-line snippet editing and better UI on Windows (escape sequence support on Windows). As a consequence, this patch drops EditingHistory, as it does not seem to be needed anymore. JBS: https://bugs.openjdk.java.net/browse/JDK-8214491 The full patch is here: http://cr.openjdk.java.net/~jlahoda/8214491/webrev.00/ To make the changes more clear, I've split it into two: -replacement of existing JLine with the new on in jdk.internal.le, no changes to JLine code: http://cr.openjdk.java.net/~jlahoda/8214491/webrev.00.replace/ -tweaks to JLine (repackaging, eliminating references to j.u.l.Logger, adding hooks to wrap input streams with our stop-detecting input stream, adding unicode escapes to unicode characters, support for Windows without JNA), adjustments to JShell and jjs (unfortunately, 3.9.0 is not compatible with the JLine 2 branch, so the changes are substantial): http://cr.openjdk.java.net/~jlahoda/8214491/webrev.00.update/ Any feedback is welcome! Thanks, Jan From robert.field at oracle.com Fri Nov 30 03:10:58 2018 From: robert.field at oracle.com (Robert Field) Date: Thu, 29 Nov 2018 19:10:58 -0800 Subject: RFR: JDK-8214491: Upgrade to JLine 3.9.0 In-Reply-To: <5C0054CF.3040009@oracle.com> References: <5C0054CF.3040009@oracle.com> Message-ID: <69454e30-2adf-eaac-7459-841aaafb3599@oracle.com> Nit: Why are the hyphens in the comments of AnsiWriter.java changed to unicode? utils/Display.java -- please document the change utils/StyleResolver.java et. al. -- if we want less surface area to update when we get new versions, we could perhaps a non-op logger.? No changes required.? Why is logging pulled out? terminal/impl/jna/win/Kernel32.java -- short doc of the Windows change Review of JShell tool and test code in separate email. -Robert On 11/29/18 1:06 PM, Jan Lahoda wrote: > Hi, > > I'd like to update the internal JLine used by JShell and jjs to JLine > 3.9.0. Two notable advantages of this version is multi-line snippet > editing and better UI on Windows (escape sequence support on Windows). > As a consequence, this patch drops EditingHistory, as it does not seem > to be needed anymore. > > JBS: > https://bugs.openjdk.java.net/browse/JDK-8214491 > > The full patch is here: > http://cr.openjdk.java.net/~jlahoda/8214491/webrev.00/ > > > To make the changes more clear, I've split it into two: > -replacement of existing JLine with the new on in jdk.internal.le, no > changes to JLine code: > http://cr.openjdk.java.net/~jlahoda/8214491/webrev.00.replace/ > > -tweaks to JLine (repackaging, eliminating references to j.u.l.Logger, > adding hooks to wrap input streams with our stop-detecting input > stream, adding unicode escapes to unicode characters, support for > Windows without JNA), adjustments to JShell and jjs (unfortunately, > 3.9.0 is not compatible with the JLine 2 branch, so the changes are > substantial): > http://cr.openjdk.java.net/~jlahoda/8214491/webrev.00.update/ > > Any feedback is welcome! > > Thanks, > ??? Jan From jan.lahoda at oracle.com Fri Nov 30 14:04:02 2018 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Fri, 30 Nov 2018 15:04:02 +0100 Subject: RFR: JDK-8214491: Upgrade to JLine 3.9.0 In-Reply-To: <69454e30-2adf-eaac-7459-841aaafb3599@oracle.com> References: <5C0054CF.3040009@oracle.com> <69454e30-2adf-eaac-7459-841aaafb3599@oracle.com> Message-ID: <5C014352.8000400@oracle.com> On 30.11.2018 04:10, Robert Field wrote: > Nit: Why are the hyphens in the comments of AnsiWriter.java changed to > unicode? These were unicode hyphens (?), not ordinary hyphens (-). I could have replace them with ordinary hyphens, but opted to keeping the semantics the same by using a unicode escape. > > utils/Display.java -- please document the change Will do. (As a note, this is used when reading user input in cases like: { System.out.print("Provide input:"); System.in.read(); } where, when the read is executed, the user should enter some input, but should not be able to get the cursor into the printed text.) > > utils/StyleResolver.java et. al. -- if we want less surface area to > update when we get new versions, we could perhaps a non-op logger. No > changes required. Why is logging pulled out? jdk.internal.le currently does not depend on java.logging. jdk.jshell does, so there would be no problem with using j.u.l.Logger for jshell, but jjs does not depend on java.logging. If it would be OK to make jjs depend on java.logging, we can undo these changes. Another alternative would be to convert the use of Logger to System.Logger, but that requires non-trivial changes as well. > > terminal/impl/jna/win/Kernel32.java -- short doc of the Windows change Will do. Thanks! Jan > > Review of JShell tool and test code in separate email. > > -Robert > > > On 11/29/18 1:06 PM, Jan Lahoda wrote: >> Hi, >> >> I'd like to update the internal JLine used by JShell and jjs to JLine >> 3.9.0. Two notable advantages of this version is multi-line snippet >> editing and better UI on Windows (escape sequence support on Windows). >> As a consequence, this patch drops EditingHistory, as it does not seem >> to be needed anymore. >> >> JBS: >> https://bugs.openjdk.java.net/browse/JDK-8214491 >> >> The full patch is here: >> http://cr.openjdk.java.net/~jlahoda/8214491/webrev.00/ >> >> >> To make the changes more clear, I've split it into two: >> -replacement of existing JLine with the new on in jdk.internal.le, no >> changes to JLine code: >> http://cr.openjdk.java.net/~jlahoda/8214491/webrev.00.replace/ >> >> -tweaks to JLine (repackaging, eliminating references to j.u.l.Logger, >> adding hooks to wrap input streams with our stop-detecting input >> stream, adding unicode escapes to unicode characters, support for >> Windows without JNA), adjustments to JShell and jjs (unfortunately, >> 3.9.0 is not compatible with the JLine 2 branch, so the changes are >> substantial): >> http://cr.openjdk.java.net/~jlahoda/8214491/webrev.00.update/ >> >> Any feedback is welcome! >> >> Thanks, >> Jan