From jan.lahoda at oracle.com Fri Aug 2 16:23:23 2019 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Fri, 2 Aug 2019 18:23:23 +0200 Subject: RFR: JDK-8226848: jline/terminal/impl files missing classpath exception clause in license header Message-ID: <797a986c-0912-de2b-f5e6-d78b2f3af412@oracle.com> Hi, There is a handful of files in jdk.internal.le, that are missing the classpath exception. The patch herein is adding it. Webrev: http://cr.openjdk.java.net/~jlahoda/8226848/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8226848 Does this look OK? Thanks, Jan From jonathan.gibbons at oracle.com Fri Aug 2 18:20:08 2019 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 2 Aug 2019 11:20:08 -0700 Subject: RFR: JDK-8226848: jline/terminal/impl files missing classpath exception clause in license header In-Reply-To: <797a986c-0912-de2b-f5e6-d78b2f3af412@oracle.com> References: <797a986c-0912-de2b-f5e6-d78b2f3af412@oracle.com> Message-ID: Looks OK to me. -- Jon On 08/02/2019 09:23 AM, Jan Lahoda wrote: > Hi, > > There is a handful of files in jdk.internal.le, that are missing the > classpath exception. The patch herein is adding it. > > Webrev: http://cr.openjdk.java.net/~jlahoda/8226848/webrev.00/ > JBS: https://bugs.openjdk.java.net/browse/JDK-8226848 > > Does this look OK? > > Thanks, > ??? Jan From jan.lahoda at oracle.com Fri Aug 16 10:19:30 2019 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Fri, 16 Aug 2019 12:19:30 +0200 Subject: RFR: JDK-8229815: Upgrade Jline to 3.12.1 Message-ID: Hi, I'd like to upgrade the internal JLine to 3.12.1. Webrev: http://cr.openjdk.java.net/~jlahoda/8229815/webrev.full.00/ In case it would be useful, there is also a webrev which shows changes done to the original JLine 3.12.1 sources here: http://cr.openjdk.java.net/~jlahoda/8229815/webrev.reapply.00 These are basically re-application of the current JDK-specific changes, with the exception of adding a license header to JnaSupportImpl.java. JBS: https://bugs.openjdk.java.net/browse/JDK-8229815 The patch should also resolve: https://bugs.openjdk.java.net/browse/JDK-8219206 How does this look? Thanks, Jan From robert.field at oracle.com Fri Aug 16 22:18:46 2019 From: robert.field at oracle.com (Robert Field) Date: Fri, 16 Aug 2019 15:18:46 -0700 Subject: RFR: JDK-8229815: Upgrade Jline to 3.12.1 In-Reply-To: References: Message-ID: Looks good. Why the Unicode version of underscore in *LineReaderImpl.java*? -Robert On 8/16/19 3:19 AM, Jan Lahoda wrote: > Hi, > > I'd like to upgrade the internal JLine to 3.12.1. > > Webrev: > http://cr.openjdk.java.net/~jlahoda/8229815/webrev.full.00/ > > In case it would be useful, there is also a webrev which shows changes > done to the original JLine 3.12.1 sources here: > http://cr.openjdk.java.net/~jlahoda/8229815/webrev.reapply.00 > > These are basically re-application of the current JDK-specific > changes, with the exception of adding a license header to > JnaSupportImpl.java. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8229815 > The patch should also resolve: > https://bugs.openjdk.java.net/browse/JDK-8219206 > > How does this look? > > Thanks, > ??? Jan From stuart.marks at oracle.com Wed Aug 21 00:07:56 2019 From: stuart.marks at oracle.com (Stuart Marks) Date: Tue, 20 Aug 2019 17:07:56 -0700 Subject: [JDK-8210527] NullPointerException in jstack exception rendering In-Reply-To: <586D7C71-D908-4A7C-A82A-2F731966D409@gmail.com> References: <586D7C71-D908-4A7C-A82A-2F731966D409@gmail.com> Message-ID: <55482bf8-359e-f050-d37e-c2485b29fa8c@oracle.com> The jshell mailing list is kulla-dev at openjdk.java.net. I'm cc'ing that list and bcc'ing jdk-dev. (Yes, the name "kulla-dev" is quite opaque. Sorry.) s'marks On 8/19/19 1:10 PM, Steven Schlansker wrote: > Hello jdk-dev, (hopefully this is the best list, I did not see a jshell-dev) > > I spent most of my Friday diagnosing a confusing issue > https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8229863 > > which turned out to be a duplicate of JDK-8210527 > Unfortunately it's been open most of a year with no progress. > > The fix is seemingly trivial: > > diff -r 31b7274c7b9e src/jdk.jshell/share/classes/jdk/jshell/Eval.java > --- a/src/jdk.jshell/share/classes/jdk/jshell/Eval.java Fri Aug 09 03:36:59 2019 +0200 > +++ b/src/jdk.jshell/share/classes/jdk/jshell/Eval.java Mon Aug 19 13:06:57 2019 -0700 > @@ -1106,7 +1106,7 @@ > Snippet sn = outer.wrapLineToSnippet(wln); > String file = "#" + sn.id(); > elems[i] = new StackTraceElement(klass, method, file, line); > - } else if (r.getFileName().equals("")) { > + } else if ("".equals(r.getFileName())) { > elems[i] = new StackTraceElement(r.getClassName(), r.getMethodName(), null, r.getLineNumber()); > } else { > elems[i] = r; > > I verified this fix against jdk13 tip. Before: > > Unexpected exception reading startup: java.lang.NullPointerException > java.lang.NullPointerException > at jdk.jshell/jdk.jshell.Eval.translateExceptionStack(Eval.java:1109) > at jdk.jshell/jdk.jshell.Eval.asEvalException(Eval.java:907) > at jdk.jshell/jdk.jshell.Eval.declare(Eval.java:888) > at jdk.jshell/jdk.jshell.Eval.eval(Eval.java:140) > at jdk.jshell/jdk.jshell.JShell.eval(JShell.java:493) > at jdk.jshell/jdk.internal.jshell.tool.JShellTool.processSource(JShellTool.java:3558) > at jdk.jshell/jdk.internal.jshell.tool.JShellTool.processSourceCatchingReset(JShellTool.java:1305) > at jdk.jshell/jdk.internal.jshell.tool.JShellTool.processInput(JShellTool.java:1203) > at jdk.jshell/jdk.internal.jshell.tool.JShellTool.run(JShellTool.java:1176) > at jdk.jshell/jdk.internal.jshell.tool.JShellTool.startUpRun(JShellTool.java:1143) > at jdk.jshell/jdk.internal.jshell.tool.JShellTool.resetState(JShellTool.java:1099) > at jdk.jshell/jdk.internal.jshell.tool.JShellTool.start(JShellTool.java:933) > at jdk.jshell/jdk.internal.jshell.tool.JShellToolBuilder.start(JShellToolBuilder.java:254) > at jdk.jshell/jdk.internal.jshell.tool.JShellToolProvider.run(JShellToolProvider.java:94) > at JshellNpe.main(JshellNpe.java:20) > > After, > > Exception java.lang.IllegalStateException: This helpful exception message is lost > at JshellNpe.lambda$2 (JshellNpe.java:27) > at $Proxy0.hashCode (Unknown Source) > at JshellNpe.init (JshellNpe.java:28) > at (#s1:1) > > Much better! > > What can I do to help move this issue forward to resolution? > > thanks, > Steven > From robert.field at oracle.com Tue Aug 27 01:09:02 2019 From: robert.field at oracle.com (Robert Field) Date: Mon, 26 Aug 2019 18:09:02 -0700 Subject: RFR 8210527: NullPointerException in jdk.jshell.Eval.translateExceptionStack Message-ID: <8ff12294-eb70-5fff-e27e-a25b5193d54e@oracle.com> Bug: https://bugs.openjdk.java.net/browse/JDK-8210527 Webrev: http://cr.openjdk.java.net/~rfield/8210527/ Thanks, Robert From jan.lahoda at oracle.com Tue Aug 27 16:17:52 2019 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Tue, 27 Aug 2019 18:17:52 +0200 Subject: RFR: JDK-8229815: Upgrade Jline to 3.12.1 In-Reply-To: References: Message-ID: <50edc111-c6a3-f9aa-3b1b-c148cf00ee21@oracle.com> On 17. 08. 19 0:18, Robert Field wrote: > Looks good. Thanks! > > Why the Unicode version of underscore in *LineReaderImpl.java*? The '\u2026', correct? The reason for the change is that (I believe at least) non-ASCII characters are not allow in the JDK sourcebase, so when including JLine the non-ASCII characters were converted to unicode escapes. Thanks, Jan > > -Robert > > > On 8/16/19 3:19 AM, Jan Lahoda wrote: >> Hi, >> >> I'd like to upgrade the internal JLine to 3.12.1. >> >> Webrev: >> http://cr.openjdk.java.net/~jlahoda/8229815/webrev.full.00/ >> >> In case it would be useful, there is also a webrev which shows changes >> done to the original JLine 3.12.1 sources here: >> http://cr.openjdk.java.net/~jlahoda/8229815/webrev.reapply.00 >> >> These are basically re-application of the current JDK-specific >> changes, with the exception of adding a license header to >> JnaSupportImpl.java. >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8229815 >> The patch should also resolve: >> https://bugs.openjdk.java.net/browse/JDK-8219206 >> >> How does this look? >> >> Thanks, >> ??? Jan