RFR: JDK-8229815: Upgrade Jline to 3.12.1

Jan Lahoda jan.lahoda at oracle.com
Tue Aug 27 16:17:52 UTC 2019


On 17. 08. 19 0:18, Robert Field wrote:
> Looks good.

Thanks!

> 
> Why the Unicode version of underscore in *LineReaderImpl.java*?

The '\u2026', correct? The reason for the change is that (I believe at 
least) non-ASCII characters are not allow in the JDK sourcebase, so when 
including JLine the non-ASCII characters were converted to unicode escapes.

Thanks,
     Jan

> 
> -Robert
> 
> 
> On 8/16/19 3:19 AM, Jan Lahoda wrote:
>> Hi,
>>
>> I'd like to upgrade the internal JLine to 3.12.1.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~jlahoda/8229815/webrev.full.00/
>>
>> In case it would be useful, there is also a webrev which shows changes 
>> done to the original JLine 3.12.1 sources here:
>> http://cr.openjdk.java.net/~jlahoda/8229815/webrev.reapply.00
>>
>> These are basically re-application of the current JDK-specific 
>> changes, with the exception of adding a license header to 
>> JnaSupportImpl.java.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8229815
>> The patch should also resolve:
>> https://bugs.openjdk.java.net/browse/JDK-8219206
>>
>> How does this look?
>>
>> Thanks,
>>     Jan


More information about the kulla-dev mailing list