From jan.lahoda at oracle.com Mon Jan 7 08:49:11 2019 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Mon, 7 Jan 2019 09:49:11 +0100 Subject: RFR(12): JDK-8215438: jshell tool: Ctrl-D causes EOF Message-ID: <5C331287.7080205@oracle.com> Hi, I'd like to ask for a review of a patch for: https://bugs.openjdk.java.net/browse/JDK-8215438 After the upgrade to JLine 3, EndOfFileException is thrown for Ctrl-D, so we need to catch it and return null from ConsoleIOContext.readLine, so the end-of-input is processed correctly by JShellTool. Proposed patch: http://cr.openjdk.java.net/~jlahoda/8215438/webrev.00/ Thanks, Jan From robert.field at oracle.com Mon Jan 7 16:15:50 2019 From: robert.field at oracle.com (Robert Field) Date: Mon, 7 Jan 2019 08:15:50 -0800 Subject: RFR(12): JDK-8215438: jshell tool: Ctrl-D causes EOF In-Reply-To: <5C331287.7080205@oracle.com> References: <5C331287.7080205@oracle.com> Message-ID: Thumbs up! Thanks. -Robert On 1/7/19 12:49 AM, Jan Lahoda wrote: > Hi, > > I'd like to ask for a review of a patch for: > https://bugs.openjdk.java.net/browse/JDK-8215438 > > After the upgrade to JLine 3, EndOfFileException is thrown for Ctrl-D, > so we need to catch it and return null from ConsoleIOContext.readLine, > so the end-of-input is processed correctly by JShellTool. > > Proposed patch: > http://cr.openjdk.java.net/~jlahoda/8215438/webrev.00/ > > Thanks, > ??? Jan From robert.field at oracle.com Tue Jan 8 21:44:40 2019 From: robert.field at oracle.com (Robert Field) Date: Tue, 8 Jan 2019 13:44:40 -0800 Subject: RFR: JDK-8215244: jdk/jshell/ToolBasicTest.java testHistoryReference failed In-Reply-To: <5C112C0A.3090809@oracle.com> References: <5C112C0A.3090809@oracle.com> Message-ID: <25aabbf0-90a9-f6b6-ec2d-12537d04fc06@oracle.com> Seems safe.? Hopefully will fix it. Thumbs up. -Robert On 12/12/18 7:40 AM, Jan Lahoda wrote: > Hi, > > Another problem with a test intermittently failing. The failure is: > test ToolBasicTest.testHistoryReference(): failure > java.lang.AssertionError: command output: /history. > ?expected [/debug 0 > System.err.println(1) > System.err.println(2) > System.err.println(1) > /history] but found [System.err.println(1) > System.err.println(2) > System.err.println(1) > /history] > > The first (synthetic) command is missing ("/debug 0") in the current > session history. The detection of which entries are load from previous > sessions and which belong to the current session is based on the > Instant when the entry was added. But it seems that maybe(?) the first > command may have the same instant as the entries load for the previous > sessions. So, I'd like to use Instant.MIN instead of Instant.now() as > the timestamp for the history entries from the previous sessions, that > should help us distinguish the new and old entries. > > Webrev: http://cr.openjdk.java.net/~jlahoda/8215244/webrev.00/ > JBS: https://bugs.openjdk.java.net/browse/JDK-8215244 > > What do you think? > > Thanks, > ??? Jan > From jonathan.gibbons at oracle.com Fri Jan 11 17:00:48 2019 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 11 Jan 2019 09:00:48 -0800 Subject: RFR: JDK-8197541: Close as Unable to Reproduce In-Reply-To: References: Message-ID: Kulla folk, This looks like your test, and so is your issue to close. I know you have been fixing issues like this, so it may not be surprising that this issue has not been seen recently. -- Jon On 1/11/19 2:06 AM, Adam Farley8 wrote: > Hi All, > > Can't reproduce this bug locally after many tries, and after contacting > the originator, he agrees that the issue hasn't been seen since April > 2018. > > I recommend we resolve this as "Unable to Reproduce". > > All in favor? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8197541 > > Best Regards > > Adam Farley > IBM Runtimes > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From jan.lahoda at oracle.com Fri Jan 11 17:19:45 2019 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Fri, 11 Jan 2019 18:19:45 +0100 Subject: RFR: JDK-8197541: Close as Unable to Reproduce In-Reply-To: References: Message-ID: <5C38D031.8040200@oracle.com> Hi, Closed as Cannot Reproduce. Please feel free to reopen if it happens again or if you disagree. Jan On 11.1.2019 18:00, Jonathan Gibbons wrote: > Kulla folk, > > This looks like your test, and so is your issue to close. I know you > have been fixing issues like this, so it may not be surprising that this > issue has not been seen recently. > > -- Jon > > On 1/11/19 2:06 AM, Adam Farley8 wrote: >> Hi All, >> >> Can't reproduce this bug locally after many tries, and after contacting >> the originator, he agrees that the issue hasn't been seen since April >> 2018. >> >> I recommend we resolve this as "Unable to Reproduce". >> >> All in favor? >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8197541 >> >> Best Regards >> >> Adam Farley >> IBM Runtimes >> >> Unless stated otherwise above: >> IBM United Kingdom Limited - Registered in England and Wales with number >> 741598. >> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 >> 3AU From sormuras at gmail.com Thu Jan 31 14:41:48 2019 From: sormuras at gmail.com (Christian Stein) Date: Thu, 31 Jan 2019 15:41:48 +0100 Subject: jshell + Bach.java compilation issues Message-ID: Hi kulla-dev, I'm still working on Bach.java (Java Shell Builder tool) and today its compilation stopped working when `jshell Bach.java` is invoked. Same goes for `/open Bach.java` within a jshell session. Calling `java Bach.java` (JEP 330) runs successfully for all revisions. I described the issue in more detail at [1] -- here is the gist: - revision from yesterday [2] works - revision from today [3] chokes. Here is the diff [4] of the two revisions. I tried hard to find the underlying issue... - renamed types within Bach.java - reduced total file size by - removing unused enum constants - removing all Javadoc ...to no avail. What barrier am I hitting here? Cheers, Christian [1] https://github.com/sormuras/bach/issues/43 [2] https://raw.githubusercontent.com/sormuras/bach/5e7165ef06c26423d8906038f2e061eb6cd8f374/src/bach/Bach.java [3] https://raw.githubusercontent.com/sormuras/bach/13cf5eb5a9045ac0158d6da585105d359591ba7f/src/bach/Bach.java [4] https://github.com/sormuras/bach/commit/13cf5eb5a9045ac0158d6da585105d359591ba7f