RFR: JDK-8215244: jdk/jshell/ToolBasicTest.java testHistoryReference failed

[Robert Field]

Seems safe.  Hopefully will fix it.

Thumbs up.

-Robert


On 12/12/18 7:40 AM, Jan Lahoda wrote:
> Hi,
>
> Another problem with a test intermittently failing. The failure is:
> test ToolBasicTest.testHistoryReference(): failure
> java.lang.AssertionError: command output: /history.
>  expected [/debug 0
> System.err.println(1)
> System.err.println(2)
> System.err.println(1)
> /history] but found [System.err.println(1)
> System.err.println(2)
> System.err.println(1)
> /history]
>
> The first (synthetic) command is missing ("/debug 0") in the current 
> session history. The detection of which entries are load from previous 
> sessions and which belong to the current session is based on the 
> Instant when the entry was added. But it seems that maybe(?) the first 
> command may have the same instant as the entries load for the previous 
> sessions. So, I'd like to use Instant.MIN instead of Instant.now() as 
> the timestamp for the history entries from the previous sessions, that 
> should help us distinguish the new and old entries.
>
> Webrev: http://cr.openjdk.java.net/~jlahoda/8215244/webrev.00/
> JBS: https://bugs.openjdk.java.net/browse/JDK-8215244
>
> What do you think?
>
> Thanks,
>     Jan
>