`.
>
>
> There are two ways forward:
>
> 1. Remove the extra text, and/or restructure the doc comment so that
> the extra text is not part of @jls
>
> 2. Maybe update the @jls taglet to modify its behavior in the face of
> more complex HTML content.
>
> My reading of the document is that these paragraphs should be moved
> before the @jls reference, because they do not appear to be part of
> the @jls reference.
>
> Comments, suggestions?
>
> -- Jon
>
From robert.field at oracle.com Sat Jun 1 22:34:18 2019
From: robert.field at oracle.com (Robert Field)
Date: Sat, 1 Jun 2019 15:34:18 -0700
Subject: Use of @jls in jshell
In-Reply-To: <36d5b63a-3680-c026-d856-c6f515c0782c@oracle.com>
References: <36d5b63a-3680-c026-d856-c6f515c0782c@oracle.com>
Message-ID: <938144ae-595d-80a5-f440-c2ca1ee0bd85@oracle.com>
These are mispositioned tags.? I've created --
https://bugs.openjdk.java.net/browse/JDK-8225151
Robert
On 5/30/19 1:44 PM, Jonathan Gibbons wrote:
> Joe, Robert,
>
> We recently changed the support for the @jls tag, and I note that it
> conflicts with a style of usage that we did not detect previously with
> line-based tools (i.e. grep.)
>
> This is one of a few similar occurrences in Snippet.java
>
>
> ???????? * @jls 8.3 Field Declarations
> ???????? *
> ???????? * A variable declaration is {@linkplain Kind#isPersistent()
> persistent}.
>
> The problem is that as it currently stands, the @jls tag will detect
> the 8.3 and then attempt to put a`` ... `` aound the
> rest of the content. That's bad in this case, because you can't have
> `
` inside ``.
>
>
> There are two ways forward:
>
> 1. Remove the extra text, and/or restructure the doc comment so that
> the extra text is not part of @jls
>
> 2. Maybe update the @jls taglet to modify its behavior in the face of
> more complex HTML content.
>
> My reading of the document is that these paragraphs should be moved
> before the @jls reference, because they do not appear to be part of
> the @jls reference.
>
> Comments, suggestions?
>
> -- Jon
>
From robert.field at oracle.com Sat Jun 1 23:13:17 2019
From: robert.field at oracle.com (Robert Field)
Date: Sat, 1 Jun 2019 16:13:17 -0700
Subject: RFR: JShell API: Fix position of @jls tag
Message-ID:
Please review...
Bug: https://bugs.openjdk.java.net/browse/JDK-8225151
Fixed raw javadoc:
http://cr.openjdk.java.net/~rfield/8225151v1.Snippet.Kind.html#IMPORT
Webrev: http://cr.openjdk.java.net/~rfield/8225151v1.webrev/
Or easier....
diffdoc
Thanks,
Robert
From jan.lahoda at oracle.com Mon Jun 3 13:14:49 2019
From: jan.lahoda at oracle.com (Jan Lahoda)
Date: Mon, 3 Jun 2019 15:14:49 +0200
Subject: RFR 8199623: JShell: corralling not restored on drop
In-Reply-To:
References:
Message-ID:
Looks OK to me.
Jan
On 24. 05. 19 7:39, Robert Field wrote:
> Please review --
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8199623
>
> Webrev: http://cr.openjdk.java.net/~rfield/8199623.webrev01/
>
>
> Thanks,
> Robert
>
From jan.lahoda at oracle.com Mon Jun 3 13:27:00 2019
From: jan.lahoda at oracle.com (Jan Lahoda)
Date: Mon, 3 Jun 2019 15:27:00 +0200
Subject: RFR: JDK-8223782: jshell parser should handle Text Blocks
Message-ID: <5fe2e14a-58c5-9ed3-2a6e-3fc1a4b1eefd@oracle.com>
Hi,
In order to support text blocks (JEP 355) in JShell, it seems the main
thing is to correctly detect snippet completion - after that, the
ordinary javac parser should be able to handle the snippet. Proposed
update to the completeness detection, based on how block comments are
handled:
http://cr.openjdk.java.net/~jlahoda/8223782/webrev.00/
This also removes support for raw string literals.
The detection current marks invalid text blocks (such that they don't
have a newline after the opening """) as incomplete - when the snippet
is finished, the standard javac parser should handle that properly (and
the user has an opportunity to edit the snippet to be proper).
JBS: https://bugs.openjdk.java.net/browse/JDK-8223782
What do you think?
Thanks,
Jan
From james.laskey at oracle.com Mon Jun 3 14:17:11 2019
From: james.laskey at oracle.com (Jim Laskey)
Date: Mon, 3 Jun 2019 11:17:11 -0300
Subject: RFR: JDK-8223782: jshell parser should handle Text Blocks
In-Reply-To: <5fe2e14a-58c5-9ed3-2a6e-3fc1a4b1eefd@oracle.com>
References: <5fe2e14a-58c5-9ed3-2a6e-3fc1a4b1eefd@oracle.com>
Message-ID: <6122A31C-45AA-4247-86FD-EACF7E62BBF8@oracle.com>
+1
Works for me.
> On Jun 3, 2019, at 10:27 AM, Jan Lahoda wrote:
>
> Hi,
>
> In order to support text blocks (JEP 355) in JShell, it seems the main thing is to correctly detect snippet completion - after that, the ordinary javac parser should be able to handle the snippet. Proposed update to the completeness detection, based on how block comments are handled:
> http://cr.openjdk.java.net/~jlahoda/8223782/webrev.00/
>
> This also removes support for raw string literals.
>
> The detection current marks invalid text blocks (such that they don't have a newline after the opening """) as incomplete - when the snippet is finished, the standard javac parser should handle that properly (and the user has an opportunity to edit the snippet to be proper).
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8223782
>
> What do you think?
>
> Thanks,
> Jan
From jonathan.gibbons at oracle.com Mon Jun 3 14:27:52 2019
From: jonathan.gibbons at oracle.com (Jonathan Gibbons)
Date: Mon, 3 Jun 2019 07:27:52 -0700
Subject: RFR: JShell API: Fix position of @jls tag
In-Reply-To:
References:
Message-ID: <190ff17f-87d8-8ff4-0787-2542f52bc418@oracle.com>
Looks good to me.
-- Jon
On 6/1/19 4:13 PM, Robert Field wrote:
>
> Please review...
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8225151
>
> Fixed raw javadoc:
> http://cr.openjdk.java.net/~rfield/8225151v1.Snippet.Kind.html#IMPORT
>
> Webrev: http://cr.openjdk.java.net/~rfield/8225151v1.webrev/
>
> Or easier....
>
> diffdoc
>
>
> Thanks,
> Robert
>
>
>
>
From jan.lahoda at oracle.com Mon Jun 3 15:00:10 2019
From: jan.lahoda at oracle.com (Jan Lahoda)
Date: Mon, 3 Jun 2019 17:00:10 +0200
Subject: RFR: JShell API: Fix position of @jls tag
In-Reply-To:
References:
Message-ID: <8e235672-3f53-1366-0015-f790d0740b7f@oracle.com>
Looks OK to me.
Jan
On 02. 06. 19 1:13, Robert Field wrote:
> Please review...
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8225151
>
> Fixed raw javadoc:
> http://cr.openjdk.java.net/~rfield/8225151v1.Snippet.Kind.html#IMPORT
>
> Webrev: http://cr.openjdk.java.net/~rfield/8225151v1.webrev/
>
> Or easier....
>
> diffdoc
>
>
> Thanks,
> Robert
>
>
>
>
From robert.field at oracle.com Mon Jun 3 15:03:36 2019
From: robert.field at oracle.com (Robert Field)
Date: Mon, 3 Jun 2019 08:03:36 -0700
Subject: RFR: JDK-8223782: jshell parser should handle Text Blocks
In-Reply-To: <5fe2e14a-58c5-9ed3-2a6e-3fc1a4b1eefd@oracle.com>
References: <5fe2e14a-58c5-9ed3-2a6e-3fc1a4b1eefd@oracle.com>
Message-ID:
Looks good.
-Robert
On 6/3/19 6:27 AM, Jan Lahoda wrote:
> Hi,
>
> In order to support text blocks (JEP 355) in JShell, it seems the main
> thing is to correctly detect snippet completion - after that, the
> ordinary javac parser should be able to handle the snippet. Proposed
> update to the completeness detection, based on how block comments are
> handled:
> http://cr.openjdk.java.net/~jlahoda/8223782/webrev.00/
>
> This also removes support for raw string literals.
>
> The detection current marks invalid text blocks (such that they don't
> have a newline after the opening """) as incomplete - when the snippet
> is finished, the standard javac parser should handle that properly
> (and the user has an opportunity to edit the snippet to be proper).
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8223782
>
> What do you think?
>
> Thanks,
> ??? Jan
From robert.field at oracle.com Mon Jun 3 23:08:11 2019
From: robert.field at oracle.com (Robert Field)
Date: Mon, 3 Jun 2019 16:08:11 -0700
Subject: RFR 8225208: Re-Problem list jdk/jshell/ExceptionsTest.java fails on
windows
Message-ID: <164a1f71-dfe2-c20d-a13a-42f1066f4730@oracle.com>
Please review --
Bug: https://bugs.openjdk.java.net/browse/JDK-8225208
> hg diff
diff -r 1a7f82c98eee test/langtools/ProblemList.txt
--- a/test/langtools/ProblemList.txt??? Mon Jun 03 11:04:24 2019 -0700
+++ b/test/langtools/ProblemList.txt??? Mon Jun 03 16:00:07 2019 -0700
@@ -37,7 +37,7 @@
?jdk/jshell/UserJdiUserRemoteTest.java 8173079??? linux-all
?jdk/jshell/UserInputTest.java 8169536??? generic-all
-## jdk/jshell/ExceptionsTest.java 8200701??? windows-all
+jdk/jshell/ExceptionsTest.java 8200701??? windows-all
?###########################################################################
?#
Thanks,
Robert
From jonathan.gibbons at oracle.com Mon Jun 3 23:14:32 2019
From: jonathan.gibbons at oracle.com (Jonathan Gibbons)
Date: Mon, 3 Jun 2019 16:14:32 -0700
Subject: RFR 8225208: Re-Problem list jdk/jshell/ExceptionsTest.java fails
on windows
In-Reply-To: <164a1f71-dfe2-c20d-a13a-42f1066f4730@oracle.com>
References: <164a1f71-dfe2-c20d-a13a-42f1066f4730@oracle.com>
Message-ID: <744d1704-9c37-c1b3-7a9f-4e1a5b3bc977@oracle.com>
OK
-- Jon
On 06/03/2019 04:08 PM, Robert Field wrote:
> Please review --
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8225208
>
>
> > hg diff
> diff -r 1a7f82c98eee test/langtools/ProblemList.txt
> --- a/test/langtools/ProblemList.txt??? Mon Jun 03 11:04:24 2019 -0700
> +++ b/test/langtools/ProblemList.txt??? Mon Jun 03 16:00:07 2019 -0700
> @@ -37,7 +37,7 @@
>
> ?jdk/jshell/UserJdiUserRemoteTest.java 8173079??? linux-all
> ?jdk/jshell/UserInputTest.java 8169536??? generic-all
> -## jdk/jshell/ExceptionsTest.java 8200701??? windows-all
> +jdk/jshell/ExceptionsTest.java 8200701??? windows-all
>
> ?###########################################################################
>
> ?#
>
>
> Thanks,
> Robert
>
>
From TOSHIONA at jp.ibm.com Fri Jun 7 07:19:11 2019
From: TOSHIONA at jp.ibm.com (Toshio 5 Nakamura)
Date: Fri, 7 Jun 2019 16:19:11 +0900
Subject: RFR: 8224184: jshell got IOException at exiting with AIX
In-Reply-To:
References:
Message-ID:
Gentle reminder.
> From: "Toshio 5 Nakamura"
> To: kulla-dev at openjdk.java.net
> Date: 2019/05/24 17:30
> Subject: [EXTERNAL] Re: RFR: 8224184: jshell got IOException at
> exiting with AIX
> Sent by: "kulla-dev"
>
> Hi,
>
> I think lacking of testcase may be a concern of my proposal.
> Honestly, I couldn't create an automated testcase of this problem.
> I tried to use shell script like below, but it cannot execute the
> problematic path.
>
> $ echo "/exit" | jshell
>
> I think the testcase needs to run on 'pty'.
>
> Manual instructions are very simple, though.
> 1. Open a terminal on AIX (or telnet/ssh to AIX)
> 2. Launch jshell
> 3. Type "/exit"
>
> Could you give me any advice?
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8224184
> Webrev: http://cr.openjdk.java.net/~tnakamura/8224184/webrev.00
>
> Thanks,
> Toshio Nakamura
> IBM Japan
>
> > From: "Toshio 5 Nakamura"
> > To: kulla-dev at openjdk.java.net
> > Date: 2019/05/20 17:13
> > Subject: [EXTERNAL] RFR: 8224184: jshell got IOException at exiting
with
> AIX
> > Sent by: "kulla-dev"
> >
> >
> > Hi,
> >
> > Could you review JDK-8224184: jshell got IOException at exiting with
AIX?
> > Also, I'd like to have a sponsor of the patch (I'm an author).
> >
> > Issue: https://bugs.openjdk.java.net/browse/JDK-8224184
> > Webrev: http://cr.openjdk.java.net/~tnakamura/8224184/webrev.00
> >
> > AIX doesn't show "min" or "time" by "stty -a" when "icanon" is defined.
> > This caused invalid value was trying to be set, and IOException was
> > thrown.
> >
> > Thanks,
> > Toshio Nakamura
> >
>
From robert.field at oracle.com Fri Jun 7 17:05:34 2019
From: robert.field at oracle.com (Robert Field)
Date: Fri, 7 Jun 2019 10:05:34 -0700
Subject: RFR: 8224184: jshell got IOException at exiting with AIX
In-Reply-To:
References:
Message-ID: <1f694ce2-18b1-300d-d21b-26c47c2cae47@oracle.com>
There are fixes for which the test is not possible or very hard, that is
OK (there is even a special label for this case), they should still be
fixed.
The fix looks very reasonable to me.? You are checking for a failure
case that wasn't checked for before.? The behavior (by code inspection,
and your report) without your fix is clearly wrong.? Ignoring the
character seems the best and safest choice.
Jan is in charge of the internal JLine version.? I know he has a lot of
pans in the fire right now.
Jan: please let us know if I should be the sponsor of the patch, or you
would?
Thanks,
Robert
On 5/23/19 11:47 PM, Toshio 5 Nakamura wrote:
> Hi,
>
> I think lacking of testcase may be a concern of my proposal.
> Honestly, I couldn't create an automated testcase of this problem.
> I tried to use shell script like below, but it cannot execute the
> problematic path.
>
> $ echo "/exit" | jshell
>
> I think the testcase needs to run on 'pty'.
>
> Manual instructions are very simple, though.
> 1. Open a terminal on AIX (or telnet/ssh to AIX)
> 2. Launch jshell
> 3. Type "/exit"
>
> Could you give me any advice?
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8224184
> Webrev: http://cr.openjdk.java.net/~tnakamura/8224184/webrev.00/
>
> Thanks,
> Toshio Nakamura
> IBM Japan
>
>> From: "Toshio 5 Nakamura"
>> To: kulla-dev at openjdk.java.net
>> Date: 2019/05/20 17:13
>> Subject: [EXTERNAL] RFR: 8224184: jshell got IOException at exiting with
> AIX
>> Sent by: "kulla-dev"
>>
>>
>> Hi,
>>
>> Could you review JDK-8224184: jshell got IOException at exiting with AIX?
>> Also, I'd like to have a sponsor of the patch (I'm an author).
>>
>> Issue: https://urldefense.proofpoint.com/v2/url?
>>
> u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8224184&d=DwIFAg&c=jf_iaSHvJObTbx-
>
>> siA1ZOg&r=EVbFABcgo-X99_TGI2-
>>
> qsMtyulHUruf8lAzMlVpVRqw&m=t8kIXQoVdkkBGhnWC09eRlCUxlXUlvabknJjA5SSotI&s=9LIfd1v5UBKEvYKAIm6tDtqYTlD6QK-
>
>> jRl1I8HHIu5g&e=
>> Webrev: https://urldefense.proofpoint.com/v2/url?
>> u=http-3A__cr.openjdk.java.net_-7Etnakamura_8224184_webrev.
>> 00&d=DwIFAg&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-
>>
> qsMtyulHUruf8lAzMlVpVRqw&m=t8kIXQoVdkkBGhnWC09eRlCUxlXUlvabknJjA5SSotI&s=VC54L6HMLzUBB-3DcRQdr55JQda5wgw8r9SgxOvjkvA&e=
>
>> AIX doesn't show "min" or "time" by "stty -a" when "icanon" is defined.
>> This caused invalid value was trying to be set, and IOException was
> thrown.
>> Thanks,
>> Toshio Nakamura
>>
From TOSHIONA at jp.ibm.com Tue Jun 11 13:09:23 2019
From: TOSHIONA at jp.ibm.com (Toshio 5 Nakamura)
Date: Tue, 11 Jun 2019 22:09:23 +0900
Subject: RFR: 8224184: jshell got IOException at exiting with AIX
In-Reply-To: <1f694ce2-18b1-300d-d21b-26c47c2cae47@oracle.com>
References:
<1f694ce2-18b1-300d-d21b-26c47c2cae47@oracle.com>
Message-ID:
Hi Robert,
Thank you for review.
Hi Jan,
Sorry for bothering you, but can we have your opinion by RDP1?
Thanks,
Toshio Nakamura
Robert Field wrote on 2019/06/08 02:05:34:
> From: Robert Field
> To: Toshio 5 Nakamura , kulla-
> dev at openjdk.java.net, Jan Lahoda
> Date: 2019/06/08 02:05
> Subject: [EXTERNAL] Re: RFR: 8224184: jshell got IOException at
> exiting with AIX
>
> There are fixes for which the test is not possible or very hard, that is
> OK (there is even a special label for this case), they should still be
> fixed.
>
> The fix looks very reasonable to me.? You are checking for a failure
> case that wasn't checked for before.? The behavior (by code inspection,
> and your report) without your fix is clearly wrong.? Ignoring the
> character seems the best and safest choice.
>
> Jan is in charge of the internal JLine version.? I know he has a lot of
> pans in the fire right now.
>
> Jan: please let us know if I should be the sponsor of the patch, or you
> would?
>
> Thanks,
> Robert
>
>
> On 5/23/19 11:47 PM, Toshio 5 Nakamura wrote:
> > Hi,
> >
> > I think lacking of testcase may be a concern of my proposal.
> > Honestly, I couldn't create an automated testcase of this problem.
> > I tried to use shell script like below, but it cannot execute the
> > problematic path.
> >
> > $ echo "/exit" | jshell
> >
> > I think the testcase needs to run on 'pty'.
> >
> > Manual instructions are very simple, though.
> > 1. Open a terminal on AIX (or telnet/ssh to AIX)
> > 2. Launch jshell
> > 3. Type "/exit"
> >
> > Could you give me any advice?
> >
> > Issue:
https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8224184&d=DwIDaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=Y65B67F4evxb8ykBzkcIMMC_TXJYqhC8kvpd6fk5XKE&s=dOSPlb7txWCfq4REHz9jIA35jRMi4yBoHIPZccGNbi0&e=
> > Webrev:
https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Etnakamura_8224184_webrev.00_&d=DwIDaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=Y65B67F4evxb8ykBzkcIMMC_TXJYqhC8kvpd6fk5XKE&s=T7Tjt6cmzkJanpnfiz4asDUD7GeQ-BwX0yU2ITg4ojU&e=
> >
> > Thanks,
> > Toshio Nakamura
> > IBM Japan
> >
> >> From: "Toshio 5 Nakamura"
> >> To: kulla-dev at openjdk.java.net
> >> Date: 2019/05/20 17:13
> >> Subject: [EXTERNAL] RFR: 8224184: jshell got IOException at exiting
with
> > AIX
> >> Sent by: "kulla-dev"
> >>
> >>
> >> Hi,
> >>
> >> Could you review JDK-8224184: jshell got IOException at exiting with
AIX?
> >> Also, I'd like to have a sponsor of the patch (I'm an author).
> >>
> >> Issue: https://urldefense.proofpoint.com/v2/url?
> >>
> >
>
u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8224184&d=DwIFAg&c=jf_iaSHvJObTbx-
> >
> >> siA1ZOg&r=EVbFABcgo-X99_TGI2-
> >>
> >
>
qsMtyulHUruf8lAzMlVpVRqw&m=t8kIXQoVdkkBGhnWC09eRlCUxlXUlvabknJjA5SSotI&s=9LIfd1v5UBKEvYKAIm6tDtqYTlD6QK-
> >
> >> jRl1I8HHIu5g&e=
> >> Webrev: https://urldefense.proofpoint.com/v2/url?
> >> u=http-3A__cr.openjdk.java.net_-7Etnakamura_8224184_webrev.
> >> 00&d=DwIFAg&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-
> >>
> >
>
qsMtyulHUruf8lAzMlVpVRqw&m=t8kIXQoVdkkBGhnWC09eRlCUxlXUlvabknJjA5SSotI&s=VC54L6HMLzUBB-3DcRQdr55JQda5wgw8r9SgxOvjkvA&e=
> >
> >> AIX doesn't show "min" or "time" by "stty -a" when "icanon" is
defined.
> >> This caused invalid value was trying to be set, and IOException was
> > thrown.
> >> Thanks,
> >> Toshio Nakamura
> >>
>
From jan.lahoda at oracle.com Tue Jun 11 13:30:50 2019
From: jan.lahoda at oracle.com (Jan Lahoda)
Date: Tue, 11 Jun 2019 15:30:50 +0200
Subject: RFR: 8224184: jshell got IOException at exiting with AIX
In-Reply-To:
References:
<1f694ce2-18b1-300d-d21b-26c47c2cae47@oracle.com>
Message-ID:
Hi Toshio,
I think the change is fine, and I can sponsor the change.
It might be possible to create a unit-like test by doing something like:
class TestExecPty extends ExecPty {
public List getFlagsToSet(Attributes attr, Attributes
current) {
return super.getFlagsToSet(attr, current);
}
}
and then:
new TestExecPty().getFlagsToSet(..., ...)
with carefully prepared Attributes sent to the method. (Having this
would help to ensure this does not break on updates of the library.)
Thanks,
Jan
On 11. 06. 19 15:09, Toshio 5 Nakamura wrote:
> Hi Robert,
> Thank you for review.
>
> Hi Jan,
> Sorry for bothering you, but can we have your opinion by RDP1?
>
> Thanks,
> Toshio Nakamura
>
> Robert Field wrote on 2019/06/08 02:05:34:
>
> > From: Robert Field
> > To: Toshio 5 Nakamura , kulla-
> > dev at openjdk.java.net, Jan Lahoda
> > Date: 2019/06/08 02:05
> > Subject: [EXTERNAL] Re: RFR: 8224184: jshell got IOException at
> > exiting with AIX
> >
> > There are fixes for which the test is not possible or very hard, that is
> > OK (there is even a special label for this case), they should still be
> > fixed.
> >
> > The fix looks very reasonable to me.? You are checking for a failure
> > case that wasn't checked for before.? The behavior (by code inspection,
> > and your report) without your fix is clearly wrong.? Ignoring the
> > character seems the best and safest choice.
> >
> > Jan is in charge of the internal JLine version.? I know he has a lot of
> > pans in the fire right now.
> >
> > Jan: please let us know if I should be the sponsor of the patch, or you
> > would?
> >
> > Thanks,
> > Robert
> >
> >
> > On 5/23/19 11:47 PM, Toshio 5 Nakamura wrote:
> > > Hi,
> > >
> > > I think lacking of testcase may be a concern of my proposal.
> > > Honestly, I couldn't create an automated testcase of this problem.
> > > I tried to use shell script like below, but it cannot execute the
> > > problematic path.
> > >
> > > $ echo "/exit" | jshell
> > >
> > > I think the testcase needs to run on 'pty'.
> > >
> > > Manual instructions are very simple, though.
> > > 1. Open a terminal on AIX (or telnet/ssh to AIX)
> > > 2. Launch jshell
> > > 3. Type "/exit"
> > >
> > > Could you give me any advice?
> > >
> > > Issue: https://bugs.openjdk.java.net/browse/JDK-8224184
> > > Webrev: http://cr.openjdk.java.net/~tnakamura/8224184/webrev.00/
> > >
> > > Thanks,
> > > Toshio Nakamura
> > > IBM Japan
> > >
> > >> From: "Toshio 5 Nakamura"
> > >> To: kulla-dev at openjdk.java.net
> > >> Date: 2019/05/20 17:13
> > >> Subject: [EXTERNAL] RFR: 8224184: jshell got IOException at
> exiting with
> > > AIX
> > >> Sent by: "kulla-dev"
> > >>
> > >>
> > >> Hi,
> > >>
> > >> Could you review JDK-8224184: jshell got IOException at exiting
> with AIX?
> > >> Also, I'd like to have a sponsor of the patch (I'm an author).
> > >>
> > >> Issue: INVALID URI REMOVED
> > >>
> > >
> >
> u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8224184&d=DwIFAg&c=jf_iaSHvJObTbx-
> > >
> > >> siA1ZOg&r=EVbFABcgo-X99_TGI2-
> > >>
> > >
> >
> qsMtyulHUruf8lAzMlVpVRqw&m=t8kIXQoVdkkBGhnWC09eRlCUxlXUlvabknJjA5SSotI&s=9LIfd1v5UBKEvYKAIm6tDtqYTlD6QK-
> > >
> > >> jRl1I8HHIu5g&e=
> > >> Webrev: INVALID URI REMOVED
> > >> u=http-3A__cr.openjdk.java.net_-7Etnakamura_8224184_webrev.
> > >> 00&d=DwIFAg&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-
> > >>
> > >
> >
> qsMtyulHUruf8lAzMlVpVRqw&m=t8kIXQoVdkkBGhnWC09eRlCUxlXUlvabknJjA5SSotI&s=VC54L6HMLzUBB-3DcRQdr55JQda5wgw8r9SgxOvjkvA&e=
> > >
> > >> AIX doesn't show "min" or "time" by "stty -a" when "icanon" is
> defined.
> > >> This caused invalid value was trying to be set, and IOException was
> > > thrown.
> > >> Thanks,
> > >> Toshio Nakamura
> > >>
> >
>
From TOSHIONA at jp.ibm.com Wed Jun 12 09:18:07 2019
From: TOSHIONA at jp.ibm.com (Toshio 5 Nakamura)
Date: Wed, 12 Jun 2019 18:18:07 +0900
Subject: RFR: 8224184: jshell got IOException at exiting with AIX
In-Reply-To:
References:
<1f694ce2-18b1-300d-d21b-26c47c2cae47@oracle.com>
Message-ID:
Hi Jan,
Thank you so much for the great advice.
I could create a testcase for the issue.
Could you re-review the patch?
http://cr.openjdk.java.net/~tnakamura/8224184/webrev.01/
Thanks,
Toshio Nakamura
Jan Lahoda wrote on 2019/06/11 22:30:50:
> From: Jan Lahoda
> To: Toshio 5 Nakamura , Robert Field
>
> Cc: kulla-dev at openjdk.java.net
> Date: 2019/06/11 22:31
> Subject: [EXTERNAL] Re: RFR: 8224184: jshell got IOException at
> exiting with AIX
>
> Hi Toshio,
>
> I think the change is fine, and I can sponsor the change.
>
> It might be possible to create a unit-like test by doing something like:
> class TestExecPty extends ExecPty {
> public List getFlagsToSet(Attributes attr, Attributes
> current) {
> return super.getFlagsToSet(attr, current);
> }
> }
>
> and then:
> new TestExecPty().getFlagsToSet(..., ...)
>
> with carefully prepared Attributes sent to the method. (Having this
> would help to ensure this does not break on updates of the library.)
>
> Thanks,
> Jan
>
> On 11. 06. 19 15:09, Toshio 5 Nakamura wrote:
> > Hi Robert,
> > Thank you for review.
> >
> > Hi Jan,
> > Sorry for bothering you, but can we have your opinion by RDP1?
> >
> > Thanks,
> > Toshio Nakamura
> >
> > Robert Field wrote on 2019/06/08 02:05:34:
> >
> > > From: Robert Field
> > > To: Toshio 5 Nakamura , kulla-
> > > dev at openjdk.java.net, Jan Lahoda
> > > Date: 2019/06/08 02:05
> > > Subject: [EXTERNAL] Re: RFR: 8224184: jshell got IOException at
> > > exiting with AIX
> > >
> > > There are fixes for which the test is not possible or very hard,
that is
> > > OK (there is even a special label for this case), they should still
be
> > > fixed.
> > >
> > > The fix looks very reasonable to me.? You are checking for a failure
> > > case that wasn't checked for before.? The behavior (by code
inspection,
> > > and your report) without your fix is clearly wrong.? Ignoring the
> > > character seems the best and safest choice.
> > >
> > > Jan is in charge of the internal JLine version.? I know he has a lot
of
> > > pans in the fire right now.
> > >
> > > Jan: please let us know if I should be the sponsor of the patch, or
you
> > > would?
> > >
> > > Thanks,
> > > Robert
> > >
> > >
> > > On 5/23/19 11:47 PM, Toshio 5 Nakamura wrote:
> > > > Hi,
> > > >
> > > > I think lacking of testcase may be a concern of my proposal.
> > > > Honestly, I couldn't create an automated testcase of this problem.
> > > > I tried to use shell script like below, but it cannot execute the
> > > > problematic path.
> > > >
> > > > $ echo "/exit" | jshell
> > > >
> > > > I think the testcase needs to run on 'pty'.
> > > >
> > > > Manual instructions are very simple, though.
> > > > 1. Open a terminal on AIX (or telnet/ssh to AIX)
> > > > 2. Launch jshell
> > > > 3. Type "/exit"
> > > >
> > > > Could you give me any advice?
> > > >
> > > > Issue:
https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8224184&d=DwID-g&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=UU1x5Bo_JUr9KEACZW9OxDD3WYht8KipUQKt2b8JZEQ&s=lmDNn3cUJVPx1lsz_iJbL7i791TOy2089Ql0_eUkUHw&e=
> > > > Webrev:
https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Etnakamura_8224184_webrev.00_&d=DwID-g&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=UU1x5Bo_JUr9KEACZW9OxDD3WYht8KipUQKt2b8JZEQ&s=bJhZaUbUIBWEae3YhYXXrQaXL2GpmLEXSfeNTru_6Xk&e=
> > > >
> > > > Thanks,
> > > > Toshio Nakamura
> > > > IBM Japan
> > > >
> > > >> From: "Toshio 5 Nakamura"
> > > >> To: kulla-dev at openjdk.java.net
> > > >> Date: 2019/05/20 17:13
> > > >> Subject: [EXTERNAL] RFR: 8224184: jshell got IOException at
> > exiting with
> > > > AIX
> > > >> Sent by: "kulla-dev"
> > > >>
> > > >>
> > > >> Hi,
> > > >>
> > > >> Could you review JDK-8224184: jshell got IOException at exiting
> > with AIX?
> > > >> Also, I'd like to have a sponsor of the patch (I'm an author).
> > > >> AIX doesn't show "min" or "time" by "stty -a" when "icanon" is
> > defined.
> > > >> This caused invalid value was trying to be set, and IOException
was
> > > > thrown.
> > > >> Thanks,
> > > >> Toshio Nakamura
From jan.lahoda at oracle.com Wed Jun 12 09:25:14 2019
From: jan.lahoda at oracle.com (Jan Lahoda)
Date: Wed, 12 Jun 2019 11:25:14 +0200
Subject: RFR: 8224184: jshell got IOException at exiting with AIX
In-Reply-To:
References:
<1f694ce2-18b1-300d-d21b-26c47c2cae47@oracle.com>
Message-ID: <7b74c535-c587-17ce-a7c3-90dad5242b9d@oracle.com>
Looks good to me. Robert, I'll push tomorrow morning, unless you see a
problem in that.
Thanks,
Jan
On 12. 06. 19 11:18, Toshio 5 Nakamura wrote:
> Hi Jan,
>
> Thank you so much for the great advice.
> I could create a testcase for the issue.
>
> Could you re-review the patch?
> http://cr.openjdk.java.net/~tnakamura/8224184/webrev.01/
>
> Thanks,
> Toshio Nakamura
>
> Jan Lahoda wrote on 2019/06/11 22:30:50:
>
> > From: Jan Lahoda
> > To: Toshio 5 Nakamura , Robert Field
> >
> > Cc: kulla-dev at openjdk.java.net
> > Date: 2019/06/11 22:31
> > Subject: [EXTERNAL] Re: RFR: 8224184: jshell got IOException at
> > exiting with AIX
> >
> > Hi Toshio,
> >
> > I think the change is fine, and I can sponsor the change.
> >
> > It might be possible to create a unit-like test by doing something like:
> > class TestExecPty extends ExecPty {
> > ? ? ?public List getFlagsToSet(Attributes attr, Attributes
> > current) {
> > ? ? ? ? ?return super.getFlagsToSet(attr, current);
> > ? ? ?}
> > }
> >
> > and then:
> > new TestExecPty().getFlagsToSet(..., ...)
> >
> > with carefully prepared Attributes sent to the method. (Having this
> > would help to ensure this does not break on updates of the library.)
> >
> > Thanks,
> > ? ? ?Jan
> >
> > On 11. 06. 19 15:09, Toshio 5 Nakamura wrote:
> > > Hi Robert,
> > > Thank you for review.
> > >
> > > Hi Jan,
> > > Sorry for bothering you, but can we have your opinion by RDP1?
> > >
> > > Thanks,
> > > Toshio Nakamura
> > >
> > > Robert Field wrote on 2019/06/08 02:05:34:
> > >
> > > ?> From: Robert Field
> > > ?> To: Toshio 5 Nakamura , kulla-
> > > ?> dev at openjdk.java.net, Jan Lahoda
> > > ?> Date: 2019/06/08 02:05
> > > ?> Subject: [EXTERNAL] Re: RFR: 8224184: jshell got IOException at
> > > ?> exiting with AIX
> > > ?>
> > > ?> There are fixes for which the test is not possible or very hard,
> that is
> > > ?> OK (there is even a special label for this case), they should
> still be
> > > ?> fixed.
> > > ?>
> > > ?> The fix looks very reasonable to me.? You are checking for a failure
> > > ?> case that wasn't checked for before.? The behavior (by code
> inspection,
> > > ?> and your report) without your fix is clearly wrong.? Ignoring the
> > > ?> character seems the best and safest choice.
> > > ?>
> > > ?> Jan is in charge of the internal JLine version.? I know he has a
> lot of
> > > ?> pans in the fire right now.
> > > ?>
> > > ?> Jan: please let us know if I should be the sponsor of the patch,
> or you
> > > ?> would?
> > > ?>
> > > ?> Thanks,
> > > ?> Robert
> > > ?>
> > > ?>
> > > ?> On 5/23/19 11:47 PM, Toshio 5 Nakamura wrote:
> > > ?> > Hi,
> > > ?> >
> > > ?> > I think lacking of testcase may be a concern of my proposal.
> > > ?> > Honestly, I couldn't create an automated testcase of this problem.
> > > ?> > I tried to use shell script like below, but it cannot execute the
> > > ?> > problematic path.
> > > ?> >
> > > ?> > $ echo "/exit" | jshell
> > > ?> >
> > > ?> > I think the testcase needs to run on 'pty'.
> > > ?> >
> > > ?> > Manual instructions are very simple, though.
> > > ?> > 1. Open a terminal on AIX (or telnet/ssh to AIX)
> > > ?> > 2. Launch jshell
> > > ?> > 3. Type "/exit"
> > > ?> >
> > > ?> > Could you give me any advice?
> > > ?> >
> > > ?> > Issue: https://bugs.openjdk.java.net/browse/JDK-8224184
> > > ?> > Webrev: http://cr.openjdk.java.net/~tnakamura/8224184/webrev.00/
> > > ?> >
> > > ?> > Thanks,
> > > ?> > Toshio Nakamura
> > > ?> > IBM Japan
> > > ?> >
> > > ?> >> From: "Toshio 5 Nakamura"
> > > ?> >> To: kulla-dev at openjdk.java.net
> > > ?> >> Date: 2019/05/20 17:13
> > > ?> >> Subject: [EXTERNAL] RFR: 8224184: jshell got IOException at
> > > exiting with
> > > ?> > AIX
> > > ?> >> Sent by: "kulla-dev"
> > > ?> >>
> > > ?> >>
> > > ?> >> Hi,
> > > ?> >>
> > > ?> >> Could you review JDK-8224184: jshell got IOException at exiting
> > > with AIX?
> > > ?> >> Also, I'd like to have a sponsor of the patch (I'm an author).
> > > ?> >> AIX doesn't show "min" or "time" by "stty -a" when "icanon" is
> > > defined.
> > > ?> >> This caused invalid value was trying to be set, and
> IOException was
> > > ?> > thrown.
> > > ?> >> Thanks,
> > > ?> >> Toshio Nakamura
>
From robert.field at oracle.com Wed Jun 12 17:16:24 2019
From: robert.field at oracle.com (Robert Field)
Date: Wed, 12 Jun 2019 10:16:24 -0700
Subject: RFR: 8224184: jshell got IOException at exiting with AIX
In-Reply-To: <7b74c535-c587-17ce-a7c3-90dad5242b9d@oracle.com>
References:
<1f694ce2-18b1-300d-d21b-26c47c2cae47@oracle.com>
<7b74c535-c587-17ce-a7c3-90dad5242b9d@oracle.com>
Message-ID: <09d73b7a-d8f1-47ae-d488-a6d45515899a@oracle.com>
Thanks Jan!
Yes, please push.
-Robert
On 6/12/19 2:25 AM, Jan Lahoda wrote:
> Looks good to me. Robert, I'll push tomorrow morning, unless you see a
> problem in that.
>
> Thanks,
> ?? Jan
>
> On 12. 06. 19 11:18, Toshio 5 Nakamura wrote:
>> Hi Jan,
>>
>> Thank you so much for the great advice.
>> I could create a testcase for the issue.
>>
>> Could you re-review the patch?
>> http://cr.openjdk.java.net/~tnakamura/8224184/webrev.01/
>>
>> Thanks,
>> Toshio Nakamura
>>
>> Jan Lahoda wrote on 2019/06/11 22:30:50:
>>
>> ?> From: Jan Lahoda
>> ?> To: Toshio 5 Nakamura , Robert Field
>> ?>
>> ?> Cc: kulla-dev at openjdk.java.net
>> ?> Date: 2019/06/11 22:31
>> ?> Subject: [EXTERNAL] Re: RFR: 8224184: jshell got IOException at
>> ?> exiting with AIX
>> ?>
>> ?> Hi Toshio,
>> ?>
>> ?> I think the change is fine, and I can sponsor the change.
>> ?>
>> ?> It might be possible to create a unit-like test by doing something
>> like:
>> ?> class TestExecPty extends ExecPty {
>> ?> ? ? ?public List getFlagsToSet(Attributes attr, Attributes
>> ?> current) {
>> ?> ? ? ? ? ?return super.getFlagsToSet(attr, current);
>> ?> ? ? ?}
>> ?> }
>> ?>
>> ?> and then:
>> ?> new TestExecPty().getFlagsToSet(..., ...)
>> ?>
>> ?> with carefully prepared Attributes sent to the method. (Having this
>> ?> would help to ensure this does not break on updates of the library.)
>> ?>
>> ?> Thanks,
>> ?> ? ? ?Jan
>> ?>
>> ?> On 11. 06. 19 15:09, Toshio 5 Nakamura wrote:
>> ?> > Hi Robert,
>> ?> > Thank you for review.
>> ?> >
>> ?> > Hi Jan,
>> ?> > Sorry for bothering you, but can we have your opinion by RDP1?
>> ?> >
>> ?> > Thanks,
>> ?> > Toshio Nakamura
>> ?> >
>> ?> > Robert Field wrote on 2019/06/08
>> 02:05:34:
>> ?> >
>> ?> > ?> From: Robert Field
>> ?> > ?> To: Toshio 5 Nakamura , kulla-
>> ?> > ?> dev at openjdk.java.net, Jan Lahoda
>> ?> > ?> Date: 2019/06/08 02:05
>> ?> > ?> Subject: [EXTERNAL] Re: RFR: 8224184: jshell got IOException at
>> ?> > ?> exiting with AIX
>> ?> > ?>
>> ?> > ?> There are fixes for which the test is not possible or very
>> hard, that is
>> ?> > ?> OK (there is even a special label for this case), they should
>> still be
>> ?> > ?> fixed.
>> ?> > ?>
>> ?> > ?> The fix looks very reasonable to me.? You are checking for a
>> failure
>> ?> > ?> case that wasn't checked for before.? The behavior (by code
>> inspection,
>> ?> > ?> and your report) without your fix is clearly wrong.? Ignoring
>> the
>> ?> > ?> character seems the best and safest choice.
>> ?> > ?>
>> ?> > ?> Jan is in charge of the internal JLine version.? I know he
>> has a lot of
>> ?> > ?> pans in the fire right now.
>> ?> > ?>
>> ?> > ?> Jan: please let us know if I should be the sponsor of the
>> patch, or you
>> ?> > ?> would?
>> ?> > ?>
>> ?> > ?> Thanks,
>> ?> > ?> Robert
>> ?> > ?>
>> ?> > ?>
>> ?> > ?> On 5/23/19 11:47 PM, Toshio 5 Nakamura wrote:
>> ?> > ?> > Hi,
>> ?> > ?> >
>> ?> > ?> > I think lacking of testcase may be a concern of my proposal.
>> ?> > ?> > Honestly, I couldn't create an automated testcase of this
>> problem.
>> ?> > ?> > I tried to use shell script like below, but it cannot
>> execute the
>> ?> > ?> > problematic path.
>> ?> > ?> >
>> ?> > ?> > $ echo "/exit" | jshell
>> ?> > ?> >
>> ?> > ?> > I think the testcase needs to run on 'pty'.
>> ?> > ?> >
>> ?> > ?> > Manual instructions are very simple, though.
>> ?> > ?> > 1. Open a terminal on AIX (or telnet/ssh to AIX)
>> ?> > ?> > 2. Launch jshell
>> ?> > ?> > 3. Type "/exit"
>> ?> > ?> >
>> ?> > ?> > Could you give me any advice?
>> ?> > ?> >
>> ?> > ?> > Issue: https://bugs.openjdk.java.net/browse/JDK-8224184
>> ?> > ?> > Webrev:
>> http://cr.openjdk.java.net/~tnakamura/8224184/webrev.00/
>> ?> > ?> >
>> ?> > ?> > Thanks,
>> ?> > ?> > Toshio Nakamura
>> ?> > ?> > IBM Japan
>> ?> > ?> >
>> ?> > ?> >> From: "Toshio 5 Nakamura"
>> ?> > ?> >> To: kulla-dev at openjdk.java.net
>> ?> > ?> >> Date: 2019/05/20 17:13
>> ?> > ?> >> Subject: [EXTERNAL] RFR: 8224184: jshell got IOException at
>> ?> > exiting with
>> ?> > ?> > AIX
>> ?> > ?> >> Sent by: "kulla-dev"
>> ?> > ?> >>
>> ?> > ?> >>
>> ?> > ?> >> Hi,
>> ?> > ?> >>
>> ?> > ?> >> Could you review JDK-8224184: jshell got IOException at
>> exiting
>> ?> > with AIX?
>> ?> > ?> >> Also, I'd like to have a sponsor of the patch (I'm an
>> author).
>> ?> > ?> >> AIX doesn't show "min" or "time" by "stty -a" when
>> "icanon" is
>> ?> > defined.
>> ?> > ?> >> This caused invalid value was trying to be set, and
>> IOException was
>> ?> > ?> > thrown.
>> ?> > ?> >> Thanks,
>> ?> > ?> >> Toshio Nakamura
>>
From TOSHIONA at jp.ibm.com Thu Jun 13 07:46:37 2019
From: TOSHIONA at jp.ibm.com (Toshio 5 Nakamura)
Date: Thu, 13 Jun 2019 16:46:37 +0900
Subject: RFR: 8224184: jshell got IOException at exiting with AIX
In-Reply-To: <09d73b7a-d8f1-47ae-d488-a6d45515899a@oracle.com>
References:
<1f694ce2-18b1-300d-d21b-26c47c2cae47@oracle.com>
<7b74c535-c587-17ce-a7c3-90dad5242b9d@oracle.com>
<09d73b7a-d8f1-47ae-d488-a6d45515899a@oracle.com>
Message-ID:
Hi Jan, Robert,
Thank you for your kind support!
Toshio Nakamura
Robert Field wrote on 2019/06/13 02:16:24:
> From: Robert Field
> To: Jan Lahoda , Toshio 5 Nakamura
>
> Cc: kulla-dev at openjdk.java.net
> Date: 2019/06/13 02:17
> Subject: [EXTERNAL] Re: RFR: 8224184: jshell got IOException at
> exiting with AIX
>
> Thanks Jan!
>
> Yes, please push.
>
> -Robert
>
>
> On 6/12/19 2:25 AM, Jan Lahoda wrote:
> > Looks good to me. Robert, I'll push tomorrow morning, unless you see a
> > problem in that.
> >
> > Thanks,
> > ?? Jan
> >
> > On 12. 06. 19 11:18, Toshio 5 Nakamura wrote:
> >> Hi Jan,
> >>
> >> Thank you so much for the great advice.
> >> I could create a testcase for the issue.
> >>
> >> Could you re-review the patch?
> >>
https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Etnakamura_8224184_webrev.01_&d=DwID-g&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=K0TPg-JE9MCp7douy9-6UKxnD28-tZgttolS59yMNSg&s=KlCKJkypd37fyZkneyrpM-ujLlPGZWbJ0MkY5gAcA6k&e=
> >>
> >> Thanks,
> >> Toshio Nakamura
> >>
> >> Jan Lahoda wrote on 2019/06/11 22:30:50:
> >>
> >> ?> From: Jan Lahoda
> >> ?> To: Toshio 5 Nakamura , Robert Field
> >> ?>
> >> ?> Cc: kulla-dev at openjdk.java.net
> >> ?> Date: 2019/06/11 22:31
> >> ?> Subject: [EXTERNAL] Re: RFR: 8224184: jshell got IOException at
> >> ?> exiting with AIX
> >> ?>
> >> ?> Hi Toshio,
> >> ?>
> >> ?> I think the change is fine, and I can sponsor the change.
> >> ?>
> >> ?> It might be possible to create a unit-like test by doing something
> >> like:
> >> ?> class TestExecPty extends ExecPty {
> >> ?> ? ? ?public List getFlagsToSet(Attributes attr, Attributes
> >> ?> current) {
> >> ?> ? ? ? ? ?return super.getFlagsToSet(attr, current);
> >> ?> ? ? ?}
> >> ?> }
> >> ?>
> >> ?> and then:
> >> ?> new TestExecPty().getFlagsToSet(..., ...)
> >> ?>
> >> ?> with carefully prepared Attributes sent to the method. (Having this
> >> ?> would help to ensure this does not break on updates of the
library.)
> >> ?>
> >> ?> Thanks,
> >> ?> ? ? ?Jan
From robert.field at oracle.com Thu Jun 13 18:31:22 2019
From: robert.field at oracle.com (Robert Field)
Date: Thu, 13 Jun 2019 11:31:22 -0700
Subject: RFR: 8200701 et. al. JShell: three source<-->wrapper position mapping
issues
Message-ID:
Please review --
Bugs:
? 8200701: jdk/jshell/ExceptionsTest.java fails on Windows, after
JDK-8198801
https://bugs.openjdk.java.net/browse/JDK-8200701
? 8159740: JShell: corralled declarations do not have correct source to
wrapper mapping
https://bugs.openjdk.java.net/browse/JDK-8159740
? 8212167: JShell : Stack trace of exception has wrong line number
https://bugs.openjdk.java.net/browse/JDK-8212167
Underlying causes:
? Corralled (recoverable undeclared definitions) declarations were
built from String rather than position translating wraps.
? Inconsistent exclusive/inclusive ends of ranges, range wraps, and
lookups.
Webrev:
http://cr.openjdk.java.net/~rfield/8200701v0.webrev/
Thanks,
Robert
From jan.lahoda at oracle.com Fri Jun 14 18:05:56 2019
From: jan.lahoda at oracle.com (Jan Lahoda)
Date: Fri, 14 Jun 2019 20:05:56 +0200
Subject: RFR: 8200701 et. al. JShell: three source<-->wrapper position
mapping issues
In-Reply-To:
References:
Message-ID: <6f6e30c0-6346-370b-8b87-787a0afedfea@oracle.com>
Looks OK to me.
Jan
On 13. 06. 19 20:31, Robert Field wrote:
> Please review --
>
> Bugs:
>
> ? 8200701: jdk/jshell/ExceptionsTest.java fails on Windows, after
> JDK-8198801
> https://bugs.openjdk.java.net/browse/JDK-8200701
>
> ? 8159740: JShell: corralled declarations do not have correct source to
> wrapper mapping
> https://bugs.openjdk.java.net/browse/JDK-8159740
>
> ? 8212167: JShell : Stack trace of exception has wrong line number
> https://bugs.openjdk.java.net/browse/JDK-8212167
>
> Underlying causes:
>
> ? Corralled (recoverable undeclared definitions) declarations were
> built from String rather than position translating wraps.
>
> ? Inconsistent exclusive/inclusive ends of ranges, range wraps, and
> lookups.
>
> Webrev:
>
> http://cr.openjdk.java.net/~rfield/8200701v0.webrev/
>
>
> Thanks,
> Robert
>
>
From ryacobellis at luc.edu Wed Jun 19 14:27:15 2019
From: ryacobellis at luc.edu (Yacobellis, Robert)
Date: Wed, 19 Jun 2019 14:27:15 +0000
Subject: problem running jshell 12 or later using AT&T's UWIN ksh as its
environment on Win 10
Message-ID: <9789ca28f9f740feb2b858c32d7a5ed5@mbxls1.adms.luc.edu>
Hi, all,
This is probably not something you can fix for me, since I doubt that many others are using AT&T's UWIN to simulate Unix on Windows 10 ...
Through Java 11.0.3 I've been able to run jshell with no problems under ksh using UWIN; starting with Java 12 and through Java 13ea today running it throws an exception - I've attached captured outputs that indicate the PosixTerminal is unable to parse "columns".
Do you have any suggestions about how I might change the environment of jshell to get this to work? I think I remember some jline-related changes that were put into Java 12 that might be causing this interaction problem.
Thanks,
Bob Yacobellis
Loyola University Chicago
PS jshell 12 & 13ea work fine in a Windows 10 cmd console, so I can always run it there if I have to.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: jshell12errors.txt
URL:
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: jshell13eaerrors.txt
URL:
From robert.field at oracle.com Fri Jun 21 15:08:24 2019
From: robert.field at oracle.com (Robert Field)
Date: Fri, 21 Jun 2019 08:08:24 -0700
Subject: problem running jshell 12 or later using AT&T's UWIN ksh as its
environment on Win 10
In-Reply-To: <9789ca28f9f740feb2b858c32d7a5ed5@mbxls1.adms.luc.edu>
References: <9789ca28f9f740feb2b858c32d7a5ed5@mbxls1.adms.luc.edu>
Message-ID: <16b7a94da40.27ba.4011f3a8741ca2aabce58b8b81f42d24@oracle.com>
The Jline version was updated in JDK 12. You can configure Jline with your
terminal type.
Hope that helps,
Robert
On June 19, 2019 7:27:31 AM "Yacobellis, Robert" wrote:
> Hi, all,
>
> This is probably not something you can fix for me, since I doubt that many
> others are using AT&T's UWIN to simulate Unix on Windows 10 ...
>
> Through Java 11.0.3 I've been able to run jshell with no problems under ksh
> using UWIN; starting with Java 12 and through Java 13ea today running it
> throws an exception - I've attached captured outputs that indicate the
> PosixTerminal is unable to parse "columns".
>
> Do you have any suggestions about how I might change the environment of
> jshell to get this to work? I think I remember some jline-related changes
> that were put into Java 12 that might be causing this interaction problem.
>
> Thanks,
> Bob Yacobellis
> Loyola University Chicago
>
> PS jshell 12 & 13ea work fine in a Windows 10 cmd console, so I can always
> run it there if I have to.