RFR: 8232856: jshell crashes when pressing up arrow after /! [v2]

[Paul Sandoz]

On Wed, 4 Nov 2020 13:39:23 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> When re-running snippets, we remove the last entry (which is e.g. '/!'), and then put the expanded code back. But, while adding the code back, it is detected the entry-to-be-added duplicates the previous entry and is not added. But an internal "index" value is not updated, and still has the value it had before the removal, leading to inconsistency in the history internal data, and eventually, to a crash. Calling resetIndex() should fix the internal data.
>
> Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8232856
>  - 8232856: jshell crashes when pressing up arrow after /!

Marked as reviewed by psandoz (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/173