Integrated: 8232856: jshell crashes when pressing up arrow after /!
Jan Lahoda
jlahoda at openjdk.java.net
Thu Nov 5 09:14:56 UTC 2020
On Tue, 15 Sep 2020 09:54:59 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
> When re-running snippets, we remove the last entry (which is e.g. '/!'), and then put the expanded code back. But, while adding the code back, it is detected the entry-to-be-added duplicates the previous entry and is not added. But an internal "index" value is not updated, and still has the value it had before the removal, leading to inconsistency in the history internal data, and eventually, to a crash. Calling resetIndex() should fix the internal data.
This pull request has now been integrated.
Changeset: cdef186c
Author: Jan Lahoda <jlahoda at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/cdef186c
Stats: 14 lines in 2 files changed: 13 ins; 0 del; 1 mod
8232856: jshell crashes when pressing up arrow after /!
Reviewed-by: psandoz
-------------
PR: https://git.openjdk.java.net/jdk/pull/173
More information about the kulla-dev
mailing list