RFR: 8247403: JShell: No custom input (e.g. from GUI) possible with JavaShellToolBuilder

Vicente Romero vromero at openjdk.java.net
Mon Apr 12 20:57:38 UTC 2021


On Wed, 10 Feb 2021 13:55:24 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> Basically, JShell's ConsoleIOContext always uses the JLine's default terminal, which uses System.in, or equivalent, for input. But, if the JShell tool has been created using JavaShellToolBuilder, a different input might have been provided. The proposed solution is to use a different JLine's terminal in this case, based on the provided input.

LGTM

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2509


More information about the kulla-dev mailing list