RFR: 8247403: JShell: No custom input (e.g. from GUI) possible with JavaShellToolBuilder [v2]

Jan Lahoda jlahoda at openjdk.java.net
Mon Apr 26 11:28:05 UTC 2021


> Basically, JShell's ConsoleIOContext always uses the JLine's default terminal, which uses System.in, or equivalent, for input. But, if the JShell tool has been created using JavaShellToolBuilder, a different input might have been provided. The proposed solution is to use a different JLine's terminal in this case, based on the provided input.

Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:

 - Restoring timeout.
 - Improving test.
 - Cleanup.
 - Adding an experimental API to select the JavaShell output format and the output terminal size.
 - Merge branch 'master' into JDK-8247404
 - When using JavaShellToolBuilder programmatically, make the characters sent to the output stream more consistent with the legacy behavior.
 - Merge branch 'master' into JDK-8247404
 - 8247403: JShell: No custom input (e.g. from GUI) possible with JavaShellToolBuilder

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2509/files
  - new: https://git.openjdk.java.net/jdk/pull/2509/files/96c44308..d7eacd6a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2509&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2509&range=00-01

  Stats: 177373 lines in 5587 files changed: 113750 ins; 40125 del; 23498 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2509.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2509/head:pull/2509

PR: https://git.openjdk.java.net/jdk/pull/2509


More information about the kulla-dev mailing list