From prappo at openjdk.java.net  Wed Dec  1 13:40:21 2021
From: prappo at openjdk.java.net (Pavel Rappo)
Date: Wed, 1 Dec 2021 13:40:21 GMT
Subject: RFR: JDK-8276674 : Malformed Javadoc inline tags in JDK source in
 java/util/stream
In-Reply-To: <NMEtofVxulh6JNDcOLF-zGYKB2gnLKUF-9Or07_oJ4k=.ecc5a86f-5d37-415b-a6b6-4104a12d8676@github.com>
References: <NMEtofVxulh6JNDcOLF-zGYKB2gnLKUF-9Or07_oJ4k=.ecc5a86f-5d37-415b-a6b6-4104a12d8676@github.com>
Message-ID: <r-dd6didFJ8p6RLL4EPWmS6JKC5L4HcdJMBUdPZKufY=.585d5650-23cf-4899-9ef8-70ab869c085b@github.com>

On Thu, 18 Nov 2021 03:22:50 GMT, Tim Prinzing <duke at openjdk.java.net> wrote:

> JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream

Given that this PR affects files that aren't rooted under java/util/stream, I would either rename the PR or exclude the unrelated files. If this PR is going to sit there for some more time, I would prefer the latter. This is because the PR has already conflicted with a few other issues related to malformed javadoc tags (e.g. JDK-8276683 and JDK-8276684).

So either rename and integrate soon, or exclude the unrelated files.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6443

From duke at openjdk.java.net  Thu Dec  2 02:36:47 2021
From: duke at openjdk.java.net (Tim Prinzing)
Date: Thu, 2 Dec 2021 02:36:47 GMT
Subject: RFR: JDK-8276674 : Malformed Javadoc inline tags in JDK source in
 java/util/stream [v2]
In-Reply-To: <NMEtofVxulh6JNDcOLF-zGYKB2gnLKUF-9Or07_oJ4k=.ecc5a86f-5d37-415b-a6b6-4104a12d8676@github.com>
References: <NMEtofVxulh6JNDcOLF-zGYKB2gnLKUF-9Or07_oJ4k=.ecc5a86f-5d37-415b-a6b6-4104a12d8676@github.com>
Message-ID: <TzkyN_WmuxVm2lVTwnD4-AmDckP5HA2HnpzLNxt3wzI=.3e6ca6e7-3d3c-4e68-846e-4e8698dbe1ac@github.com>

> JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream

Tim Prinzing has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Merge branch 'master' into JDK-8276674
 - Fixed @code and @link in some javadoc for JDK-8276674

-------------

Changes: https://git.openjdk.java.net/jdk/pull/6443/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6443&range=01
  Stats: 13 lines in 8 files changed: 0 ins; 0 del; 13 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6443.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6443/head:pull/6443

PR: https://git.openjdk.java.net/jdk/pull/6443

From bchristi at openjdk.java.net  Thu Dec  2 20:44:19 2021
From: bchristi at openjdk.java.net (Brent Christian)
Date: Thu, 2 Dec 2021 20:44:19 GMT
Subject: RFR: JDK-8276674 : Malformed Javadoc inline tags in JDK source
 [v2]
In-Reply-To: <TzkyN_WmuxVm2lVTwnD4-AmDckP5HA2HnpzLNxt3wzI=.3e6ca6e7-3d3c-4e68-846e-4e8698dbe1ac@github.com>
References: <NMEtofVxulh6JNDcOLF-zGYKB2gnLKUF-9Or07_oJ4k=.ecc5a86f-5d37-415b-a6b6-4104a12d8676@github.com>
 <TzkyN_WmuxVm2lVTwnD4-AmDckP5HA2HnpzLNxt3wzI=.3e6ca6e7-3d3c-4e68-846e-4e8698dbe1ac@github.com>
Message-ID: <0gXyEfJJNpaLR25-eBZpRR-Jn8dX0LCYxsEdBI3u5DA=.79af9dd2-895d-4f8c-b853-78a5d1ee2015@github.com>

On Thu, 2 Dec 2021 02:36:47 GMT, Tim Prinzing <duke at openjdk.java.net> wrote:

>> JDK-8276674 : Malformed Javadoc inline tags in JDK source
>
> Tim Prinzing has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge branch 'master' into JDK-8276674
>  - Fixed @code and @link in some javadoc for JDK-8276674

Looks good.  Thanks for renaming, per Pavel's suggestion.  I can sponsor this.

-------------

Marked as reviewed by bchristi (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6443

From duke at openjdk.java.net  Thu Dec  2 20:52:18 2021
From: duke at openjdk.java.net (Tim Prinzing)
Date: Thu, 2 Dec 2021 20:52:18 GMT
Subject: Integrated: JDK-8276674 : Malformed Javadoc inline tags in JDK source
In-Reply-To: <NMEtofVxulh6JNDcOLF-zGYKB2gnLKUF-9Or07_oJ4k=.ecc5a86f-5d37-415b-a6b6-4104a12d8676@github.com>
References: <NMEtofVxulh6JNDcOLF-zGYKB2gnLKUF-9Or07_oJ4k=.ecc5a86f-5d37-415b-a6b6-4104a12d8676@github.com>
Message-ID: <TIDuuTFNp21jEDE1HwoI-nTiN8C2ePPoBZFDvmt2aUE=.cbbf6a77-afb1-49a9-bf90-8994656e8c8d@github.com>

On Thu, 18 Nov 2021 03:22:50 GMT, Tim Prinzing <duke at openjdk.java.net> wrote:

> JDK-8276674 : Malformed Javadoc inline tags in JDK source

This pull request has now been integrated.

Changeset: 652b5f85
Author:    Tim Prinzing <tim at prinzing.net>
Committer: Brent Christian <bchristi at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/652b5f8546d0453238166f8fcd0cd3d882886bb4
Stats:     13 lines in 8 files changed: 0 ins; 0 del; 13 mod

8276674: Malformed Javadoc inline tags in JDK source

Reviewed-by: jjg, rriggs, prappo, bchristi

-------------

PR: https://git.openjdk.java.net/jdk/pull/6443

From vromero at openjdk.java.net  Mon Dec  6 17:53:12 2021
From: vromero at openjdk.java.net (Vicente Romero)
Date: Mon, 6 Dec 2021 17:53:12 GMT
Subject: RFR: 8277328: jdk/jshell/CommandCompletionTest.java failures on
 Windows
In-Reply-To: <JN3HWk0A5klUxlR_uaWre4AXFHGCxQtAnaENY8b7QjY=.a0f5f1fd-4365-4d89-ac05-0c6f5284eb0f@github.com>
References: <JN3HWk0A5klUxlR_uaWre4AXFHGCxQtAnaENY8b7QjY=.a0f5f1fd-4365-4d89-ac05-0c6f5284eb0f@github.com>
Message-ID: <BWklLG-no3RTBTrEXHPteELPklNZ7YUBo-0XotcBlPs=.9c98f2da-a18d-46b1-92d0-2c66c3b9a74f@github.com>

On Fri, 26 Nov 2021 14:42:45 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> The `CommandCompletionTest.java#testUserHome` test picks an existing file or directory in the user's home directory, and uses it to validate the behavior of completion after '~/'. The test fails if the test picks a directory with space.
> 
> This is not solely a problem in the test - JShell does not handle paths with spaces. The proposed solution is to allow spaces in paths to be escaped with '', and adjust tests accordingly.

lgtm

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6578

From jjg at openjdk.java.net  Fri Dec 10 01:56:54 2021
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Fri, 10 Dec 2021 01:56:54 GMT
Subject: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
Message-ID: <6EIsBtepK0yhT-JqZ_-fI70ZInbEwn4TXW1EmzGh0rA=.2524dccb-596e-44d4-9e08-6f5875c11679@github.com>

Please review this semi-automatic update for the nroff man pages for JDK 18.  The changes update the version number, copyright year, and incorporate the changes from the latest upstream files.

-------------

Commit messages:
 - JDK-8273179: Update nroff pages in JDK 18 before RC

Changes: https://git.openjdk.java.net/jdk18/pull/5/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk18&pr=5&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8273179
  Stats: 858 lines in 28 files changed: 448 ins; 146 del; 264 mod
  Patch: https://git.openjdk.java.net/jdk18/pull/5.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/5/head:pull/5

PR: https://git.openjdk.java.net/jdk18/pull/5

From dholmes at openjdk.java.net  Fri Dec 10 02:15:33 2021
From: dholmes at openjdk.java.net (David Holmes)
Date: Fri, 10 Dec 2021 02:15:33 GMT
Subject: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
In-Reply-To: <6EIsBtepK0yhT-JqZ_-fI70ZInbEwn4TXW1EmzGh0rA=.2524dccb-596e-44d4-9e08-6f5875c11679@github.com>
References: <6EIsBtepK0yhT-JqZ_-fI70ZInbEwn4TXW1EmzGh0rA=.2524dccb-596e-44d4-9e08-6f5875c11679@github.com>
Message-ID: <XrztouvnRkkwistowUfWLgdBTgHP0fRisw3FZGuvalE=.413f903f-4421-4369-9da2-05853a6aaecb@github.com>

On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review this semi-automatic update for the nroff man pages for JDK 18.  The changes update the version number, copyright year, and incorporate the changes from the latest upstream files.

Hi Jon,

This all looks good - I'm familiar with many of the changes made to the sources but not yet generated.

We will have to be careful not to regress the copyright year or version if any subsequent updates are made before next year, or before the version loses the EA designator.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk18/pull/5

From jjg at openjdk.java.net  Fri Dec 10 02:53:14 2021
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Fri, 10 Dec 2021 02:53:14 GMT
Subject: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
In-Reply-To: <6EIsBtepK0yhT-JqZ_-fI70ZInbEwn4TXW1EmzGh0rA=.2524dccb-596e-44d4-9e08-6f5875c11679@github.com>
References: <6EIsBtepK0yhT-JqZ_-fI70ZInbEwn4TXW1EmzGh0rA=.2524dccb-596e-44d4-9e08-6f5875c11679@github.com>
Message-ID: <2BrCSwVuXVmMEZE2lncn2i0_-o3_nsjrmLEGqXnz9Sw=.efac0d59-093f-4b4a-a6e3-96935e40538d@github.com>

On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review this semi-automatic update for the nroff man pages for JDK 18.  The changes update the version number, copyright year, and incorporate the changes from the latest upstream files.

Hi David,

The copyright year will naturally sort itself out in a few weeks time ;-)  

When these changes make their way down from 18 to 19, we will probably want to regenerate these files with 19-EA.

-- Jon

We will also want to regenerate any appropriate files if any more updates to the man pages are made during the ramp down period.

-------------

PR: https://git.openjdk.java.net/jdk18/pull/5

From jjg at openjdk.java.net  Fri Dec 10 02:53:14 2021
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Fri, 10 Dec 2021 02:53:14 GMT
Subject: [jdk18] Integrated: JDK-8273179: Update nroff pages in JDK 18 before
 RC
In-Reply-To: <6EIsBtepK0yhT-JqZ_-fI70ZInbEwn4TXW1EmzGh0rA=.2524dccb-596e-44d4-9e08-6f5875c11679@github.com>
References: <6EIsBtepK0yhT-JqZ_-fI70ZInbEwn4TXW1EmzGh0rA=.2524dccb-596e-44d4-9e08-6f5875c11679@github.com>
Message-ID: <aUgePa-CZTl_8YUtExHfRcG35KchfIqrsFZfnblx5Cw=.16776a76-72c6-4eb0-bfd7-1a7d25843819@github.com>

On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review this semi-automatic update for the nroff man pages for JDK 18.  The changes update the version number, copyright year, and incorporate the changes from the latest upstream files.

This pull request has now been integrated.

Changeset: ed5d53ae
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.java.net/jdk18/commit/ed5d53ae0eb0b12de11fb3d79ae0371c093ce434
Stats:     858 lines in 28 files changed: 448 ins; 146 del; 264 mod

8273179: Update nroff pages in JDK 18 before RC

Reviewed-by: dholmes

-------------

PR: https://git.openjdk.java.net/jdk18/pull/5

From iris at openjdk.java.net  Fri Dec 10 03:12:20 2021
From: iris at openjdk.java.net (Iris Clark)
Date: Fri, 10 Dec 2021 03:12:20 GMT
Subject: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
In-Reply-To: <6EIsBtepK0yhT-JqZ_-fI70ZInbEwn4TXW1EmzGh0rA=.2524dccb-596e-44d4-9e08-6f5875c11679@github.com>
References: <6EIsBtepK0yhT-JqZ_-fI70ZInbEwn4TXW1EmzGh0rA=.2524dccb-596e-44d4-9e08-6f5875c11679@github.com>
Message-ID: <6aEQaagQdXw209dha2rqp32uSxtxze-f-1-j32dROQE=.53c0fcde-680f-40c6-bbc7-44a1e4635f11@github.com>

On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review this semi-automatic update for the nroff man pages for JDK 18.  The changes update the version number, copyright year, and incorporate the changes from the latest upstream files.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk18/pull/5

From dholmes at openjdk.java.net  Fri Dec 10 04:21:18 2021
From: dholmes at openjdk.java.net (David Holmes)
Date: Fri, 10 Dec 2021 04:21:18 GMT
Subject: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
In-Reply-To: <2BrCSwVuXVmMEZE2lncn2i0_-o3_nsjrmLEGqXnz9Sw=.efac0d59-093f-4b4a-a6e3-96935e40538d@github.com>
References: <6EIsBtepK0yhT-JqZ_-fI70ZInbEwn4TXW1EmzGh0rA=.2524dccb-596e-44d4-9e08-6f5875c11679@github.com>
 <2BrCSwVuXVmMEZE2lncn2i0_-o3_nsjrmLEGqXnz9Sw=.efac0d59-093f-4b4a-a6e3-96935e40538d@github.com>
Message-ID: <qVuvwqe8lbBR-Web-A5nWUe6iY9w4VxcPcqZFqsmbqk=.f9daa291-cb0a-4c8f-ad0a-cde4ac1cf5ae@github.com>

On Fri, 10 Dec 2021 02:48:43 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review this semi-automatic update for the nroff man pages for JDK 18.  The changes update the version number, copyright year, and incorporate the changes from the latest upstream files.
>
> We will also want to regenerate any appropriate files if any more updates to the man pages are made during the ramp down period.

Hi @jonathan-gibbons ,

I have a couple of manpage related tasks for early in the 19 release cycle that will take care of updating the version number.

Unfortunately for this change it looks like whomever did the source uodate to the javadoc manpage did not know about the test:

test/langtools/jdk/javadoc/tool/CheckManPageOptions.java

which is now failing on all platforms. :( I will file a bug.

David

-------------

PR: https://git.openjdk.java.net/jdk18/pull/5

From jjg at openjdk.java.net  Fri Dec 10 04:33:14 2021
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Fri, 10 Dec 2021 04:33:14 GMT
Subject: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
In-Reply-To: <6EIsBtepK0yhT-JqZ_-fI70ZInbEwn4TXW1EmzGh0rA=.2524dccb-596e-44d4-9e08-6f5875c11679@github.com>
References: <6EIsBtepK0yhT-JqZ_-fI70ZInbEwn4TXW1EmzGh0rA=.2524dccb-596e-44d4-9e08-6f5875c11679@github.com>
Message-ID: <oP-JJ5AfuaU7KEDEmjWC-rZ0kVRFQy5KRAyWHyrukrg=.3670ffc5-0df7-41e6-afe6-66fbb8732685@github.com>

On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review this semi-automatic update for the nroff man pages for JDK 18.  The changes update the version number, copyright year, and incorporate the changes from the latest upstream files.

hmmm, I thought we had taken care of that test. I will investigate

-------------

PR: https://git.openjdk.java.net/jdk18/pull/5

From jwilhelm at openjdk.java.net  Fri Dec 10 18:13:18 2021
From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson)
Date: Fri, 10 Dec 2021 18:13:18 GMT
Subject: RFR: Merge jdk18
Message-ID: <NaqfEtc0QzHLCHXP3t87gEVkaqsHeJawyC5MvVPocOw=.6b092301-b363-4fbd-b52f-7edc2d0eafc7@github.com>

Forwardport JDK 18 -> JDK 19

-------------

Commit messages:
 - Merge
 - 8277621: ARM32: multiple fastdebug failures with "bad AD file" after JDK-8276162
 - 8278538: Test langtools/jdk/javadoc/tool/CheckManPageOptions.java fails after the manpage was updated
 - 8273179: Update nroff pages in JDK 18 before RC

The merge commit only contains trivial merges, so no merge-specific webrevs have been generated.

Changes: https://git.openjdk.java.net/jdk/pull/6802/files
  Stats: 1142 lines in 30 files changed: 688 ins; 155 del; 299 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6802.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6802/head:pull/6802

PR: https://git.openjdk.java.net/jdk/pull/6802

From jwilhelm at openjdk.java.net  Fri Dec 10 18:46:17 2021
From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson)
Date: Fri, 10 Dec 2021 18:46:17 GMT
Subject: Integrated: Merge jdk18
In-Reply-To: <NaqfEtc0QzHLCHXP3t87gEVkaqsHeJawyC5MvVPocOw=.6b092301-b363-4fbd-b52f-7edc2d0eafc7@github.com>
References: <NaqfEtc0QzHLCHXP3t87gEVkaqsHeJawyC5MvVPocOw=.6b092301-b363-4fbd-b52f-7edc2d0eafc7@github.com>
Message-ID: <kpQxjDOAP8oYJSlDDnHI_tQ-TqySIEgCecB0KZHOhlQ=.5b2f94bd-fbc6-4852-adbc-f0e5819b9f4a@github.com>

On Fri, 10 Dec 2021 17:51:31 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Forwardport JDK 18 -> JDK 19

This pull request has now been integrated.

Changeset: 61736f81
Author:    Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/61736f81fb4a20375c83d59e2b37a00aafb11107
Stats:     1142 lines in 30 files changed: 688 ins; 155 del; 299 mod

Merge

-------------

PR: https://git.openjdk.java.net/jdk/pull/6802

From duke at openjdk.java.net  Wed Dec 15 18:01:02 2021
From: duke at openjdk.java.net (Andrey Turbanov)
Date: Wed, 15 Dec 2021 18:01:02 GMT
Subject: RFR: 8277348: Use String.stripTrailing() in jdk.jshell where
 applicable
In-Reply-To: <9ZTNjFmoBgjdsjNcBVE9J0uAJK2ZeiPKu3fs3joLHbk=.76707c97-8bf0-4868-8cec-bf6b766df0fb@github.com>
References: <9ZTNjFmoBgjdsjNcBVE9J0uAJK2ZeiPKu3fs3joLHbk=.76707c97-8bf0-4868-8cec-bf6b766df0fb@github.com>
Message-ID: <aYbKjyVgcFoX1-OVdC95pWRehvE5tOs8-pxNFHqdtZQ=.2762814e-0e29-4d16-930b-d1c003949bc7@github.com>

On Fri, 12 Nov 2021 09:10:16 GMT, Andrey Turbanov <duke at openjdk.java.net> wrote:

> There are 2 methods in jdk.jshell module which trim trailing whitespace characters from String.
> 1. jdk.internal.jshell.tool.JShellTool#trimEnd
> 2. jdk.jshell.Util#trimEnd
> 
> Since Java 11 we have a method String.stripTrailing which could be used instead.

Let's review this small improvement :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/6365