From jlahoda at openjdk.java.net  Tue Jun  1 15:42:32 2021
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Tue, 1 Jun 2021 15:42:32 GMT
Subject: RFR: 8267459: Pasting Unicode characters into JShell does not
 work. [v3]
In-Reply-To: <vNl4e1jbEgfALsuDd7BGqZC4XX60BzrqiAtCBed2aqg=.12a0e800-44e5-4642-b2e2-5d500e12f85d@github.com>
References: <vNl4e1jbEgfALsuDd7BGqZC4XX60BzrqiAtCBed2aqg=.12a0e800-44e5-4642-b2e2-5d500e12f85d@github.com>
Message-ID: <LzrlbJQipX-isVqqvKUfuIuppEiaGKJ33S5JpcV2KWw=.af80ca28-deb5-4cf5-8d02-e76d7982cda5@github.com>

> The NonBlockingInputStreamReader.readBuffered method will read some bytes from the InputStream, and then try to convert them to characters. But, the input array may end in the middle of a sequence - e.g. it may end with a part of UTF-8 sequence, which will be only finished when the input is read next time.
> 
> The proposed fix is to store the trailing unused bytes into the `bytes` field, which is already used for a similar purpose by the other read method in this class, and use them on the next iteration.

Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - Merging master into JDK-8267459
 - Ensuring the test input is UTF-8, to allow tests pass regardless of configuration.
 - 8267459: Pasting Unicode characters into JShell does not work.

-------------

Changes: https://git.openjdk.java.net/jdk/pull/4128/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4128&range=02
  Stats: 36 lines in 3 files changed: 32 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4128.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4128/head:pull/4128

PR: https://git.openjdk.java.net/jdk/pull/4128

From vromero at openjdk.java.net  Tue Jun  1 16:43:22 2021
From: vromero at openjdk.java.net (Vicente Romero)
Date: Tue, 1 Jun 2021 16:43:22 GMT
Subject: RFR: 8267459: Pasting Unicode characters into JShell does not
 work. [v3]
In-Reply-To: <LzrlbJQipX-isVqqvKUfuIuppEiaGKJ33S5JpcV2KWw=.af80ca28-deb5-4cf5-8d02-e76d7982cda5@github.com>
References: <vNl4e1jbEgfALsuDd7BGqZC4XX60BzrqiAtCBed2aqg=.12a0e800-44e5-4642-b2e2-5d500e12f85d@github.com>
 <LzrlbJQipX-isVqqvKUfuIuppEiaGKJ33S5JpcV2KWw=.af80ca28-deb5-4cf5-8d02-e76d7982cda5@github.com>
Message-ID: <xkZD9CNGVIHT6ScIK32Sa2-TVOV5pfWS4BYKKidi06g=.673ac2f2-acd3-4f04-ad87-7e209b07e04b@github.com>

On Tue, 1 Jun 2021 15:42:32 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> The NonBlockingInputStreamReader.readBuffered method will read some bytes from the InputStream, and then try to convert them to characters. But, the input array may end in the middle of a sequence - e.g. it may end with a part of UTF-8 sequence, which will be only finished when the input is read next time.
>> 
>> The proposed fix is to store the trailing unused bytes into the `bytes` field, which is already used for a similar purpose by the other read method in this class, and use them on the next iteration.
>
> Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Merging master into JDK-8267459
>  - Ensuring the test input is UTF-8, to allow tests pass regardless of configuration.
>  - 8267459: Pasting Unicode characters into JShell does not work.

lgtm!

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4128

From jlahoda at openjdk.java.net  Wed Jun  2 09:58:40 2021
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Wed, 2 Jun 2021 09:58:40 GMT
Subject: Integrated: 8267459: Pasting Unicode characters into JShell does not
 work.
In-Reply-To: <vNl4e1jbEgfALsuDd7BGqZC4XX60BzrqiAtCBed2aqg=.12a0e800-44e5-4642-b2e2-5d500e12f85d@github.com>
References: <vNl4e1jbEgfALsuDd7BGqZC4XX60BzrqiAtCBed2aqg=.12a0e800-44e5-4642-b2e2-5d500e12f85d@github.com>
Message-ID: <lJQhNupI6LXq68sIfg3d0RolYMnJTKkLCdlc11-3CZQ=.b7cf5bfc-4946-4a7b-91a8-15fccdc4ac86@github.com>

On Thu, 20 May 2021 13:14:47 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> The NonBlockingInputStreamReader.readBuffered method will read some bytes from the InputStream, and then try to convert them to characters. But, the input array may end in the middle of a sequence - e.g. it may end with a part of UTF-8 sequence, which will be only finished when the input is read next time.
> 
> The proposed fix is to store the trailing unused bytes into the `bytes` field, which is already used for a similar purpose by the other read method in this class, and use them on the next iteration.

This pull request has now been integrated.

Changeset: de6472c4
Author:    Jan Lahoda <jlahoda at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/de6472c44166e57cd440b7bffcfc876585aca7dd
Stats:     36 lines in 3 files changed: 32 ins; 0 del; 4 mod

8267459: Pasting Unicode characters into JShell does not work.

Reviewed-by: vromero

-------------

PR: https://git.openjdk.java.net/jdk/pull/4128

From github.com+10835776+stsypanov at openjdk.java.net  Wed Jun  2 14:19:43 2021
From: github.com+10835776+stsypanov at openjdk.java.net (=?UTF-8?B?0KHQtdGA0LPQtdC5?= =?UTF-8?B?IA==?= =?UTF-8?B?0KbRi9C/0LDQvdC+0LI=?=)
Date: Wed, 2 Jun 2021 14:19:43 GMT
Subject: RFR: 8268113: Re-use Long.hashCode() where possible
In-Reply-To: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
References: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
Message-ID: <_TQh_iGjI3byKr1pc0gr7GZnCiyeKubYIy4rkLwbipY=.08915956-df4e-411e-b985-edd411a5bdc3@github.com>

On Wed, 2 Jun 2021 14:10:38 GMT, ?????? ??????? <github.com+10835776+stsypanov at openjdk.org> wrote:

> There is a few JDK classes duplicating the contents of Long.hashCode() for hash code calculation. They should explicitly delegate to Long.hashCode().

src/java.base/share/classes/java/util/BitSet.java line 1040:

> 1038:             h ^= words[i] * (i + 1);
> 1039: 
> 1040:         return Long.hashCode(h);

Here `>>` instead of `>>>` in original code seems to be a typo

-------------

PR: https://git.openjdk.java.net/jdk/pull/4309

From github.com+10835776+stsypanov at openjdk.java.net  Wed Jun  2 14:19:42 2021
From: github.com+10835776+stsypanov at openjdk.java.net (=?UTF-8?B?0KHQtdGA0LPQtdC5?= =?UTF-8?B?IA==?= =?UTF-8?B?0KbRi9C/0LDQvdC+0LI=?=)
Date: Wed, 2 Jun 2021 14:19:42 GMT
Subject: RFR: 8268113: Re-use Long.hashCode() where possible
Message-ID: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>

There is a few JDK classes duplicating the contents of Long.hashCode() for hash code calculation. They should explicitly delegate to Long.hashCode().

-------------

Commit messages:
 - 8268113: Re-use Long.hashCode() where possible

Changes: https://git.openjdk.java.net/jdk/pull/4309/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8268113
  Stats: 10 lines in 7 files changed: 1 ins; 0 del; 9 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4309.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4309/head:pull/4309

PR: https://git.openjdk.java.net/jdk/pull/4309

From github.com+7806504+liach at openjdk.java.net  Wed Jun  2 14:54:31 2021
From: github.com+7806504+liach at openjdk.java.net (liach)
Date: Wed, 2 Jun 2021 14:54:31 GMT
Subject: RFR: 8268113: Re-use Long.hashCode() where possible
In-Reply-To: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
References: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
Message-ID: <iwzs-BHBLELnoCif1WMC5_Np_O1VqzQxEaTmQJhsts8=.8034416f-f6cb-446b-9067-4e1e246f49fe@github.com>

On Wed, 2 Jun 2021 14:10:38 GMT, ?????? ??????? <github.com+10835776+stsypanov at openjdk.org> wrote:

> There is a few JDK classes duplicating the contents of Long.hashCode() for hash code calculation. They should explicitly delegate to Long.hashCode().

src/java.base/share/classes/java/lang/Double.java line 881:

> 879:     public static int hashCode(double value) {
> 880:         long bits = doubleToLongBits(value);
> 881:         return Long.hashCode(bits);

Imo these should be squashed to just 

return Long.hashCode(doubleToLongBits(value));

since the local variable is no longer meaningful. Previously, they were required as they were retrieved twice in hash code calculation.

Same for other usages.

src/java.desktop/macosx/classes/apple/laf/JRSUIConstants.java line 115:

> 113:         public int hashCode() {
> 114:             final long bits = Double.doubleToLongBits(doubleValue);
> 115:             return Long.hashCode(bits);

This one and the `DoubleDV` one should actually delegate to `Double.hashCode`, which delegates to `Long.hashCode` after this change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4309

From github.com+10835776+stsypanov at openjdk.java.net  Wed Jun  2 16:31:56 2021
From: github.com+10835776+stsypanov at openjdk.java.net (=?UTF-8?B?0KHQtdGA0LPQtdC5?= =?UTF-8?B?IA==?= =?UTF-8?B?0KbRi9C/0LDQvdC+0LI=?=)
Date: Wed, 2 Jun 2021 16:31:56 GMT
Subject: RFR: 8268113: Re-use Long.hashCode() where possible [v2]
In-Reply-To: <iwzs-BHBLELnoCif1WMC5_Np_O1VqzQxEaTmQJhsts8=.8034416f-f6cb-446b-9067-4e1e246f49fe@github.com>
References: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
 <iwzs-BHBLELnoCif1WMC5_Np_O1VqzQxEaTmQJhsts8=.8034416f-f6cb-446b-9067-4e1e246f49fe@github.com>
Message-ID: <R9BnT2zMSBJc1tJbLGDU3OJRV0WopCPq5zOz-Y9AZA0=.f5c97387-836a-479a-b839-dfdccc752181@github.com>

On Wed, 2 Jun 2021 14:51:35 GMT, liach <github.com+7806504+liach at openjdk.org> wrote:

>> ?????? ??????? has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8268113: Delegate to Double.hashCode()
>
> src/java.desktop/macosx/classes/apple/laf/JRSUIConstants.java line 115:
> 
>> 113:         public int hashCode() {
>> 114:             final long bits = Double.doubleToLongBits(doubleValue);
>> 115:             return Long.hashCode(bits);
> 
> This one and the `DoubleDV` one should actually delegate to `Double.hashCode`, which delegates to `Long.hashCode` after this change.

Good point, done!

-------------

PR: https://git.openjdk.java.net/jdk/pull/4309

From github.com+10835776+stsypanov at openjdk.java.net  Wed Jun  2 16:31:55 2021
From: github.com+10835776+stsypanov at openjdk.java.net (=?UTF-8?B?0KHQtdGA0LPQtdC5?= =?UTF-8?B?IA==?= =?UTF-8?B?0KbRi9C/0LDQvdC+0LI=?=)
Date: Wed, 2 Jun 2021 16:31:55 GMT
Subject: RFR: 8268113: Re-use Long.hashCode() where possible [v2]
In-Reply-To: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
References: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
Message-ID: <R7QLU7YkKu9xDjGiJ530O3COI4nKHtUW9O-7OE49cMU=.08736e98-47ee-47a1-a026-89f7fb927a39@github.com>

> There is a few JDK classes duplicating the contents of Long.hashCode() for hash code calculation. They should explicitly delegate to Long.hashCode().

?????? ??????? has updated the pull request incrementally with one additional commit since the last revision:

  8268113: Delegate to Double.hashCode()

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4309/files
  - new: https://git.openjdk.java.net/jdk/pull/4309/files/9c7ddc0c..3f5b431d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=00-01

  Stats: 4 lines in 2 files changed: 0 ins; 2 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4309.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4309/head:pull/4309

PR: https://git.openjdk.java.net/jdk/pull/4309

From github.com+10835776+stsypanov at openjdk.java.net  Wed Jun  2 16:37:51 2021
From: github.com+10835776+stsypanov at openjdk.java.net (=?UTF-8?B?0KHQtdGA0LPQtdC5?= =?UTF-8?B?IA==?= =?UTF-8?B?0KbRi9C/0LDQvdC+0LI=?=)
Date: Wed, 2 Jun 2021 16:37:51 GMT
Subject: RFR: 8268113: Re-use Long.hashCode() where possible [v3]
In-Reply-To: <iwzs-BHBLELnoCif1WMC5_Np_O1VqzQxEaTmQJhsts8=.8034416f-f6cb-446b-9067-4e1e246f49fe@github.com>
References: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
 <iwzs-BHBLELnoCif1WMC5_Np_O1VqzQxEaTmQJhsts8=.8034416f-f6cb-446b-9067-4e1e246f49fe@github.com>
Message-ID: <NsK_-cZySGW7iEFqmlfOx2m3-U1sxXrj2vZeeUnnvPs=.84143747-d762-42d2-915a-9ea43ccb0ed0@github.com>

On Wed, 2 Jun 2021 14:50:23 GMT, liach <github.com+7806504+liach at openjdk.org> wrote:

>> ?????? ??????? has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8268113: Inline local vars where reasonable
>
> src/java.base/share/classes/java/lang/Double.java line 881:
> 
>> 879:     public static int hashCode(double value) {
>> 880:         long bits = doubleToLongBits(value);
>> 881:         return Long.hashCode(bits);
> 
> Imo these should be squashed to just 
> 
> return Long.hashCode(doubleToLongBits(value));
> 
> since the local variable is no longer meaningful. Previously, they were required as they were retrieved twice in hash code calculation.
> 
> Same for other usages.

Done!

-------------

PR: https://git.openjdk.java.net/jdk/pull/4309

From github.com+10835776+stsypanov at openjdk.java.net  Wed Jun  2 16:37:49 2021
From: github.com+10835776+stsypanov at openjdk.java.net (=?UTF-8?B?0KHQtdGA0LPQtdC5?= =?UTF-8?B?IA==?= =?UTF-8?B?0KbRi9C/0LDQvdC+0LI=?=)
Date: Wed, 2 Jun 2021 16:37:49 GMT
Subject: RFR: 8268113: Re-use Long.hashCode() where possible [v3]
In-Reply-To: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
References: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
Message-ID: <W6aTlT8rjKY9SNxxH4VMg31R4yLZKtwbgU-pRSyPF60=.56c6035f-6b6e-42bc-9899-c5503f871c66@github.com>

> There is a few JDK classes duplicating the contents of Long.hashCode() for hash code calculation. They should explicitly delegate to Long.hashCode().

?????? ??????? has updated the pull request incrementally with one additional commit since the last revision:

  8268113: Inline local vars where reasonable

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4309/files
  - new: https://git.openjdk.java.net/jdk/pull/4309/files/3f5b431d..df8be00a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=01-02

  Stats: 6 lines in 3 files changed: 0 ins; 3 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4309.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4309/head:pull/4309

PR: https://git.openjdk.java.net/jdk/pull/4309

From vtewari at openjdk.java.net  Wed Jun  2 18:01:29 2021
From: vtewari at openjdk.java.net (Vyom Tewari)
Date: Wed, 2 Jun 2021 18:01:29 GMT
Subject: RFR: 8268113: Re-use Long.hashCode() where possible [v3]
In-Reply-To: <W6aTlT8rjKY9SNxxH4VMg31R4yLZKtwbgU-pRSyPF60=.56c6035f-6b6e-42bc-9899-c5503f871c66@github.com>
References: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
 <W6aTlT8rjKY9SNxxH4VMg31R4yLZKtwbgU-pRSyPF60=.56c6035f-6b6e-42bc-9899-c5503f871c66@github.com>
Message-ID: <pA1IITG3c_dRJXwxfIbrok-8Hz-ItsGs8vJMiVvOe4k=.70df8a69-d42b-4dee-bf54-e2a94482c164@github.com>

On Wed, 2 Jun 2021 16:37:49 GMT, ?????? ??????? <github.com+10835776+stsypanov at openjdk.org> wrote:

>> There is a few JDK classes duplicating the contents of Long.hashCode() for hash code calculation. They should explicitly delegate to Long.hashCode().
>
> ?????? ??????? has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8268113: Inline local vars where reasonable

src/java.base/share/classes/java/util/BitSet.java line 105:

> 103:      * the user knows what he's doing and try harder to preserve it.
> 104:      */
> 105:     private transient boolean sizeIsSticky = false;

This change is OK, but it is not related to "8268113", do you really wants to  do these changes as part of "8268113" ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4309

From github.com+10835776+stsypanov at openjdk.java.net  Wed Jun  2 18:36:28 2021
From: github.com+10835776+stsypanov at openjdk.java.net (=?UTF-8?B?0KHQtdGA0LPQtdC5?= =?UTF-8?B?IA==?= =?UTF-8?B?0KbRi9C/0LDQvdC+0LI=?=)
Date: Wed, 2 Jun 2021 18:36:28 GMT
Subject: RFR: 8268113: Re-use Long.hashCode() where possible [v3]
In-Reply-To: <pA1IITG3c_dRJXwxfIbrok-8Hz-ItsGs8vJMiVvOe4k=.70df8a69-d42b-4dee-bf54-e2a94482c164@github.com>
References: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
 <W6aTlT8rjKY9SNxxH4VMg31R4yLZKtwbgU-pRSyPF60=.56c6035f-6b6e-42bc-9899-c5503f871c66@github.com>
 <pA1IITG3c_dRJXwxfIbrok-8Hz-ItsGs8vJMiVvOe4k=.70df8a69-d42b-4dee-bf54-e2a94482c164@github.com>
Message-ID: <pZinB0MiN1l0lX2hCKSZYWZamvPI6EkYR8zyFr60OZs=.6842ee22-9e6a-49cc-b804-5987bb6af9c2@github.com>

On Wed, 2 Jun 2021 17:58:29 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:

>> ?????? ??????? has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8268113: Inline local vars where reasonable
>
> src/java.base/share/classes/java/util/BitSet.java line 105:
> 
>> 103:      * the user knows what he's doing and try harder to preserve it.
>> 104:      */
>> 105:     private transient boolean sizeIsSticky = false;
> 
> This change is OK, but it is not related to "8268113", do you really wants to  do these changes as part of "8268113" ?

This is just a tiny code clean-up, so I think it's ok to go

-------------

PR: https://git.openjdk.java.net/jdk/pull/4309

From vromero at openjdk.java.net  Thu Jun  3 05:04:53 2021
From: vromero at openjdk.java.net (Vicente Romero)
Date: Thu, 3 Jun 2021 05:04:53 GMT
Subject: RFR: 8267465: remove superfluous preview related annotations and test
 options
Message-ID: <0WEceRgu4UAyTk0nJCtOyA8__hMNfVslEHaFs7n3Hms=.7d6b1d09-a200-436c-a65c-a16bef01b2e8@github.com>

Please review this PR which is removing several superfluous `@SuppressWarnings("preview")` annotations from the compiler code and also removing preview related, but not needed anymore, options from regression tests. Please also review the related CSR which covers the only case that modified a public API.

TIA

-------------

Commit messages:
 - 8267465: remove superfluous @SuppressWarnings(preview) annotations

Changes: https://git.openjdk.java.net/jdk/pull/4330/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4330&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8267465
  Stats: 111 lines in 33 files changed: 0 ins; 86 del; 25 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4330.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4330/head:pull/4330

PR: https://git.openjdk.java.net/jdk/pull/4330

From jlahoda at openjdk.java.net  Thu Jun  3 13:28:50 2021
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Thu, 3 Jun 2021 13:28:50 GMT
Subject: RFR: 8265444: Javadocs: jdk.jshell - small typo
Message-ID: <dHQTP00P8ON6L0P1lbnvB-jH8ZNzlXSzYfBV2eTvuJU=.714eaccd-5002-4738-a9eb-5e717190f89d@github.com>

Fixing typo in jdk.jshell's javadoc.

-------------

Commit messages:
 - 8265444: Javadocs: jdk.jshell - small typo

Changes: https://git.openjdk.java.net/jdk/pull/4336/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4336&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8265444
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4336.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4336/head:pull/4336

PR: https://git.openjdk.java.net/jdk/pull/4336

From sundar at openjdk.java.net  Thu Jun  3 13:58:37 2021
From: sundar at openjdk.java.net (Athijegannathan Sundararajan)
Date: Thu, 3 Jun 2021 13:58:37 GMT
Subject: RFR: 8265444: Javadocs: jdk.jshell - small typo
In-Reply-To: <dHQTP00P8ON6L0P1lbnvB-jH8ZNzlXSzYfBV2eTvuJU=.714eaccd-5002-4738-a9eb-5e717190f89d@github.com>
References: <dHQTP00P8ON6L0P1lbnvB-jH8ZNzlXSzYfBV2eTvuJU=.714eaccd-5002-4738-a9eb-5e717190f89d@github.com>
Message-ID: <opl9zUn8eTBrmunRgGiTVf4yhPI30ef9C7i7_JZfMfo=.36ae21a4-a2ba-4dd3-bbbf-dbf7fbd662b9@github.com>

On Thu, 3 Jun 2021 13:21:39 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> Fixing typo in jdk.jshell's javadoc.

Marked as reviewed by sundar (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4336

From vromero at openjdk.java.net  Thu Jun  3 16:20:09 2021
From: vromero at openjdk.java.net (Vicente Romero)
Date: Thu, 3 Jun 2021 16:20:09 GMT
Subject: RFR: 8267465: remove superfluous preview related annotations and
 test options [v2]
In-Reply-To: <0WEceRgu4UAyTk0nJCtOyA8__hMNfVslEHaFs7n3Hms=.7d6b1d09-a200-436c-a65c-a16bef01b2e8@github.com>
References: <0WEceRgu4UAyTk0nJCtOyA8__hMNfVslEHaFs7n3Hms=.7d6b1d09-a200-436c-a65c-a16bef01b2e8@github.com>
Message-ID: <KQt8OUaHQT5ROQ5xPOTlVsKdEGEnMDiI44ClttRQ3IY=.3425e85b-90cb-45b5-9c70-a07e0d60ff35@github.com>

> Please review this PR which is removing several superfluous `@SuppressWarnings("preview")` annotations from the compiler code and also removing preview related, but not needed anymore, options from regression tests. Please also review the related CSR which covers the only case that modified a public API.
> 
> TIA

Vicente Romero has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into JDK-8267465
 - 8267465: remove superfluous @SuppressWarnings(preview) annotations

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4330/files
  - new: https://git.openjdk.java.net/jdk/pull/4330/files/81162e72..fab606ce

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4330&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4330&range=00-01

  Stats: 34827 lines in 1340 files changed: 25154 ins; 5460 del; 4213 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4330.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4330/head:pull/4330

PR: https://git.openjdk.java.net/jdk/pull/4330

From github.com+10835776+stsypanov at openjdk.java.net  Fri Jun  4 11:54:31 2021
From: github.com+10835776+stsypanov at openjdk.java.net (=?UTF-8?B?0KHQtdGA0LPQtdC5?= =?UTF-8?B?IA==?= =?UTF-8?B?0KbRi9C/0LDQvdC+0LI=?=)
Date: Fri, 4 Jun 2021 11:54:31 GMT
Subject: RFR: 8268113: Re-use Long.hashCode() where possible [v4]
In-Reply-To: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
References: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
Message-ID: <HoB4bIMKlVpWgpjzmfKigCj9peFXbp6GuZxyIZnA2xs=.9d6ba2b9-51fe-4c06-a011-258ced3513d8@github.com>

> There is a few JDK classes duplicating the contents of Long.hashCode() for hash code calculation. They should explicitly delegate to Long.hashCode().

?????? ??????? has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' into 8268113
 - 8268113: Inline local vars where reasonable
 - 8268113: Delegate to Double.hashCode()
 - 8268113: Re-use Long.hashCode() where possible

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4309/files
  - new: https://git.openjdk.java.net/jdk/pull/4309/files/df8be00a..7dc5020e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=02-03

  Stats: 454615 lines in 1482 files changed: 442781 ins; 7489 del; 4345 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4309.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4309/head:pull/4309

PR: https://git.openjdk.java.net/jdk/pull/4309

From jlahoda at openjdk.java.net  Fri Jun  4 12:40:09 2021
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Fri, 4 Jun 2021 12:40:09 GMT
Subject: Integrated: 8265444: Javadocs: jdk.jshell - small typo
In-Reply-To: <dHQTP00P8ON6L0P1lbnvB-jH8ZNzlXSzYfBV2eTvuJU=.714eaccd-5002-4738-a9eb-5e717190f89d@github.com>
References: <dHQTP00P8ON6L0P1lbnvB-jH8ZNzlXSzYfBV2eTvuJU=.714eaccd-5002-4738-a9eb-5e717190f89d@github.com>
Message-ID: <uTU9iFW10S8qhShrjbBhZfmxMKxrxp3cl11BgoUCBHw=.c6b9b568-354b-4069-931a-9aaff39d1033@github.com>

On Thu, 3 Jun 2021 13:21:39 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> Fixing typo in jdk.jshell's javadoc.

This pull request has now been integrated.

Changeset: 40c9e258
Author:    Jan Lahoda <jlahoda at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/40c9e258b58cd1d227d20672a237c8777fd6d45c
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8265444: Javadocs: jdk.jshell - small typo

Reviewed-by: sundar

-------------

PR: https://git.openjdk.java.net/jdk/pull/4336

From jlahoda at openjdk.java.net  Sun Jun  6 16:56:10 2021
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Sun, 6 Jun 2021 16:56:10 GMT
Subject: RFR: 8267465: remove superfluous preview related annotations and
 test options [v2]
In-Reply-To: <KQt8OUaHQT5ROQ5xPOTlVsKdEGEnMDiI44ClttRQ3IY=.3425e85b-90cb-45b5-9c70-a07e0d60ff35@github.com>
References: <0WEceRgu4UAyTk0nJCtOyA8__hMNfVslEHaFs7n3Hms=.7d6b1d09-a200-436c-a65c-a16bef01b2e8@github.com>
 <KQt8OUaHQT5ROQ5xPOTlVsKdEGEnMDiI44ClttRQ3IY=.3425e85b-90cb-45b5-9c70-a07e0d60ff35@github.com>
Message-ID: <CPWtI9nvx9VQSsXnhqT6H6Wq0302O1Z1GVI_ZcZ9ZiE=.2f14655c-9835-4361-91df-f8da73e083ed@github.com>

On Thu, 3 Jun 2021 16:20:09 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Please review this PR which is removing several superfluous `@SuppressWarnings("preview")` annotations from the compiler code and also removing preview related, but not needed anymore, options from regression tests.
>> 
>> TIA
>
> Vicente Romero has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8267465
>  - 8267465: remove superfluous @SuppressWarnings(preview) annotations

Looks OK to me. I would like to ask to wait with integration of this until: https://github.com/openjdk/jdk/pull/3863 is integrated, in case there would be some conflict. Thanks!

-------------

Marked as reviewed by jlahoda (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4330

From vromero at openjdk.java.net  Mon Jun  7 14:01:23 2021
From: vromero at openjdk.java.net (Vicente Romero)
Date: Mon, 7 Jun 2021 14:01:23 GMT
Subject: Integrated: 8267465: remove superfluous preview related annotations
 and test options
In-Reply-To: <0WEceRgu4UAyTk0nJCtOyA8__hMNfVslEHaFs7n3Hms=.7d6b1d09-a200-436c-a65c-a16bef01b2e8@github.com>
References: <0WEceRgu4UAyTk0nJCtOyA8__hMNfVslEHaFs7n3Hms=.7d6b1d09-a200-436c-a65c-a16bef01b2e8@github.com>
Message-ID: <CNV-CHOWVMGzgR-djFHoThsKqSxRmSptzx_B_t2xs3M=.e4f9e91d-c48f-43b9-af17-e20491e5f9b3@github.com>

On Thu, 3 Jun 2021 04:55:39 GMT, Vicente Romero <vromero at openjdk.org> wrote:

> Please review this PR which is removing several superfluous `@SuppressWarnings("preview")` annotations from the compiler code and also removing preview related, but not needed anymore, options from regression tests.
> 
> TIA

This pull request has now been integrated.

Changeset: 4f9d6b7d
Author:    Vicente Romero <vromero at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/4f9d6b7d68312860d3e184a1f33687e1693d7d87
Stats:     111 lines in 33 files changed: 0 ins; 86 del; 25 mod

8267465: remove superfluous preview related annotations and test options

Reviewed-by: jlahoda

-------------

PR: https://git.openjdk.java.net/jdk/pull/4330

From github.com+10835776+stsypanov at openjdk.java.net  Tue Jun  8 07:01:53 2021
From: github.com+10835776+stsypanov at openjdk.java.net (=?UTF-8?B?0KHQtdGA0LPQtdC5?= =?UTF-8?B?IA==?= =?UTF-8?B?0KbRi9C/0LDQvdC+0LI=?=)
Date: Tue, 8 Jun 2021 07:01:53 GMT
Subject: RFR: 8268113: Re-use Long.hashCode() where possible [v5]
In-Reply-To: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
References: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
Message-ID: <uxHLTba6MgAAo8vvClv2MatgKGVBdVku-kKDQ-OThE0=.97f382c1-a48f-4feb-8004-5d28e570dbcf@github.com>

> There is a few JDK classes duplicating the contents of Long.hashCode() for hash code calculation. They should explicitly delegate to Long.hashCode().

?????? ??????? has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'master' into 8268113
 - Merge branch 'master' into 8268113
 - 8268113: Inline local vars where reasonable
 - 8268113: Delegate to Double.hashCode()
 - 8268113: Re-use Long.hashCode() where possible

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4309/files
  - new: https://git.openjdk.java.net/jdk/pull/4309/files/7dc5020e..76af35c6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=03-04

  Stats: 30371 lines in 444 files changed: 25591 ins; 2648 del; 2132 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4309.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4309/head:pull/4309

PR: https://git.openjdk.java.net/jdk/pull/4309

From github.com+10835776+stsypanov at openjdk.java.net  Wed Jun  9 10:32:38 2021
From: github.com+10835776+stsypanov at openjdk.java.net (=?UTF-8?B?0KHQtdGA0LPQtdC5?= =?UTF-8?B?IA==?= =?UTF-8?B?0KbRi9C/0LDQvdC+0LI=?=)
Date: Wed, 9 Jun 2021 10:32:38 GMT
Subject: RFR: 8268113: Re-use Long.hashCode() where possible [v6]
In-Reply-To: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
References: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
Message-ID: <5DP52RlB_Dtcy30JuehAzoGtvEXryh10kqEYoYZvN9k=.1229b4f2-f7f5-4f0b-9d40-947cbe3672f1@github.com>

> There is a few JDK classes duplicating the contents of Long.hashCode() for hash code calculation. They should explicitly delegate to Long.hashCode().

?????? ??????? has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge branch 'master' into 8268113
 - Merge branch 'master' into 8268113
 - Merge branch 'master' into 8268113
 - 8268113: Inline local vars where reasonable
 - 8268113: Delegate to Double.hashCode()
 - 8268113: Re-use Long.hashCode() where possible

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4309/files
  - new: https://git.openjdk.java.net/jdk/pull/4309/files/76af35c6..3a7b5515

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=04-05

  Stats: 5577 lines in 149 files changed: 3466 ins; 1405 del; 706 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4309.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4309/head:pull/4309

PR: https://git.openjdk.java.net/jdk/pull/4309

From github.com+10835776+stsypanov at openjdk.java.net  Thu Jun 10 08:30:43 2021
From: github.com+10835776+stsypanov at openjdk.java.net (=?UTF-8?B?0KHQtdGA0LPQtdC5?= =?UTF-8?B?IA==?= =?UTF-8?B?0KbRi9C/0LDQvdC+0LI=?=)
Date: Thu, 10 Jun 2021 08:30:43 GMT
Subject: RFR: 8268113: Re-use Long.hashCode() where possible [v7]
In-Reply-To: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
References: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
Message-ID: <LjewJ33cY6vu4Nd1t1HCMN-1rjtzl1rxTwVx-NcCBEg=.31de3f9e-5bbe-4743-87e9-978b09d0bcaf@github.com>

> There is a few JDK classes duplicating the contents of Long.hashCode() for hash code calculation. They should explicitly delegate to Long.hashCode().

?????? ??????? has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

 - Merge branch 'master' into 8268113
 - Merge branch 'master' into 8268113
 - Merge branch 'master' into 8268113
 - Merge branch 'master' into 8268113
 - 8268113: Inline local vars where reasonable
 - 8268113: Delegate to Double.hashCode()
 - 8268113: Re-use Long.hashCode() where possible

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4309/files
  - new: https://git.openjdk.java.net/jdk/pull/4309/files/3a7b5515..f1c8cc7b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=05-06

  Stats: 4631 lines in 103 files changed: 3649 ins; 401 del; 581 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4309.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4309/head:pull/4309

PR: https://git.openjdk.java.net/jdk/pull/4309

From github.com+10835776+stsypanov at openjdk.java.net  Wed Jun 30 11:50:52 2021
From: github.com+10835776+stsypanov at openjdk.java.net (=?UTF-8?B?0KHQtdGA0LPQtdC5?= =?UTF-8?B?IA==?= =?UTF-8?B?0KbRi9C/0LDQvdC+0LI=?=)
Date: Wed, 30 Jun 2021 11:50:52 GMT
Subject: RFR: 8268113: Re-use Long.hashCode() where possible [v8]
In-Reply-To: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
References: <7TGw6Vzvw38bqmNOQsuVuGXMe98OqH25nmexLUghcMU=.5e7b347c-0d83-4e54-acc3-9847c08cdc29@github.com>
Message-ID: <F5VdMXD1NkeXdtXQdY-UO7shOqTcf1ewN6Z1cODgHSg=.ab11f8a5-c205-4eea-afaa-d86fe88acf9e@github.com>

> There is a few JDK classes duplicating the contents of Long.hashCode() for hash code calculation. They should explicitly delegate to Long.hashCode().

?????? ??????? has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:

 - Merge branch 'master' into 8268113
 - Merge branch 'master' into 8268113
 - Merge branch 'master' into 8268113
 - Merge branch 'master' into 8268113
 - Merge branch 'master' into 8268113
 - 8268113: Inline local vars where reasonable
 - 8268113: Delegate to Double.hashCode()
 - 8268113: Re-use Long.hashCode() where possible

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4309/files
  - new: https://git.openjdk.java.net/jdk/pull/4309/files/f1c8cc7b..4ec7c829

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=06-07

  Stats: 56052 lines in 1127 files changed: 32406 ins; 19375 del; 4271 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4309.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4309/head:pull/4309

PR: https://git.openjdk.java.net/jdk/pull/4309