RFR: 8267459: Pasting Unicode characters into JShell does not work. [v3]

Vicente Romero vromero at openjdk.java.net
Tue Jun 1 16:43:22 UTC 2021


On Tue, 1 Jun 2021 15:42:32 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> The NonBlockingInputStreamReader.readBuffered method will read some bytes from the InputStream, and then try to convert them to characters. But, the input array may end in the middle of a sequence - e.g. it may end with a part of UTF-8 sequence, which will be only finished when the input is read next time.
>> 
>> The proposed fix is to store the trailing unused bytes into the `bytes` field, which is already used for a similar purpose by the other read method in this class, and use them on the next iteration.
>
> Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Merging master into JDK-8267459
>  - Ensuring the test input is UTF-8, to allow tests pass regardless of configuration.
>  - 8267459: Pasting Unicode characters into JShell does not work.

lgtm!

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4128


More information about the kulla-dev mailing list