RFR: JDK-8263411: Convert jshell tool to use Stream.toList() [v2]

Ian Graves igraves at openjdk.java.net
Tue Mar 23 17:11:41 UTC 2021


On Tue, 23 Mar 2021 16:40:57 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> Ian Graves has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removing most explicit casts and refactoring a Stream use
>
> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java line 1689:
> 
>> 1687:                                 }
>> 1688:                             })
>> 1689:                             .map(e -> (Suggestion) e)
> 
> I guess I'd get rid of the cast here as well. Otherwise looks good!

Ah yes, missed that one. Done!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2979


More information about the kulla-dev mailing list