RFR: JDK-8264222: Use switch expression in jshell where possible [v2]

Tagir F.Valeev tvaleev at openjdk.java.net
Fri Mar 26 23:47:41 UTC 2021


> This change is powered by IntelliJ IDEA quick-fix.
> I also took the liberty to fix C-style arrays in changed files.
> 
> In SourceCodeAnalysisImpl.java:501, I left case PARAMETERIZED_TYPE -> FALSE as a separate switch case, because it had a comment. Better formatting ideas are welcome.
> 
> If you like this, I can provide similar PR in other components as well (e.g. in javac)

Tagir F. Valeev has updated the pull request incrementally with two additional commits since the last revision:

 - resultTypeOf: update comment instead of splitting the case
 - resultTypeOf: split CONSTRUCTOR and INSTANCE_INIT/STATIC_INIT case to position the comments properly

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3210/files
  - new: https://git.openjdk.java.net/jdk/pull/3210/files/4cd18d8e..a6501a96

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3210&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3210&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3210.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3210/head:pull/3210

PR: https://git.openjdk.java.net/jdk/pull/3210


More information about the kulla-dev mailing list