RFR: 8247403: JShell: No custom input (e.g. from GUI) possible with JavaShellToolBuilder [v3]

Jan Lahoda jlahoda at openjdk.java.net
Mon May 24 08:20:44 UTC 2021


> Basically, JShell's ConsoleIOContext always uses the JLine's default terminal, which uses System.in, or equivalent, for input. But, if the JShell tool has been created using JavaShellToolBuilder, a different input might have been provided. The proposed solution is to use a different JLine's terminal in this case, based on the provided input.

Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:

  Adding note about the default behavior, as suggested.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2509/files
  - new: https://git.openjdk.java.net/jdk/pull/2509/files/d7eacd6a..6ee9855c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2509&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2509&range=01-02

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2509.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2509/head:pull/2509

PR: https://git.openjdk.java.net/jdk/pull/2509


More information about the kulla-dev mailing list