RFR: 8272358: Some tests may fail when executed with other locales than the US
Sergey Bylokhov
serb at openjdk.java.net
Fri Oct 1 01:39:31 UTC 2021
On Sat, 25 Sep 2021 12:10:16 GMT, Jie Fu <jiefu at openjdk.org> wrote:
> Shall we also fix ToolBasicTest.java and ToolSimpleTest.java just as what is done for LambdaTranslationTest1.java and LambdaTranslationTest2.java? If so, the 4 tests would be also fixed on our MacOS platforms.
I do not want to add a global locale parameter to the places which may trigger loading of the different translations.
Probably we missed the bugs like this(not exactly but similar to) https://bugs.openjdk.java.net/browse/JDK-8274544 because everybody passes US locale to the tests. Probably we missed some other bugs as well.
> And do you test the fix on Linux? Thanks.
On Linux I have checked "JA" and "RU" locales, nothing changed for "JA" it uses the same float format as the US, so the LambdaTranslationTest1/LambdaTranslationTest2 passed before/after the fix and the ToolBasicTest/ToolSimpleTest failed in the "JA" locale, one of the subtests compare the expected output saved for US locale with the real output of the test.
For RU locale the tests fail before the fix and passed after because there is no specific translation so the US text is used, and this PR fixes the problem in the float format.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5098
More information about the kulla-dev
mailing list