RFR: 8274148: can jshell show deprecated classes, methods and fields as strikethrough text? [v2]

Vicente Romero vromero at openjdk.java.net
Tue Feb 1 20:25:11 UTC 2022


On Tue, 1 Feb 2022 15:34:58 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> This adds a limited highlighting for JShell. It underlines keywords, highlights declarations and shows deprecated elements inversed (on Windows) or with fainted italic text (on other platforms).
>> 
>> For example, on Windows:
>> ![jshell-coloring-other](https://user-images.githubusercontent.com/51319204/149968951-df00b3a0-0463-4a9a-9d48-49925030409e.png)
>> 
>> On other platforms:
>> ![screenshot-snippet-nonwin](https://user-images.githubusercontent.com/51319204/152007244-0b95cbda-6c85-4079-b0ee-23f7141e9034.png)
>
> Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Cleanup.
>  - Merge branch 'master' into JDK-8274148
>  - 8274148: can jshell show deprecated classes, methods and fields as strikethrough text?

complex change, looks sensible to me

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7130


More information about the kulla-dev mailing list