From iveresov at openjdk.org Sat Jul 2 01:13:01 2022 From: iveresov at openjdk.org (Igor Veresov) Date: Sat, 2 Jul 2022 01:13:01 GMT Subject: [jdk19] RFR: 8245268: -Xcomp is missing from java launcher documentation Message-ID: Updated man pages from markdown sources. ------------- Commit messages: - Update man pages Changes: https://git.openjdk.org/jdk19/pull/103/files Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=103&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8245268 Stats: 495 lines in 8 files changed: 437 ins; 16 del; 42 mod Patch: https://git.openjdk.org/jdk19/pull/103.diff Fetch: git fetch https://git.openjdk.org/jdk19 pull/103/head:pull/103 PR: https://git.openjdk.org/jdk19/pull/103 From kvn at openjdk.org Sat Jul 2 02:15:46 2022 From: kvn at openjdk.org (Vladimir Kozlov) Date: Sat, 2 Jul 2022 02:15:46 GMT Subject: [jdk19] RFR: 8245268: -Xcomp is missing from java launcher documentation In-Reply-To: References: Message-ID: On Sat, 2 Jul 2022 01:04:19 GMT, Igor Veresov wrote: > Updated man pages from markdown sources. I am not sure some words changes are correct? May be we should cleanup and update all these man pages as separate issue. And apply only `-Xcomp` changes. @iklam you recently pushed changes https://github.com/openjdk/jdk/pull/9024 which included only CDS related update. Did you discuss this issue during your changes review? src/java.base/share/man/java.1 line 3682: > 3680: .RS > 3681: .PP > 3682: The following examples show how to set the mimimum size of allocated `mimimum`? src/java.base/share/man/java.1 line 5367: > 5365: \f[CB];\f[R] > 5366: .PP > 5367: (The names "static" and "dyanmic" are used for historical reasons. `dyanmic` ? ------------- PR: https://git.openjdk.org/jdk19/pull/103 From iveresov at openjdk.org Sat Jul 2 02:48:47 2022 From: iveresov at openjdk.org (Igor Veresov) Date: Sat, 2 Jul 2022 02:48:47 GMT Subject: [jdk19] RFR: 8245268: -Xcomp is missing from java launcher documentation In-Reply-To: References: Message-ID: On Sat, 2 Jul 2022 02:12:43 GMT, Vladimir Kozlov wrote: > I am not sure some words changes are correct? > > May be we should cleanup and update all these man pages as separate issue. And apply only `-Xcomp` changes. > Then I'd have to manually craft a patch instead of actually generating them. It seems like it's all been out of sync for a long time. ------------- PR: https://git.openjdk.org/jdk19/pull/103 From iveresov at openjdk.org Sat Jul 2 02:48:48 2022 From: iveresov at openjdk.org (Igor Veresov) Date: Sat, 2 Jul 2022 02:48:48 GMT Subject: [jdk19] RFR: 8245268: -Xcomp is missing from java launcher documentation In-Reply-To: References: Message-ID: <3n97bQQ4ib9ogDH_nIP-ivvywhufhTnQR49_SjlHmF4=.f0e23271-724e-404f-80fa-304ba27258a9@github.com> On Sat, 2 Jul 2022 01:04:19 GMT, Igor Veresov wrote: > Updated man pages from markdown sources. There is also a question of which version is actually correct. Yeah, may be I should manually craft a patch just for the Xcomp part. ------------- PR: https://git.openjdk.org/jdk19/pull/103 From iklam at openjdk.org Sat Jul 2 03:32:26 2022 From: iklam at openjdk.org (Ioi Lam) Date: Sat, 2 Jul 2022 03:32:26 GMT Subject: [jdk19] RFR: 8245268: -Xcomp is missing from java launcher documentation In-Reply-To: <3n97bQQ4ib9ogDH_nIP-ivvywhufhTnQR49_SjlHmF4=.f0e23271-724e-404f-80fa-304ba27258a9@github.com> References: <3n97bQQ4ib9ogDH_nIP-ivvywhufhTnQR49_SjlHmF4=.f0e23271-724e-404f-80fa-304ba27258a9@github.com> Message-ID: On Sat, 2 Jul 2022 02:45:43 GMT, Igor Veresov wrote: > There is also a question of which version is actually correct. Yeah, may be I should manually craft a patch just for the Xcomp part. @veresov please see the closed issue https://bugs.openjdk.org/browse/JDK-8287821 @vnkozlov when I did https://github.com/openjdk/jdk/pull/9024, I generated `java.1` from the `java.md` file. I then use the `meld` program on Linux to revert all changes in the `java.1` file that were unrelated to my changes in `java.md`. Yes, it was a pain. ------------- PR: https://git.openjdk.org/jdk19/pull/103 From iveresov at openjdk.org Sat Jul 2 03:48:27 2022 From: iveresov at openjdk.org (Igor Veresov) Date: Sat, 2 Jul 2022 03:48:27 GMT Subject: [jdk19] RFR: 8245268: -Xcomp is missing from java launcher documentation [v2] In-Reply-To: References: Message-ID: > Updated man pages from markdown sources. Igor Veresov has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Update java manpage ------------- Changes: - all: https://git.openjdk.org/jdk19/pull/103/files - new: https://git.openjdk.org/jdk19/pull/103/files/37da94df..f3526e7b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk19&pr=103&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk19&pr=103&range=00-01 Stats: 485 lines in 8 files changed: 12 ins; 427 del; 46 mod Patch: https://git.openjdk.org/jdk19/pull/103.diff Fetch: git fetch https://git.openjdk.org/jdk19 pull/103/head:pull/103 PR: https://git.openjdk.org/jdk19/pull/103 From iveresov at openjdk.org Sat Jul 2 03:48:27 2022 From: iveresov at openjdk.org (Igor Veresov) Date: Sat, 2 Jul 2022 03:48:27 GMT Subject: [jdk19] RFR: 8245268: -Xcomp is missing from java launcher documentation In-Reply-To: References: Message-ID: On Sat, 2 Jul 2022 01:04:19 GMT, Igor Veresov wrote: > Updated man pages from markdown sources. Ok, I just hacked a patch file. ------------- PR: https://git.openjdk.org/jdk19/pull/103 From aturbanov at openjdk.org Wed Jul 6 08:06:52 2022 From: aturbanov at openjdk.org (Andrey Turbanov) Date: Wed, 6 Jul 2022 08:06:52 GMT Subject: RFR: 8289804: Remove redundant stream() call before forEach in jdk.jshell Message-ID: There are several places in the jdk.jshell implementation that use stream().forEach(...), these can be cleaned up. ------------- Commit messages: - [PATCH] Remove redundant stream() call before forEach in jdk.jshell Changes: https://git.openjdk.org/jdk/pull/9370/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9370&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289804 Stats: 25 lines in 3 files changed: 0 ins; 2 del; 23 mod Patch: https://git.openjdk.org/jdk/pull/9370.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9370/head:pull/9370 PR: https://git.openjdk.org/jdk/pull/9370 From psandoz at openjdk.org Thu Jul 7 20:30:49 2022 From: psandoz at openjdk.org (Paul Sandoz) Date: Thu, 7 Jul 2022 20:30:49 GMT Subject: RFR: 8289804: Remove redundant stream() call before forEach in jdk.jshell In-Reply-To: References: Message-ID: <6gZpT_jPPo0OBvsWTCcuEc_2yfFmy5Upc583O_X1B14=.8ffeca24-f94d-4a16-963c-c395adc4ea34@github.com> On Mon, 4 Jul 2022 20:53:35 GMT, Andrey Turbanov wrote: > There are several places in the jdk.jshell implementation that use stream().forEach(...), these can be cleaned up. Marked as reviewed by psandoz (Reviewer). ------------- PR: https://git.openjdk.org/jdk/pull/9370 From jlahoda at openjdk.org Mon Jul 18 14:42:04 2022 From: jlahoda at openjdk.org (Jan Lahoda) Date: Mon, 18 Jul 2022 14:42:04 GMT Subject: RFR: JDK-8282434: Leading combining diacritic character in string renders incorrectly Message-ID: There's a group of characters, that add diacritics to the preceding character. JShell wraps String values into double quotes, and so when such a combining character is the first character of a string, there is a double quote followed by the diacritics. On some terminals, it may print the diacritics merged with the double quote. Sadly, the behavior seems to differ much between terminals, so the proposal here is to use Unicode escape sequences for these characters when they would immediately follow the opening double quote. Sample output: $1 ==> "\u032Ea" ------------- Commit messages: - JDK-8282434: Leading combining diacritic character in string renders incorrectly Changes: https://git.openjdk.org/jdk/pull/9540/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9540&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282434 Stats: 55 lines in 2 files changed: 36 ins; 0 del; 19 mod Patch: https://git.openjdk.org/jdk/pull/9540.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9540/head:pull/9540 PR: https://git.openjdk.org/jdk/pull/9540 From aturbanov at openjdk.org Tue Jul 19 11:35:02 2022 From: aturbanov at openjdk.org (Andrey Turbanov) Date: Tue, 19 Jul 2022 11:35:02 GMT Subject: Integrated: 8289804: Remove redundant stream() call before forEach in jdk.jshell In-Reply-To: References: Message-ID: On Mon, 4 Jul 2022 20:53:35 GMT, Andrey Turbanov wrote: > There are several places in the jdk.jshell implementation that use stream().forEach(...), these can be cleaned up. This pull request has now been integrated. Changeset: 2ff22087 Author: Andrey Turbanov URL: https://git.openjdk.org/jdk/commit/2ff22087f209f9bd8e82d1c2a90c44cafd9ffef0 Stats: 25 lines in 3 files changed: 0 ins; 2 del; 23 mod 8289804: Remove redundant stream() call before forEach in jdk.jshell Reviewed-by: psandoz ------------- PR: https://git.openjdk.org/jdk/pull/9370 From dcubed at openjdk.org Wed Jul 20 22:44:07 2022 From: dcubed at openjdk.org (Daniel D. Daugherty) Date: Wed, 20 Jul 2022 22:44:07 GMT Subject: RFR: Merge jdk19 Message-ID: Merge jdk19 -> jdk20. ------------- Commit messages: - Merge - 8290625: Test jdk/javadoc/tool/CheckManPageOptions.java after manpage update - 8278274: Update nroff pages in JDK 19 before RC - 8287916: Address the inconsistency between the constant array and pool size - 8285407: Improve Xalan supports - 8282676: Improve subject handling - 8284370: Improve zlib usage - 8283190: Improve MIDI processing - 8281866: Enhance MethodHandle invocations - 8281859: Improve class compilation - ... and 3 more: https://git.openjdk.org/jdk/compare/b1817a30...aaca8b9d The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk/pull/9578/files Stats: 504 lines in 28 files changed: 428 ins; 16 del; 60 mod Patch: https://git.openjdk.org/jdk/pull/9578.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9578/head:pull/9578 PR: https://git.openjdk.org/jdk/pull/9578 From dcubed at openjdk.org Wed Jul 20 22:59:25 2022 From: dcubed at openjdk.org (Daniel D. Daugherty) Date: Wed, 20 Jul 2022 22:59:25 GMT Subject: RFR: Merge jdk19 In-Reply-To: References: Message-ID: On Wed, 20 Jul 2022 22:20:31 GMT, Daniel D. Daugherty wrote: > Merge jdk19 -> jdk20. Mach5 Tier1 passed. ------------- PR: https://git.openjdk.org/jdk/pull/9578 From dcubed at openjdk.org Wed Jul 20 22:59:26 2022 From: dcubed at openjdk.org (Daniel D. Daugherty) Date: Wed, 20 Jul 2022 22:59:26 GMT Subject: Integrated: Merge jdk19 In-Reply-To: References: Message-ID: On Wed, 20 Jul 2022 22:20:31 GMT, Daniel D. Daugherty wrote: > Merge jdk19 -> jdk20. This pull request has now been integrated. Changeset: 9c19d89c Author: Daniel D. Daugherty URL: https://git.openjdk.org/jdk/commit/9c19d89c9c564e436732c5f7851f4960fb5d783c Stats: 504 lines in 28 files changed: 428 ins; 16 del; 60 mod Merge ------------- PR: https://git.openjdk.org/jdk/pull/9578 From dholmes at openjdk.org Thu Jul 21 00:43:38 2022 From: dholmes at openjdk.org (David Holmes) Date: Thu, 21 Jul 2022 00:43:38 GMT Subject: RFR: 8290489: Initial nroff manpage generation for JDK 20 Message-ID: The version will be 20-ea and the copyright year 2023 (for March 2023 release date). Thanks. ------------- Commit messages: - 8290489: Initial nroff manpage generation for JDK 20 Changes: https://git.openjdk.org/jdk/pull/9581/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9581&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290489 Stats: 28 lines in 28 files changed: 0 ins; 0 del; 28 mod Patch: https://git.openjdk.org/jdk/pull/9581.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9581/head:pull/9581 PR: https://git.openjdk.org/jdk/pull/9581 From dcubed at openjdk.org Thu Jul 21 01:07:02 2022 From: dcubed at openjdk.org (Daniel D. Daugherty) Date: Thu, 21 Jul 2022 01:07:02 GMT Subject: RFR: 8290489: Initial nroff manpage generation for JDK 20 In-Reply-To: References: Message-ID: <2chBf83EGB9f7D67rYVKNXRnOOWKUa0hLm7XNhCa5QU=.9bca77c8-36e8-4763-af9b-3d8c1df238c1@github.com> On Thu, 21 Jul 2022 00:34:53 GMT, David Holmes wrote: > The version will be 20-ea and the copyright year 2023 (for March 2023 release date). > > Thanks. Thumbs up. This is a trivial change. ------------- Marked as reviewed by dcubed (Reviewer). PR: https://git.openjdk.org/jdk/pull/9581 From dholmes at openjdk.org Thu Jul 21 05:49:57 2022 From: dholmes at openjdk.org (David Holmes) Date: Thu, 21 Jul 2022 05:49:57 GMT Subject: RFR: 8290489: Initial nroff manpage generation for JDK 20 In-Reply-To: <2chBf83EGB9f7D67rYVKNXRnOOWKUa0hLm7XNhCa5QU=.9bca77c8-36e8-4763-af9b-3d8c1df238c1@github.com> References: <2chBf83EGB9f7D67rYVKNXRnOOWKUa0hLm7XNhCa5QU=.9bca77c8-36e8-4763-af9b-3d8c1df238c1@github.com> Message-ID: On Thu, 21 Jul 2022 01:03:46 GMT, Daniel D. Daugherty wrote: >> The version will be 20-ea and the copyright year 2023 (for March 2023 release date). >> >> Thanks. > > Thumbs up. This is a trivial change. Thanks @dcubed-ojdk ! ------------- PR: https://git.openjdk.org/jdk/pull/9581 From dholmes at openjdk.org Fri Jul 22 04:45:03 2022 From: dholmes at openjdk.org (David Holmes) Date: Fri, 22 Jul 2022 04:45:03 GMT Subject: Integrated: 8290489: Initial nroff manpage generation for JDK 20 In-Reply-To: References: Message-ID: <2vnXOAQlpH9CGjFVkGkL4pWyCPxneNmWrxV8V6j5b_w=.c951b25d-e0cd-4902-ad79-200ca4238f91@github.com> On Thu, 21 Jul 2022 00:34:53 GMT, David Holmes wrote: > The version will be 20-ea and the copyright year 2023 (for March 2023 release date). > > Thanks. This pull request has now been integrated. Changeset: e9f97b2e Author: David Holmes URL: https://git.openjdk.org/jdk/commit/e9f97b2e8cf301ba6b69101e5efc5c71d26bc87b Stats: 28 lines in 28 files changed: 0 ins; 0 del; 28 mod 8290489: Initial nroff manpage generation for JDK 20 Reviewed-by: dcubed ------------- PR: https://git.openjdk.org/jdk/pull/9581