From shade at openjdk.java.net  Thu Jun  2 14:59:46 2022
From: shade at openjdk.java.net (Aleksey Shipilev)
Date: Thu, 2 Jun 2022 14:59:46 GMT
Subject: RFR: 8287732: jdk/jshell/ToolEnablePreviewTest.java fails on x86_32
 after JDK-8287496
Message-ID: <-J2L9ETLN2yM9Edov2A6mJQ6QO5sbSwWsstzbFlxgEE=.185ac61a-8b81-4cdd-b560-84d1a129ab27@github.com>

Manifests right now in x86_32 tier1 tests and GHA. The test tries to launch the tool via JDI/JVMTI, which does not fully work without continuations after [JDK-8287496](https://bugs.openjdk.java.net/browse/JDK-8287496):


FailOverExecutionControlProvider: FAILED: 1:jdi:launch(true) --
  Exception: java.lang.InternalError: Failed remote launch: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679 @ com.sun.jdi.CommandLineLaunch (defaults: home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=, main=, suspend=true, quote=", vmexec=java, enumeratevthreads=n) -- {home=home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=options=--enable-preview, main=main=jdk.jshell.execution.RemoteExecutionControl 43679, suspend=suspend=true, quote=quote=", vmexec=vmexec=java, enumeratevthreads=enumeratevthreads=n}
                  jdk.jshell/jdk.jshell.execution.JdiInitiator.reportLaunchFail(JdiInitiator.java:300)
                  jdk.jshell/jdk.jshell.execution.JdiInitiator.launchTarget(JdiInitiator.java:141)
                  jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:110)
                  jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
                  jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
      cause: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679
FailOverExecutionControlProvider: FAILED: 2:jdi --
  Exception: java.lang.IllegalArgumentException: ERROR: JDWP unable to access JVMTI Version 1 (0x30010000), is your J2SE a 1.5 or newer version? JNIEnv's GetEnv() returned -3

                  jdk.jshell/jdk.jshell.execution.JdiInitiator.listenTarget(JdiInitiator.java:201)
                  jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:111)
                  jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
                  jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
                  jdk.jshell/jdk.jshell.spi.ExecutionControl.generate(ExecutionControl.java:179)


I think test needs `@requires vm.continuations` as well.

Additional testing:
 - [x] Linux x86_32 `fastdebug`, affected test now skipped
 - [x] Linux x86_64 `fastdebug`, affected test still runs

-------------

Commit messages:
 - Fix

Changes: https://git.openjdk.java.net/jdk/pull/8995/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8995&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8287732
  Stats: 15 lines in 2 files changed: 15 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8995.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8995/head:pull/8995

PR: https://git.openjdk.java.net/jdk/pull/8995

From alanb at openjdk.java.net  Thu Jun  2 19:01:33 2022
From: alanb at openjdk.java.net (Alan Bateman)
Date: Thu, 2 Jun 2022 19:01:33 GMT
Subject: RFR: 8287732: jdk/jshell/ToolEnablePreviewTest.java fails on
 x86_32 after JDK-8287496
In-Reply-To: <-J2L9ETLN2yM9Edov2A6mJQ6QO5sbSwWsstzbFlxgEE=.185ac61a-8b81-4cdd-b560-84d1a129ab27@github.com>
References: <-J2L9ETLN2yM9Edov2A6mJQ6QO5sbSwWsstzbFlxgEE=.185ac61a-8b81-4cdd-b560-84d1a129ab27@github.com>
Message-ID: <uu5RNt-xlkwLjqCy0jpSdSEAMi9GwHDpkne2xOsYfD0=.bc945402-efad-4b26-8809-97d774ec6190@github.com>

On Thu, 2 Jun 2022 14:50:22 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Manifests right now in x86_32 tier1 tests and GHA. The test tries to launch the tool via JDI/JVMTI, which does not fully work without continuations after [JDK-8287496](https://bugs.openjdk.java.net/browse/JDK-8287496):
> 
> 
> FailOverExecutionControlProvider: FAILED: 1:jdi:launch(true) --
>   Exception: java.lang.InternalError: Failed remote launch: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679 @ com.sun.jdi.CommandLineLaunch (defaults: home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=, main=, suspend=true, quote=", vmexec=java, enumeratevthreads=n) -- {home=home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=options=--enable-preview, main=main=jdk.jshell.execution.RemoteExecutionControl 43679, suspend=suspend=true, quote=quote=", vmexec=vmexec=java, enumeratevthreads=enumeratevthreads=n}
>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.reportLaunchFail(JdiInitiator.java:300)
>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.launchTarget(JdiInitiator.java:141)
>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:110)
>                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
>                   jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
>       cause: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679
> FailOverExecutionControlProvider: FAILED: 2:jdi --
>   Exception: java.lang.IllegalArgumentException: ERROR: JDWP unable to access JVMTI Version 1 (0x30010000), is your J2SE a 1.5 or newer version? JNIEnv's GetEnv() returned -3
> 
>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.listenTarget(JdiInitiator.java:201)
>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:111)
>                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
>                   jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
>                   jdk.jshell/jdk.jshell.spi.ExecutionControl.generate(ExecutionControl.java:179)
> 
> 
> I think test needs `@requires vm.continuations` as well.
> 
> Additional testing:
>  - [x] Linux x86_32 `fastdebug`, affected test now skipped
>  - [x] Linux x86_64 `fastdebug`, affected test still runs

test/langtools/jdk/jshell/ToolEnablePreviewTest.java line 28:

> 26:  * @bug 8199193
> 27:  * @summary Tests for the --enable-preview option
> 28:  * @requires vm.continuations

This seems to be only jshell tests that uses --enable-preview so I think this is okay, just need to update the copyright year.

The update to TEST.ROOT looks okay, just surprised that tests in the langtools tree have never needed to specify requires properties before now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8995

From shade at openjdk.java.net  Fri Jun  3 05:54:21 2022
From: shade at openjdk.java.net (Aleksey Shipilev)
Date: Fri, 3 Jun 2022 05:54:21 GMT
Subject: RFR: 8287732: jdk/jshell/ToolEnablePreviewTest.java fails on
 x86_32 after JDK-8287496 [v2]
In-Reply-To: <-J2L9ETLN2yM9Edov2A6mJQ6QO5sbSwWsstzbFlxgEE=.185ac61a-8b81-4cdd-b560-84d1a129ab27@github.com>
References: <-J2L9ETLN2yM9Edov2A6mJQ6QO5sbSwWsstzbFlxgEE=.185ac61a-8b81-4cdd-b560-84d1a129ab27@github.com>
Message-ID: <fRMvu8VpjEsCG4p8psL9cP9PWAYIydlxqX_QjJj3344=.a9bc4d3e-d669-4c6c-a18b-842ca7dbff00@github.com>

> Manifests right now in x86_32 tier1 tests and GHA. The test tries to launch the tool via JDI/JVMTI, which does not fully work without continuations after [JDK-8287496](https://bugs.openjdk.java.net/browse/JDK-8287496):
> 
> 
> FailOverExecutionControlProvider: FAILED: 1:jdi:launch(true) --
>   Exception: java.lang.InternalError: Failed remote launch: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679 @ com.sun.jdi.CommandLineLaunch (defaults: home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=, main=, suspend=true, quote=", vmexec=java, enumeratevthreads=n) -- {home=home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=options=--enable-preview, main=main=jdk.jshell.execution.RemoteExecutionControl 43679, suspend=suspend=true, quote=quote=", vmexec=vmexec=java, enumeratevthreads=enumeratevthreads=n}
>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.reportLaunchFail(JdiInitiator.java:300)
>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.launchTarget(JdiInitiator.java:141)
>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:110)
>                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
>                   jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
>       cause: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679
> FailOverExecutionControlProvider: FAILED: 2:jdi --
>   Exception: java.lang.IllegalArgumentException: ERROR: JDWP unable to access JVMTI Version 1 (0x30010000), is your J2SE a 1.5 or newer version? JNIEnv's GetEnv() returned -3
> 
>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.listenTarget(JdiInitiator.java:201)
>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:111)
>                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
>                   jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
>                   jdk.jshell/jdk.jshell.spi.ExecutionControl.generate(ExecutionControl.java:179)
> 
> 
> I think test needs `@requires vm.continuations` as well.
> 
> Additional testing:
>  - [x] Linux x86_32 `fastdebug`, affected test now skipped
>  - [x] Linux x86_64 `fastdebug`, affected test still runs

Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Copyright updates
 - Merge branch 'master' into JDK-8287732-loom-tool-enable-preview
 - Fix

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8995/files
  - new: https://git.openjdk.java.net/jdk/pull/8995/files/71b54a5b..de2b8036

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8995&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8995&range=00-01

  Stats: 294 lines in 88 files changed: 165 ins; 84 del; 45 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8995.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8995/head:pull/8995

PR: https://git.openjdk.java.net/jdk/pull/8995

From shade at openjdk.java.net  Fri Jun  3 05:54:22 2022
From: shade at openjdk.java.net (Aleksey Shipilev)
Date: Fri, 3 Jun 2022 05:54:22 GMT
Subject: RFR: 8287732: jdk/jshell/ToolEnablePreviewTest.java fails on
 x86_32 after JDK-8287496 [v2]
In-Reply-To: <uu5RNt-xlkwLjqCy0jpSdSEAMi9GwHDpkne2xOsYfD0=.bc945402-efad-4b26-8809-97d774ec6190@github.com>
References: <-J2L9ETLN2yM9Edov2A6mJQ6QO5sbSwWsstzbFlxgEE=.185ac61a-8b81-4cdd-b560-84d1a129ab27@github.com>
 <uu5RNt-xlkwLjqCy0jpSdSEAMi9GwHDpkne2xOsYfD0=.bc945402-efad-4b26-8809-97d774ec6190@github.com>
Message-ID: <jHVcPZ8GNmRlteH_oxDpmti_p3OJbCzV_eb7XbSz8rw=.ecf96fa0-f6a0-4069-a424-ea59162d666f@github.com>

On Thu, 2 Jun 2022 18:58:24 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Copyright updates
>>  - Merge branch 'master' into JDK-8287732-loom-tool-enable-preview
>>  - Fix
>
> test/langtools/jdk/jshell/ToolEnablePreviewTest.java line 28:
> 
>> 26:  * @bug 8199193
>> 27:  * @summary Tests for the --enable-preview option
>> 28:  * @requires vm.continuations
> 
> This seems to be only jshell teststhat uses --enable-preview so I think this is okay, just need to update the copyright year.
> 
> The update to TEST.ROOT looks okay, just surprised that tests in the langtools tree have never needed to specify requires properties before now.

Updated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8995

From alanb at openjdk.java.net  Fri Jun  3 06:16:24 2022
From: alanb at openjdk.java.net (Alan Bateman)
Date: Fri, 3 Jun 2022 06:16:24 GMT
Subject: RFR: 8287732: jdk/jshell/ToolEnablePreviewTest.java fails on
 x86_32 after JDK-8287496 [v2]
In-Reply-To: <fRMvu8VpjEsCG4p8psL9cP9PWAYIydlxqX_QjJj3344=.a9bc4d3e-d669-4c6c-a18b-842ca7dbff00@github.com>
References: <-J2L9ETLN2yM9Edov2A6mJQ6QO5sbSwWsstzbFlxgEE=.185ac61a-8b81-4cdd-b560-84d1a129ab27@github.com>
 <fRMvu8VpjEsCG4p8psL9cP9PWAYIydlxqX_QjJj3344=.a9bc4d3e-d669-4c6c-a18b-842ca7dbff00@github.com>
Message-ID: <I0Nkg8ZgNqPmNKhq0u33lKZA4pMjrzxOVM7s6osR0Ys=.22a22782-8a37-4390-91d5-6ec682d3be2f@github.com>

On Fri, 3 Jun 2022 05:54:21 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Manifests right now in x86_32 tier1 tests and GHA. The test tries to launch the tool via JDI/JVMTI, which does not fully work without continuations after [JDK-8287496](https://bugs.openjdk.java.net/browse/JDK-8287496):
>> 
>> 
>> FailOverExecutionControlProvider: FAILED: 1:jdi:launch(true) --
>>   Exception: java.lang.InternalError: Failed remote launch: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679 @ com.sun.jdi.CommandLineLaunch (defaults: home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=, main=, suspend=true, quote=", vmexec=java, enumeratevthreads=n) -- {home=home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=options=--enable-preview, main=main=jdk.jshell.execution.RemoteExecutionControl 43679, suspend=suspend=true, quote=quote=", vmexec=vmexec=java, enumeratevthreads=enumeratevthreads=n}
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.reportLaunchFail(JdiInitiator.java:300)
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.launchTarget(JdiInitiator.java:141)
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:110)
>>                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
>>                   jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
>>       cause: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679
>> FailOverExecutionControlProvider: FAILED: 2:jdi --
>>   Exception: java.lang.IllegalArgumentException: ERROR: JDWP unable to access JVMTI Version 1 (0x30010000), is your J2SE a 1.5 or newer version? JNIEnv's GetEnv() returned -3
>> 
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.listenTarget(JdiInitiator.java:201)
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:111)
>>                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
>>                   jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
>>                   jdk.jshell/jdk.jshell.spi.ExecutionControl.generate(ExecutionControl.java:179)
>> 
>> 
>> I think test needs `@requires vm.continuations` as well.
>> 
>> Additional testing:
>>  - [x] Linux x86_32 `fastdebug`, affected test now skipped
>>  - [x] Linux x86_64 `fastdebug`, affected test still runs
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Copyright updates
>  - Merge branch 'master' into JDK-8287732-loom-tool-enable-preview
>  - Fix

Marked as reviewed by alanb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8995

From jlahoda at openjdk.java.net  Fri Jun  3 10:22:15 2022
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Fri, 3 Jun 2022 10:22:15 GMT
Subject: RFR: 8241356: Use a more reliable way to encode Symbol flags [v3]
In-Reply-To: <aYRbIKEZmDlWfryC0sW1BSVtzJyIR7BRZS2Vs0XfGaY=.de31b4a7-d2df-489a-9816-08deab0cddef@github.com>
References: <aYRbIKEZmDlWfryC0sW1BSVtzJyIR7BRZS2Vs0XfGaY=.de31b4a7-d2df-489a-9816-08deab0cddef@github.com>
Message-ID: <76agXbVWiCtcXkp1a8cD9UoTEXj1pSdWWiqVVXIs2R0=.6301c93e-de95-451f-81cc-c9988de50469@github.com>

> [This is a GitHub copy of: https://mail.openjdk.java.net/pipermail/compiler-dev/2020-March/014389.html ]
> 
> Currently, (com.sun.tools.javac.code.)Symbol/s have a long field "flags_field", which holds various one-bit information ("Flags") about the given Symbol.
> 
> We currently have around 64 such Flags, which means we are out of bits in the long field, and adding new flags is not easy.
> 
> We could change the "flags_field" to be a Set over enums, but this would increase the memory footprint notably, and would also slow-down access to flags. Currently, flags operations in javac are very fast and very common, so this is probably too much burden. There are also flags to which we need to access as bit masks, e.g. due to writing to classfile.
> 
> My proposal here is to use an intermediate solution, until we find a better solution, or until a better solution is possible (like due to Valhalla). The idea is as follows:
> -the current long-based Flags are split into 4 groups:
> --"flat" Flags, long based, work exactly as before.
> --enum-based TypeSymbolFlags, MethodSymbolFlags and VarSymbolFlags, which are only applicable to TypeSymbols, MethodSymbols and VarSymbols, respectively, and are checked using methods like Symbol.isFlagSet and set/clear using methods Symbol.setFlag and Symbol.clearFlag. So these flags are mostly encapsulated, even though physically they are currently stored in the flags_field as well.
> 
> There are ~~37~~ 40 "flat" flags and ~~16~~ 17 TypeSymbolFlags (methods and vars have less flags), 57 in total. This gives us at least 7 new flags before we run out of long bits in flags_field again - but even if we do, there are several easy mitigation strategies we could use, like:
> -create a new int/long field on TypeSymbols for the TypeSymbolFlags (probably preferable)
> -split TypeSymbolFlags into Class/Package/MethodSymbolFlags
> 
> The positives of this solution include:
> -safe(r) access to the flags - the access to the extra/symbol-kind-specific flags is mostly encapsulated, and hence mostly safe
> -improves the abstractions at least for some flags
> -reasonably complex patch (attempts to encapsulate all the flags were troublesome in previous experiments)
> -the performances appears to be acceptable.
> 
> The negative that I see is that the code includes several incompatible types of flags now. These cannot be easily confused by accident (as the type system will complain), but still we need to be aware of them when writing code.
> 
> Some more alternatives:
> -add a new field to Symbol, like long extraFlags, and continue with bit masks as we did so far using this new field. The drawback is that it is more error prone (it would be difficult to ensure only the new/extra flags would be stored and read from extraFlags).
> -have a new field, and "flat" and non-"flat" enum-based encapsulated Flags, but don't separate Type/Method/Var flags. Probably something to consider, even though I am a bit reluctant to add new fields without trying to avoid it .
> 
> Any feedback is welcome!

Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:

 - Cleanup.
 - Merge branch 'master' into JDK-8241356
 - Removing merge tags are noted on the review - thanks!
 - Whitespaces.
 - Cleanup.
 - Merging master into JDK-8241356
 - 8241356: Use a more reliable way to encode Symbol flags

-------------

Changes: https://git.openjdk.java.net/jdk/pull/2316/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2316&range=02
  Stats: 800 lines in 31 files changed: 341 ins; 211 del; 248 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2316.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2316/head:pull/2316

PR: https://git.openjdk.java.net/jdk/pull/2316

From shade at openjdk.java.net  Fri Jun  3 10:38:26 2022
From: shade at openjdk.java.net (Aleksey Shipilev)
Date: Fri, 3 Jun 2022 10:38:26 GMT
Subject: RFR: 8287732: jdk/jshell/ToolEnablePreviewTest.java fails on
 x86_32 after JDK-8287496 [v2]
In-Reply-To: <fRMvu8VpjEsCG4p8psL9cP9PWAYIydlxqX_QjJj3344=.a9bc4d3e-d669-4c6c-a18b-842ca7dbff00@github.com>
References: <-J2L9ETLN2yM9Edov2A6mJQ6QO5sbSwWsstzbFlxgEE=.185ac61a-8b81-4cdd-b560-84d1a129ab27@github.com>
 <fRMvu8VpjEsCG4p8psL9cP9PWAYIydlxqX_QjJj3344=.a9bc4d3e-d669-4c6c-a18b-842ca7dbff00@github.com>
Message-ID: <lOc5BqPyTxbTMwcLrh9WRDxtC6IPKYehT82iv98RZJo=.26097964-700c-4bbe-8261-19b21327bfcc@github.com>

On Fri, 3 Jun 2022 05:54:21 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Manifests right now in x86_32 tier1 tests and GHA. The test tries to launch the tool via JDI/JVMTI, which does not fully work without continuations after [JDK-8287496](https://bugs.openjdk.java.net/browse/JDK-8287496):
>> 
>> 
>> FailOverExecutionControlProvider: FAILED: 1:jdi:launch(true) --
>>   Exception: java.lang.InternalError: Failed remote launch: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679 @ com.sun.jdi.CommandLineLaunch (defaults: home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=, main=, suspend=true, quote=", vmexec=java, enumeratevthreads=n) -- {home=home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=options=--enable-preview, main=main=jdk.jshell.execution.RemoteExecutionControl 43679, suspend=suspend=true, quote=quote=", vmexec=vmexec=java, enumeratevthreads=enumeratevthreads=n}
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.reportLaunchFail(JdiInitiator.java:300)
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.launchTarget(JdiInitiator.java:141)
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:110)
>>                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
>>                   jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
>>       cause: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679
>> FailOverExecutionControlProvider: FAILED: 2:jdi --
>>   Exception: java.lang.IllegalArgumentException: ERROR: JDWP unable to access JVMTI Version 1 (0x30010000), is your J2SE a 1.5 or newer version? JNIEnv's GetEnv() returned -3
>> 
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.listenTarget(JdiInitiator.java:201)
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:111)
>>                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
>>                   jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
>>                   jdk.jshell/jdk.jshell.spi.ExecutionControl.generate(ExecutionControl.java:179)
>> 
>> 
>> I think test needs `@requires vm.continuations` as well.
>> 
>> Additional testing:
>>  - [x] Linux x86_32 `fastdebug`, affected test now skipped
>>  - [x] Linux x86_64 `fastdebug`, affected test still runs
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Copyright updates
>  - Merge branch 'master' into JDK-8287732-loom-tool-enable-preview
>  - Fix

Thank you, any more reviews?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8995

From kvn at openjdk.java.net  Sat Jun  4 16:10:25 2022
From: kvn at openjdk.java.net (Vladimir Kozlov)
Date: Sat, 4 Jun 2022 16:10:25 GMT
Subject: RFR: 8287732: jdk/jshell/ToolEnablePreviewTest.java fails on
 x86_32 after JDK-8287496 [v2]
In-Reply-To: <fRMvu8VpjEsCG4p8psL9cP9PWAYIydlxqX_QjJj3344=.a9bc4d3e-d669-4c6c-a18b-842ca7dbff00@github.com>
References: <-J2L9ETLN2yM9Edov2A6mJQ6QO5sbSwWsstzbFlxgEE=.185ac61a-8b81-4cdd-b560-84d1a129ab27@github.com>
 <fRMvu8VpjEsCG4p8psL9cP9PWAYIydlxqX_QjJj3344=.a9bc4d3e-d669-4c6c-a18b-842ca7dbff00@github.com>
Message-ID: <tuVYqFTpxVNOvUqN4HQfyGNkIoEhNMecWOSJxdbl81Q=.40e3ccce-83af-4c77-971f-7690191fd5f9@github.com>

On Fri, 3 Jun 2022 05:54:21 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Manifests right now in x86_32 tier1 tests and GHA. The test tries to launch the tool via JDI/JVMTI, which does not fully work without continuations after [JDK-8287496](https://bugs.openjdk.java.net/browse/JDK-8287496):
>> 
>> 
>> FailOverExecutionControlProvider: FAILED: 1:jdi:launch(true) --
>>   Exception: java.lang.InternalError: Failed remote launch: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679 @ com.sun.jdi.CommandLineLaunch (defaults: home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=, main=, suspend=true, quote=", vmexec=java, enumeratevthreads=n) -- {home=home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=options=--enable-preview, main=main=jdk.jshell.execution.RemoteExecutionControl 43679, suspend=suspend=true, quote=quote=", vmexec=vmexec=java, enumeratevthreads=enumeratevthreads=n}
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.reportLaunchFail(JdiInitiator.java:300)
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.launchTarget(JdiInitiator.java:141)
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:110)
>>                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
>>                   jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
>>       cause: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679
>> FailOverExecutionControlProvider: FAILED: 2:jdi --
>>   Exception: java.lang.IllegalArgumentException: ERROR: JDWP unable to access JVMTI Version 1 (0x30010000), is your J2SE a 1.5 or newer version? JNIEnv's GetEnv() returned -3
>> 
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.listenTarget(JdiInitiator.java:201)
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:111)
>>                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
>>                   jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
>>                   jdk.jshell/jdk.jshell.spi.ExecutionControl.generate(ExecutionControl.java:179)
>> 
>> 
>> I think test needs `@requires vm.continuations` as well.
>> 
>> Additional testing:
>>  - [x] Linux x86_32 `fastdebug`, affected test now skipped
>>  - [x] Linux x86_64 `fastdebug`, affected test still runs
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Copyright updates
>  - Merge branch 'master' into JDK-8287732-loom-tool-enable-preview
>  - Fix

Looks good.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8995

From shade at openjdk.java.net  Mon Jun  6 05:32:48 2022
From: shade at openjdk.java.net (Aleksey Shipilev)
Date: Mon, 6 Jun 2022 05:32:48 GMT
Subject: RFR: 8287732: jdk/jshell/ToolEnablePreviewTest.java fails on
 x86_32 after JDK-8287496 [v2]
In-Reply-To: <fRMvu8VpjEsCG4p8psL9cP9PWAYIydlxqX_QjJj3344=.a9bc4d3e-d669-4c6c-a18b-842ca7dbff00@github.com>
References: <-J2L9ETLN2yM9Edov2A6mJQ6QO5sbSwWsstzbFlxgEE=.185ac61a-8b81-4cdd-b560-84d1a129ab27@github.com>
 <fRMvu8VpjEsCG4p8psL9cP9PWAYIydlxqX_QjJj3344=.a9bc4d3e-d669-4c6c-a18b-842ca7dbff00@github.com>
Message-ID: <mw0eRBcTYqM9vlVDYWrnslDI9QqLqvsmIVVrQ8l3hOQ=.34bcf9bf-011f-4676-833a-75e2d5accb90@github.com>

On Fri, 3 Jun 2022 05:54:21 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Manifests right now in x86_32 tier1 tests and GHA. The test tries to launch the tool via JDI/JVMTI, which does not fully work without continuations after [JDK-8287496](https://bugs.openjdk.java.net/browse/JDK-8287496):
>> 
>> 
>> FailOverExecutionControlProvider: FAILED: 1:jdi:launch(true) --
>>   Exception: java.lang.InternalError: Failed remote launch: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679 @ com.sun.jdi.CommandLineLaunch (defaults: home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=, main=, suspend=true, quote=", vmexec=java, enumeratevthreads=n) -- {home=home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=options=--enable-preview, main=main=jdk.jshell.execution.RemoteExecutionControl 43679, suspend=suspend=true, quote=quote=", vmexec=vmexec=java, enumeratevthreads=enumeratevthreads=n}
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.reportLaunchFail(JdiInitiator.java:300)
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.launchTarget(JdiInitiator.java:141)
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:110)
>>                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
>>                   jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
>>       cause: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679
>> FailOverExecutionControlProvider: FAILED: 2:jdi --
>>   Exception: java.lang.IllegalArgumentException: ERROR: JDWP unable to access JVMTI Version 1 (0x30010000), is your J2SE a 1.5 or newer version? JNIEnv's GetEnv() returned -3
>> 
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.listenTarget(JdiInitiator.java:201)
>>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:111)
>>                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
>>                   jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
>>                   jdk.jshell/jdk.jshell.spi.ExecutionControl.generate(ExecutionControl.java:179)
>> 
>> 
>> I think test needs `@requires vm.continuations` as well.
>> 
>> Additional testing:
>>  - [x] Linux x86_32 `fastdebug`, affected test now skipped
>>  - [x] Linux x86_64 `fastdebug`, affected test still runs
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Copyright updates
>  - Merge branch 'master' into JDK-8287732-loom-tool-enable-preview
>  - Fix

Thank you!

-------------

PR: https://git.openjdk.java.net/jdk/pull/8995

From shade at openjdk.java.net  Mon Jun  6 05:32:49 2022
From: shade at openjdk.java.net (Aleksey Shipilev)
Date: Mon, 6 Jun 2022 05:32:49 GMT
Subject: Integrated: 8287732: jdk/jshell/ToolEnablePreviewTest.java fails on
 x86_32 after JDK-8287496
In-Reply-To: <-J2L9ETLN2yM9Edov2A6mJQ6QO5sbSwWsstzbFlxgEE=.185ac61a-8b81-4cdd-b560-84d1a129ab27@github.com>
References: <-J2L9ETLN2yM9Edov2A6mJQ6QO5sbSwWsstzbFlxgEE=.185ac61a-8b81-4cdd-b560-84d1a129ab27@github.com>
Message-ID: <jt5YXaP7zYpDFPrcWJlM2-cMIbqEjRtwjKfOiYWG5n0=.5103de72-da09-4933-ae1c-9ea2e3bcf0df@github.com>

On Thu, 2 Jun 2022 14:50:22 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Manifests right now in x86_32 tier1 tests and GHA. The test tries to launch the tool via JDI/JVMTI, which does not fully work without continuations after [JDK-8287496](https://bugs.openjdk.java.net/browse/JDK-8287496):
> 
> 
> FailOverExecutionControlProvider: FAILED: 1:jdi:launch(true) --
>   Exception: java.lang.InternalError: Failed remote launch: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679 @ com.sun.jdi.CommandLineLaunch (defaults: home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=, main=, suspend=true, quote=", vmexec=java, enumeratevthreads=n) -- {home=home=/home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk, options=options=--enable-preview, main=main=jdk.jshell.execution.RemoteExecutionControl 43679, suspend=suspend=true, quote=quote=", vmexec=vmexec=java, enumeratevthreads=enumeratevthreads=n}
>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.reportLaunchFail(JdiInitiator.java:300)
>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.launchTarget(JdiInitiator.java:141)
>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:110)
>                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
>                   jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
>       cause: java.util.concurrent.ExecutionException: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/shade/trunks/jdk/build/linux-x86-server-fastdebug/images/jdk/bin/java --enable-preview -Xdebug -Xrunjdwp:transport=dt_socket,address=localhost:51453,suspend=y,enumeratevthreads=n jdk.jshell.execution.RemoteExecutionControl 43679
> FailOverExecutionControlProvider: FAILED: 2:jdi --
>   Exception: java.lang.IllegalArgumentException: ERROR: JDWP unable to access JVMTI Version 1 (0x30010000), is your J2SE a 1.5 or newer version? JNIEnv's GetEnv() returned -3
> 
>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.listenTarget(JdiInitiator.java:201)
>                   jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:111)
>                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
>                   jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
>                   jdk.jshell/jdk.jshell.spi.ExecutionControl.generate(ExecutionControl.java:179)
> 
> 
> I think test needs `@requires vm.continuations` as well.
> 
> Additional testing:
>  - [x] Linux x86_32 `fastdebug`, affected test now skipped
>  - [x] Linux x86_64 `fastdebug`, affected test still runs

This pull request has now been integrated.

Changeset: 0d1a3053
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/0d1a3053cd25dc666981c5aedfa5efc2dc95bd0e
Stats:     16 lines in 2 files changed: 15 ins; 0 del; 1 mod

8287732: jdk/jshell/ToolEnablePreviewTest.java fails on x86_32 after JDK-8287496

Reviewed-by: alanb, kvn

-------------

PR: https://git.openjdk.java.net/jdk/pull/8995

From jlahoda at openjdk.java.net  Mon Jun  6 14:49:05 2022
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Mon, 6 Jun 2022 14:49:05 GMT
Subject: RFR: 8286206: Missing cases for RECORD
Message-ID: <ZYWClWU13X886-pVUQg1Nnhz5poSSmDRhULECJQQZFM=.4d2d0bee-566f-41f6-80b1-b28bfb67a646@github.com>

Adds handling of `ElementKind.RECORD` to JShell's code completion.

-------------

Commit messages:
 - 8286206: Missing cases for RECORD

Changes: https://git.openjdk.java.net/jdk/pull/9042/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=9042&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8286206
  Stats: 40 lines in 3 files changed: 31 ins; 0 del; 9 mod
  Patch: https://git.openjdk.java.net/jdk/pull/9042.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/9042/head:pull/9042

PR: https://git.openjdk.java.net/jdk/pull/9042

From vromero at openjdk.java.net  Mon Jun  6 20:35:47 2022
From: vromero at openjdk.java.net (Vicente Romero)
Date: Mon, 6 Jun 2022 20:35:47 GMT
Subject: RFR: 8286206: Missing cases for RECORD
In-Reply-To: <ZYWClWU13X886-pVUQg1Nnhz5poSSmDRhULECJQQZFM=.4d2d0bee-566f-41f6-80b1-b28bfb67a646@github.com>
References: <ZYWClWU13X886-pVUQg1Nnhz5poSSmDRhULECJQQZFM=.4d2d0bee-566f-41f6-80b1-b28bfb67a646@github.com>
Message-ID: <AqZavwrt1Z07b94Pl4PSidLwwVLkUYF-8elEZ9Pn0q4=.5156a238-4d97-45f7-821b-3231ae1790c7@github.com>

On Mon, 6 Jun 2022 14:40:01 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> Adds handling of `ElementKind.RECORD` to JShell's code completion.

looks sensible to me

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/9042

From jjg at openjdk.java.net  Mon Jun  6 20:35:51 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Mon, 6 Jun 2022 20:35:51 GMT
Subject: RFR: 8286206: Missing cases for RECORD
In-Reply-To: <ZYWClWU13X886-pVUQg1Nnhz5poSSmDRhULECJQQZFM=.4d2d0bee-566f-41f6-80b1-b28bfb67a646@github.com>
References: <ZYWClWU13X886-pVUQg1Nnhz5poSSmDRhULECJQQZFM=.4d2d0bee-566f-41f6-80b1-b28bfb67a646@github.com>
Message-ID: <YInk6Byr2I_wXd1ZfIthV26tL-q_DR-PvHYohvGaT9w=.28798c04-9c6e-4b94-aa34-8bd85dee8be5@github.com>

On Mon, 6 Jun 2022 14:40:01 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> Adds handling of `ElementKind.RECORD` to JShell's code completion.

I can't easily verify whether you have found all the necessary places to update, but I do understand/approve what I see here.

On switch statements, like at JavadocHelper:701, would it help to list the cases now covered by default, and use `default` as an "error" to catch unhandled new cases in future?

-------------

Marked as reviewed by jjg (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/9042

From jlahoda at openjdk.java.net  Tue Jun  7 09:33:06 2022
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Tue, 7 Jun 2022 09:33:06 GMT
Subject: RFR: 8286206: Missing cases for RECORD [v2]
In-Reply-To: <ZYWClWU13X886-pVUQg1Nnhz5poSSmDRhULECJQQZFM=.4d2d0bee-566f-41f6-80b1-b28bfb67a646@github.com>
References: <ZYWClWU13X886-pVUQg1Nnhz5poSSmDRhULECJQQZFM=.4d2d0bee-566f-41f6-80b1-b28bfb67a646@github.com>
Message-ID: <fzKaqEkJDr4oVvWnUtT_XL1XwkrV5ucjN-tk_wMeD98=.5ad3b5bf-75b7-4fa6-929d-4862d92d1eac@github.com>

> Adds handling of `ElementKind.RECORD` to JShell's code completion.

Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:

  Listing all possible elements as suggested.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/9042/files
  - new: https://git.openjdk.java.net/jdk/pull/9042/files/9067d979..6a7e8bd3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=9042&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=9042&range=00-01

  Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/9042.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/9042/head:pull/9042

PR: https://git.openjdk.java.net/jdk/pull/9042

From jlahoda at openjdk.java.net  Tue Jun  7 14:44:14 2022
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Tue, 7 Jun 2022 14:44:14 GMT
Subject: RFR: 8287897: Augment src/jdk.internal.le/share/legal/jline.md with
 information on 4th party dependencies
Message-ID: <MLzimCvidWqqQArullW0RRzpsKqicK9IrHgmJzA3Z-4=.db1ddf11-8361-494a-8891-5286099e150b@github.com>

8287897: Augment src/jdk.internal.le/share/legal/jline.md with information on 4th party dependencies

-------------

Commit messages:
 - 8287897: Augment src/jdk.internal.le/share/legal/jline.md with information on 4th party dependencies

Changes: https://git.openjdk.java.net/jdk/pull/9065/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=9065&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8287897
  Stats: 248 lines in 1 file changed: 248 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/9065.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/9065/head:pull/9065

PR: https://git.openjdk.java.net/jdk/pull/9065

From jlahoda at openjdk.java.net  Tue Jun  7 15:25:55 2022
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Tue, 7 Jun 2022 15:25:55 GMT
Subject: Integrated: 8286206: Missing cases for RECORD
In-Reply-To: <ZYWClWU13X886-pVUQg1Nnhz5poSSmDRhULECJQQZFM=.4d2d0bee-566f-41f6-80b1-b28bfb67a646@github.com>
References: <ZYWClWU13X886-pVUQg1Nnhz5poSSmDRhULECJQQZFM=.4d2d0bee-566f-41f6-80b1-b28bfb67a646@github.com>
Message-ID: <2xqJ445B9I5p6AQgH4bCJtMyqyLBS-x7KbY3Fm4Nfyk=.25d283b3-0d95-4281-a6f3-cb53a291fb9d@github.com>

On Mon, 6 Jun 2022 14:40:01 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> Adds handling of `ElementKind.RECORD` to JShell's code completion.

This pull request has now been integrated.

Changeset: 062db59e
Author:    Jan Lahoda <jlahoda at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/062db59eeb8ba6389aaa3c622dbc109a92d580ca
Stats:     45 lines in 3 files changed: 35 ins; 0 del; 10 mod

8286206: Missing cases for RECORD

Reviewed-by: vromero, jjg

-------------

PR: https://git.openjdk.java.net/jdk/pull/9042

From vromero at openjdk.java.net  Tue Jun  7 17:19:14 2022
From: vromero at openjdk.java.net (Vicente Romero)
Date: Tue, 7 Jun 2022 17:19:14 GMT
Subject: RFR: 8287897: Augment src/jdk.internal.le/share/legal/jline.md
 with information on 4th party dependencies
In-Reply-To: <MLzimCvidWqqQArullW0RRzpsKqicK9IrHgmJzA3Z-4=.db1ddf11-8361-494a-8891-5286099e150b@github.com>
References: <MLzimCvidWqqQArullW0RRzpsKqicK9IrHgmJzA3Z-4=.db1ddf11-8361-494a-8891-5286099e150b@github.com>
Message-ID: <t8Ly6dX8WDbfqJJRNCoYCEKW5S8ujUbCQ-X4yiwMTPg=.f60aae07-3e99-4231-b4cf-6781064fe34f@github.com>

On Tue, 7 Jun 2022 14:34:30 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> 8287897: Augment src/jdk.internal.le/share/legal/jline.md with information on 4th party dependencies

src/jdk.internal.le/share/legal/jline.md line 237:

> 235:      identification within third-party archives.
> 236: 
> 237:   Copyright [yyyy] [name of copyright owner]

we need to update the template here?

src/jdk.internal.le/share/legal/jline.md line 287:

> 285: WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
> 286: 
> 287: These terms are identical to those of the MIT License, also called the X License or the X11 License, which is a simple, permissive non-copyleft free software license. It is deemed compatible with virtually all types of licenses, commercial or otherwise. In particular, the Free Software Foundation has declared it compatible with GNU GPL. It is also known to be approved by the Apache Software Foundation as compatible with Apache Software License.

there seem to be some indentation issues here

-------------

PR: https://git.openjdk.java.net/jdk/pull/9065

From jlahoda at openjdk.java.net  Tue Jun  7 17:39:11 2022
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Tue, 7 Jun 2022 17:39:11 GMT
Subject: RFR: 8287897: Augment src/jdk.internal.le/share/legal/jline.md
 with information on 4th party dependencies [v2]
In-Reply-To: <MLzimCvidWqqQArullW0RRzpsKqicK9IrHgmJzA3Z-4=.db1ddf11-8361-494a-8891-5286099e150b@github.com>
References: <MLzimCvidWqqQArullW0RRzpsKqicK9IrHgmJzA3Z-4=.db1ddf11-8361-494a-8891-5286099e150b@github.com>
Message-ID: <WJ_5i7eiJ4AxEjKwD93fM7BPoZNXZOHKfeQ2V85erac=.ba098b8a-8fb9-49ad-99dc-ca97d70fdde6@github.com>

> 8287897: Augment src/jdk.internal.le/share/legal/jline.md with information on 4th party dependencies

Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:

  Line wrapping.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/9065/files
  - new: https://git.openjdk.java.net/jdk/pull/9065/files/a0541a49..8f665529

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=9065&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=9065&range=00-01

  Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/9065.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/9065/head:pull/9065

PR: https://git.openjdk.java.net/jdk/pull/9065

From jlahoda at openjdk.java.net  Tue Jun  7 17:51:06 2022
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Tue, 7 Jun 2022 17:51:06 GMT
Subject: RFR: 8287897: Augment src/jdk.internal.le/share/legal/jline.md
 with information on 4th party dependencies [v2]
In-Reply-To: <t8Ly6dX8WDbfqJJRNCoYCEKW5S8ujUbCQ-X4yiwMTPg=.f60aae07-3e99-4231-b4cf-6781064fe34f@github.com>
References: <MLzimCvidWqqQArullW0RRzpsKqicK9IrHgmJzA3Z-4=.db1ddf11-8361-494a-8891-5286099e150b@github.com>
 <t8Ly6dX8WDbfqJJRNCoYCEKW5S8ujUbCQ-X4yiwMTPg=.f60aae07-3e99-4231-b4cf-6781064fe34f@github.com>
Message-ID: <Teo4o6kVLulGERLOfxZ8WfT_9Y7STSKV5D5ifc2Q9O4=.21d4a6db-58b2-4c16-93f9-4afca939d91e@github.com>

On Tue, 7 Jun 2022 17:15:11 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Line wrapping.
>
> src/jdk.internal.le/share/legal/jline.md line 237:
> 
>> 235:      identification within third-party archives.
>> 236: 
>> 237:   Copyright [yyyy] [name of copyright owner]
> 
> we need to update the template here?

I believe this text is a template, that can be filled by others, so this should not be modified.

> src/jdk.internal.le/share/legal/jline.md line 287:
> 
>> 285: WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
>> 286: 
>> 287: These terms are identical to those of the MIT License, also called the X License or the X11 License, which is a simple, permissive non-copyleft free software license. It is deemed compatible with virtually all types of licenses, commercial or otherwise. In particular, the Free Software Foundation has declared it compatible with GNU GPL. It is also known to be approved by the Apache Software Foundation as compatible with Apache Software License.
> 
> there seem to be some indentation issues here

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/9065

From vromero at openjdk.java.net  Tue Jun  7 18:27:13 2022
From: vromero at openjdk.java.net (Vicente Romero)
Date: Tue, 7 Jun 2022 18:27:13 GMT
Subject: RFR: 8287897: Augment src/jdk.internal.le/share/legal/jline.md
 with information on 4th party dependencies [v2]
In-Reply-To: <WJ_5i7eiJ4AxEjKwD93fM7BPoZNXZOHKfeQ2V85erac=.ba098b8a-8fb9-49ad-99dc-ca97d70fdde6@github.com>
References: <MLzimCvidWqqQArullW0RRzpsKqicK9IrHgmJzA3Z-4=.db1ddf11-8361-494a-8891-5286099e150b@github.com>
 <WJ_5i7eiJ4AxEjKwD93fM7BPoZNXZOHKfeQ2V85erac=.ba098b8a-8fb9-49ad-99dc-ca97d70fdde6@github.com>
Message-ID: <gC6xKj31Q-uVnLoH6zW-Mzn-0XU8wXgO15NI_0ZVH20=.2308649f-385f-4b58-8ed2-38829f7371c7@github.com>

On Tue, 7 Jun 2022 17:39:11 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> 8287897: Augment src/jdk.internal.le/share/legal/jline.md with information on 4th party dependencies
>
> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Line wrapping.

just added a nit additional comment, there is no need for another iteration

src/jdk.internal.le/share/legal/jline.md line 256:

> 254: The library is subject to the Mozilla Public License Version 1.1.
> 255: 
> 256: Alternatively, the library may be used under the terms of either the GNU General Public License Version 2 or later, or the GNU Lesser General Public License 2.1 or later.

should we fix the indentation of this line?

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/9065

From jlahoda at openjdk.java.net  Wed Jun  8 12:07:35 2022
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Wed, 8 Jun 2022 12:07:35 GMT
Subject: RFR: 8287897: Augment src/jdk.internal.le/share/legal/jline.md
 with information on 4th party dependencies [v2]
In-Reply-To: <gC6xKj31Q-uVnLoH6zW-Mzn-0XU8wXgO15NI_0ZVH20=.2308649f-385f-4b58-8ed2-38829f7371c7@github.com>
References: <MLzimCvidWqqQArullW0RRzpsKqicK9IrHgmJzA3Z-4=.db1ddf11-8361-494a-8891-5286099e150b@github.com>
 <WJ_5i7eiJ4AxEjKwD93fM7BPoZNXZOHKfeQ2V85erac=.ba098b8a-8fb9-49ad-99dc-ca97d70fdde6@github.com>
 <gC6xKj31Q-uVnLoH6zW-Mzn-0XU8wXgO15NI_0ZVH20=.2308649f-385f-4b58-8ed2-38829f7371c7@github.com>
Message-ID: <TSgmLqHimwA_X2MvPgJ5QKolaYna1LfUyjorXP-kuJk=.fc7fcfea-82d2-4233-937d-5693111e1c1d@github.com>

On Tue, 7 Jun 2022 18:22:46 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Line wrapping.
>
> src/jdk.internal.le/share/legal/jline.md line 256:
> 
>> 254: The library is subject to the Mozilla Public License Version 1.1.
>> 255: 
>> 256: Alternatively, the library may be used under the terms of either the GNU General Public License Version 2 or later, or the GNU Lesser General Public License 2.1 or later.
> 
> should we fix the indentation of this line?

In this case, I'd rather keep it as is, as it is not clear what are the allowed wraps here.

-------------

PR: https://git.openjdk.java.net/jdk/pull/9065

From jlahoda at openjdk.java.net  Thu Jun  9 07:13:39 2022
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Thu, 9 Jun 2022 07:13:39 GMT
Subject: Integrated: 8287897: Augment src/jdk.internal.le/share/legal/jline.md
 with information on 4th party dependencies
In-Reply-To: <MLzimCvidWqqQArullW0RRzpsKqicK9IrHgmJzA3Z-4=.db1ddf11-8361-494a-8891-5286099e150b@github.com>
References: <MLzimCvidWqqQArullW0RRzpsKqicK9IrHgmJzA3Z-4=.db1ddf11-8361-494a-8891-5286099e150b@github.com>
Message-ID: <0GEimYsEC3kINpVPoZEQEFHKmv4xG3Q8ipjvV3HOSso=.cb461d94-b5f8-41e2-a5f6-ec4e454d3f87@github.com>

On Tue, 7 Jun 2022 14:34:30 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> 8287897: Augment src/jdk.internal.le/share/legal/jline.md with information on 4th party dependencies

This pull request has now been integrated.

Changeset: bc28baeb
Author:    Jan Lahoda <jlahoda at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/bc28baeba9360991e9b7575e1fbe178d873ccfc1
Stats:     253 lines in 1 file changed: 253 ins; 0 del; 0 mod

8287897: Augment src/jdk.internal.le/share/legal/jline.md with information on 4th party dependencies

Reviewed-by: vromero

-------------

PR: https://git.openjdk.java.net/jdk/pull/9065