RFR: 8278039: Code completion not woking after some statements such as "if" or "while" [v3]

Jan Lahoda jlahoda at openjdk.java.net
Fri May 13 08:57:40 UTC 2022


> Consider these snippets with completion:
> 
> String s = "";
> if (s.c<tab>
> 
> 
> The completion here proposes:
> 
> char   com.
> 
> 
> which is clearly wrong. The reason is that when the completion searches for the deepest `Tree` at the cursor's position, it finds a tree for the synthetic/error recovery ';' for the then section of the command, rather than a tree in the condition.
> 
> The proposed patch is to tweak the search for the deepest `Tree`, so that the tree from the if's condition is found.

Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:

  Enhancing test.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7308/files
  - new: https://git.openjdk.java.net/jdk/pull/7308/files/1c9c550a..2afda27e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7308&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7308&range=01-02

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7308.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7308/head:pull/7308

PR: https://git.openjdk.java.net/jdk/pull/7308


More information about the kulla-dev mailing list