RFR: 8295814: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected [2] but found [1]" [v2]

[Adam Sotona]

On Thu, 27 Oct 2022 10:23:03 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> File completion in CommandCompletionTest::testSet intermittently fails.
>> Also message provided by org.testng.Assert::assertEquals is also not very verbose when comparing collections:
>> "lists don't have the same size expected [2] but found [1]".
>> 
>> Cause of the failure is in the expected side of the assertion (CommandCompletionTest::getRootDirectories), which may conatain duplicates. While the actual side of the assertion is distinct (CommandCompletionTest::computeCompletions).
>> 
>> Proposed patch de-duplicates CommandCompletionTest::getRootDirectories and adds full description of the expected result to the error message for future debugging.
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   relaxed tests depending on shared folders content

Please review proposed patch to test minimal size of the expected completion response for problematic test cases, instead of verification of the exact content.

-------------

PR: https://git.openjdk.org/jdk/pull/10870