RFR: 8297525: jdk/jshell/ToolBasicTest.java fails after JDK-8295984

Wed Nov 23 20:22:19 UTC 2022

On Wed, 23 Nov 2022 19:05:09 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> The expected text uses a platform newline, but the actual text seems to always use `'\n'`. Sorry for that.

I was somehow convinced the tests are using native line endings, but they are normalizing them here:
https://github.com/openjdk/jdk/blob/6dc4d891c3ad043405c65e0e0eeef28e9e5a2156/test/langtools/jdk/jshell/ReplToolTesting.java#L203

So, I don't think there's a bug in JShell, it is simply the test expecting wrong values.

(And I didn't fully realize the test is not tier1, and so not run on GitHub.)

Sorry for that and thanks for review!

-------------

PR: https://git.openjdk.org/jdk/pull/11330