RFR: 8295814: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected [2] but found [1]"

[Daniel D. Daugherty]

On Wed, 26 Oct 2022 10:28:19 GMT, Adam Sotona <asotona at openjdk.org> wrote:

> File completion in CommandCompletionTest::testSet intermittently fails.
> Also message provided by org.testng.Assert::assertEquals is also not very verbose when comparing collections:
> "lists don't have the same size expected [2] but found [1]".
> 
> Cause of the failure is in the expected side of the assertion (CommandCompletionTest::getRootDirectories), which may conatain duplicates. While the actual side of the assertion is distinct (CommandCompletionTest::computeCompletions).
> 
> Proposed patch de-duplicates CommandCompletionTest::getRootDirectories and adds full description of the expected result to the error message for future debugging.
> 
> Please review.
> 
> Thanks,
> Adam

@asotona - please see this comment that I added to the bug:

https://bugs.openjdk.org/browse/JDK-8295814?focusedCommentId=14532614&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14532614

-------------

PR: https://git.openjdk.org/jdk/pull/10870