RFR: 8295814: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected [2] but found [1]" [v2]

Adam Sotona asotona at openjdk.org
Thu Oct 27 10:23:03 UTC 2022


> File completion in CommandCompletionTest::testSet intermittently fails.
> Also message provided by org.testng.Assert::assertEquals is also not very verbose when comparing collections:
> "lists don't have the same size expected [2] but found [1]".
> 
> Cause of the failure is in the expected side of the assertion (CommandCompletionTest::getRootDirectories), which may conatain duplicates. While the actual side of the assertion is distinct (CommandCompletionTest::computeCompletions).
> 
> Proposed patch de-duplicates CommandCompletionTest::getRootDirectories and adds full description of the expected result to the error message for future debugging.
> 
> Please review.
> 
> Thanks,
> Adam

Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:

  relaxed tests depending on shared folders content

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10870/files
  - new: https://git.openjdk.org/jdk/pull/10870/files/35de303a..c3e8fc0b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10870&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10870&range=00-01

  Stats: 43 lines in 1 file changed: 10 ins; 26 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/10870.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10870/head:pull/10870

PR: https://git.openjdk.org/jdk/pull/10870


More information about the kulla-dev mailing list