RFR: 8296454: System.console() shouldn't return null in jshell [v2]

[Jonathan Gibbons]

On Tue, 21 Mar 2023 08:55:32 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/JDK-8296454b' into JDK-8296454b
>>  - Merge branch 'master' into JDK-8296454b
>>  - Speeding up writes to the Console's Writer by not waiting for the response.
>>  - Cleanup.
>>  - Cleanup.
>>  - Fixing test.
>>  - Adding support for Charset.
>>  - Test when there's no JShellConsole.
>>  - Buffering output.
>>  - Improving synchronizations and fixing sending of many requests from the agent into the main process.
>>  - ... and 2 more: https://git.openjdk.org/jdk/compare/65938908...d58e53f1
>
> src/jdk.jshell/share/classes/jdk/jshell/execution/impl/ConsoleImpl.java line 196:
> 
>> 194:          */
>> 195:         @Override
>> 196:         public JdkConsole format(String fmt, Object ...args) {
> 
> Suggestion:
> 
>         public JdkConsole format(String fmt, Object ... args) {

There is normally no space before the `...`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/11695#discussion_r1156071500