RFR: 8302344: Compiler Implementation for Unnamed patterns and variables (Preview) [v3]

Maurizio Cimadamore mcimadamore at openjdk.org
Fri Apr 28 09:45:55 UTC 2023


On Thu, 27 Apr 2023 14:30:22 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address javax.lang.model comments
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Flags.java line 278:
> 
>> 276: 
>> 277:     /**
>> 278:      * Flag that indicates that a local variable, a lambda parameter, or an unnamed pattern variable is unnamed.
> 
> question: cant we infer this from the name itself instead of consuming a flag?

I have the same feeling. Flags are a scarce resource - if we can avoid using one that would be best :-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13528#discussion_r1180155474


More information about the kulla-dev mailing list