From duke at openjdk.org  Thu Jul  6 23:35:09 2023
From: duke at openjdk.org (duke)
Date: Thu, 6 Jul 2023 23:35:09 GMT
Subject: Withdrawn: 8301991: Convert l10n properties resource bundles to UTF-8
 native
In-Reply-To: <0MB7FLFNfaGEWssr9X54UJ_iZNFWBJkxQ1yusP7fsuY=.3f9f3de5-fe84-48e6-9449-626cac42da0b@github.com>
References: <0MB7FLFNfaGEWssr9X54UJ_iZNFWBJkxQ1yusP7fsuY=.3f9f3de5-fe84-48e6-9449-626cac42da0b@github.com>
Message-ID: <uaRK1W4uoY8WriKgYieJVUIGwgh0EMcgfXRicbKTmg4=.e68ef291-6589-493a-b7e9-8086097fb392@github.com>

On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu <jlu at openjdk.org> wrote:

> This PR converts Unicode sequences to UTF-8 native in .properties file. (Excluding the Unicode space and tab sequence). The conversion was done using native2ascii.
> 
> In addition, the build logic is adjusted to support reading in the .properties files as UTF-8 during the conversion from .properties file to .java ListResourceBundle file.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/12726

From vromero at openjdk.org  Fri Jul  7 18:08:59 2023
From: vromero at openjdk.org (Vicente Romero)
Date: Fri, 7 Jul 2023 18:08:59 GMT
Subject: RFR: 8194743: Compiler implementation for Statements before
 super() [v7]
In-Reply-To: <sCPdoIjpEUwHJXuUpVYVsNtrFgdQKKE7QLBctyEUUpE=.87586eec-b76d-4520-adf5-b5a1259a6a5c@github.com>
References: <NOF-YbVLoOgUEvt-pWZVkbKkLnkSH-9ek3IGUb7JBfo=.a6db8599-7c2b-4534-aeb2-1d5d67c9cc57@github.com>
 <sCPdoIjpEUwHJXuUpVYVsNtrFgdQKKE7QLBctyEUUpE=.87586eec-b76d-4520-adf5-b5a1259a6a5c@github.com>
Message-ID: <nqhbzWFBRWCeX54dXVJn5YSN3_xro06k0UJ9yrjhcu8=.1a95b8f4-5d75-41b8-abb6-36ddba71b53c@github.com>

On Tue, 13 Jun 2023 15:14:41 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> This is a first draft of a patch for JEP 447.
>> 
>> Summary of changes:
>> 
>> 1. Track when we're within a constructor "prologue" via new flag `AttrContext.ctorPrologue`
>> 1. Add checks for illegal early access to `this` in constructor prologues, and update existing checks to distinguish between static context vs. constructor prologue context
>> 1. Verify allowed placement of `super()`/`this()` calls via new method `Check.checkSuperInitCalls()`
>> 1. Remove/refactor assumptions in several places that `super()`/`this()` was always the first statement
>> 
>> The changes in `Flow.java` are an example of <span>#</span>4. `Flow.FlowAnalyzer` checks for uncaught checked exceptions. For initializer blocks, this was previously done by requiring that any checked exceptions thrown be declared as thrown by all constructors containing `super()`. This list of checked exceptions was being pre-calculated before recursing into the initial constructors. This worked because initializer blocks were executed at the beginning of each initial constructor right after `super()` is called.
>> 
>> Now initializer blocks are traversed as each `super()` invocation is encountered, reflecting what actually happens at runtime. Similarly, final fields are marked as DA after encountering `this()`, not automatically at the beginning of those  constructors. These changes produce equivalent checks, but are compatible with the new flexibility of placement of `super()`/`this()` as well as possible future changes that could occur along these same lines.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
> 
>  - Merge branch 'master' into SuperInit
>  - Fix mistake in previous merge commit 80ba6be4.
>  - Merge branch 'master' into SuperInit
>  - Rename unit test to be consistent with other feature exampless.
>  - Update unit test after merged-in commit eaa80ad08.
>  - Add unit tests with local class decl's prior to super().
>  - Merge branch 'master' into SuperInit
>  - Use @enablePreview in tests in preference to explicit command line flags.
>  - Make "statements before super()" support a preview feature.
>    
>    Thanks to Jim Laskey for help with preview logic.
>  - Small refactoring to avoid redundant test.
>  - ... and 15 more: https://git.openjdk.org/jdk/compare/c0aa6bf4...a5f8cc5e

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 1053:

> 1051: 
> 1052:             // Is this method a constructor?
> 1053:             boolean isConstructor = tree.name == names.init;

consider using TreeInfo::isConstructor instead, which is a more general approach. Valhalla could use another special name for constructors

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13656#discussion_r1256240564

From acobbs at openjdk.org  Fri Jul  7 19:11:14 2023
From: acobbs at openjdk.org (Archie Cobbs)
Date: Fri, 7 Jul 2023 19:11:14 GMT
Subject: RFR: 8194743: Compiler implementation for Statements before
 super() [v8]
In-Reply-To: <NOF-YbVLoOgUEvt-pWZVkbKkLnkSH-9ek3IGUb7JBfo=.a6db8599-7c2b-4534-aeb2-1d5d67c9cc57@github.com>
References: <NOF-YbVLoOgUEvt-pWZVkbKkLnkSH-9ek3IGUb7JBfo=.a6db8599-7c2b-4534-aeb2-1d5d67c9cc57@github.com>
Message-ID: <xx035-LICbOUfJ8a3Db1xGZGiq0DRcAXL96Y7Dp8FaU=.2774ffe8-7115-4b7e-8e0d-da91ecaafe52@github.com>

> This is a first draft of a patch for JEP 447.
> 
> Summary of changes:
> 
> 1. Track when we're within a constructor "prologue" via new flag `AttrContext.ctorPrologue`
> 1. Add checks for illegal early access to `this` in constructor prologues, and update existing checks to distinguish between static context vs. constructor prologue context
> 1. Verify allowed placement of `super()`/`this()` calls via new method `Check.checkSuperInitCalls()`
> 1. Remove/refactor assumptions in several places that `super()`/`this()` was always the first statement
> 
> The changes in `Flow.java` are an example of <span>#</span>4. `Flow.FlowAnalyzer` checks for uncaught checked exceptions. For initializer blocks, this was previously done by requiring that any checked exceptions thrown be declared as thrown by all constructors containing `super()`. This list of checked exceptions was being pre-calculated before recursing into the initial constructors. This worked because initializer blocks were executed at the beginning of each initial constructor right after `super()` is called.
> 
> Now initializer blocks are traversed as each `super()` invocation is encountered, reflecting what actually happens at runtime. Similarly, final fields are marked as DA after encountering `this()`, not automatically at the beginning of those  constructors. These changes produce equivalent checks, but are compatible with the new flexibility of placement of `super()`/`this()` as well as possible future changes that could occur along these same lines.

Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:

  Use TreeInfo.isConstructor() for detecting constructors.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13656/files
  - new: https://git.openjdk.org/jdk/pull/13656/files/a5f8cc5e..c6cf80fc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13656&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13656&range=06-07

  Stats: 9 lines in 4 files changed: 0 ins; 3 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/13656.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13656/head:pull/13656

PR: https://git.openjdk.org/jdk/pull/13656

From acobbs at openjdk.org  Fri Jul  7 19:11:19 2023
From: acobbs at openjdk.org (Archie Cobbs)
Date: Fri, 7 Jul 2023 19:11:19 GMT
Subject: RFR: 8194743: Compiler implementation for Statements before
 super() [v7]
In-Reply-To: <nqhbzWFBRWCeX54dXVJn5YSN3_xro06k0UJ9yrjhcu8=.1a95b8f4-5d75-41b8-abb6-36ddba71b53c@github.com>
References: <NOF-YbVLoOgUEvt-pWZVkbKkLnkSH-9ek3IGUb7JBfo=.a6db8599-7c2b-4534-aeb2-1d5d67c9cc57@github.com>
 <sCPdoIjpEUwHJXuUpVYVsNtrFgdQKKE7QLBctyEUUpE=.87586eec-b76d-4520-adf5-b5a1259a6a5c@github.com>
 <nqhbzWFBRWCeX54dXVJn5YSN3_xro06k0UJ9yrjhcu8=.1a95b8f4-5d75-41b8-abb6-36ddba71b53c@github.com>
Message-ID: <RJoW8fniepdPmT2vkx2358CJkzH3yJMjbCT9zaCKczI=.675e08f6-184d-4577-a5c4-22696fe022b8@github.com>

On Fri, 7 Jul 2023 18:05:08 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
>> 
>>  - Merge branch 'master' into SuperInit
>>  - Fix mistake in previous merge commit 80ba6be4.
>>  - Merge branch 'master' into SuperInit
>>  - Rename unit test to be consistent with other feature exampless.
>>  - Update unit test after merged-in commit eaa80ad08.
>>  - Add unit tests with local class decl's prior to super().
>>  - Merge branch 'master' into SuperInit
>>  - Use @enablePreview in tests in preference to explicit command line flags.
>>  - Make "statements before super()" support a preview feature.
>>    
>>    Thanks to Jim Laskey for help with preview logic.
>>  - Small refactoring to avoid redundant test.
>>  - ... and 15 more: https://git.openjdk.org/jdk/compare/c0aa6bf4...a5f8cc5e
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 1053:
> 
>> 1051: 
>> 1052:             // Is this method a constructor?
>> 1053:             boolean isConstructor = tree.name == names.init;
> 
> consider using TreeInfo::isConstructor instead, which is a more general approach. Valhalla could use another special name for constructors

Thanks. I fixed that example and a few others as well in c6cf80fc621.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13656#discussion_r1256331970

From vromero at openjdk.org  Fri Jul  7 20:12:58 2023
From: vromero at openjdk.org (Vicente Romero)
Date: Fri, 7 Jul 2023 20:12:58 GMT
Subject: RFR: 8194743: Compiler implementation for Statements before
 super() [v7]
In-Reply-To: <sCPdoIjpEUwHJXuUpVYVsNtrFgdQKKE7QLBctyEUUpE=.87586eec-b76d-4520-adf5-b5a1259a6a5c@github.com>
References: <NOF-YbVLoOgUEvt-pWZVkbKkLnkSH-9ek3IGUb7JBfo=.a6db8599-7c2b-4534-aeb2-1d5d67c9cc57@github.com>
 <sCPdoIjpEUwHJXuUpVYVsNtrFgdQKKE7QLBctyEUUpE=.87586eec-b76d-4520-adf5-b5a1259a6a5c@github.com>
Message-ID: <IICas6P2cDXvh4Xw0-895JIPCp2-EO863Ke2p9MHeyM=.3e4aa9cd-2a8c-457f-a9b8-f24f53267856@github.com>

On Tue, 13 Jun 2023 15:14:41 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> This is a first draft of a patch for JEP 447.
>> 
>> Summary of changes:
>> 
>> 1. Track when we're within a constructor "prologue" via new flag `AttrContext.ctorPrologue`
>> 1. Add checks for illegal early access to `this` in constructor prologues, and update existing checks to distinguish between static context vs. constructor prologue context
>> 1. Verify allowed placement of `super()`/`this()` calls via new method `Check.checkSuperInitCalls()`
>> 1. Remove/refactor assumptions in several places that `super()`/`this()` was always the first statement
>> 
>> The changes in `Flow.java` are an example of <span>#</span>4. `Flow.FlowAnalyzer` checks for uncaught checked exceptions. For initializer blocks, this was previously done by requiring that any checked exceptions thrown be declared as thrown by all constructors containing `super()`. This list of checked exceptions was being pre-calculated before recursing into the initial constructors. This worked because initializer blocks were executed at the beginning of each initial constructor right after `super()` is called.
>> 
>> Now initializer blocks are traversed as each `super()` invocation is encountered, reflecting what actually happens at runtime. Similarly, final fields are marked as DA after encountering `this()`, not automatically at the beginning of those  constructors. These changes produce equivalent checks, but are compatible with the new flexibility of placement of `super()`/`this()` as well as possible future changes that could occur along these same lines.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
> 
>  - Merge branch 'master' into SuperInit
>  - Fix mistake in previous merge commit 80ba6be4.
>  - Merge branch 'master' into SuperInit
>  - Rename unit test to be consistent with other feature exampless.
>  - Update unit test after merged-in commit eaa80ad08.
>  - Add unit tests with local class decl's prior to super().
>  - Merge branch 'master' into SuperInit
>  - Use @enablePreview in tests in preference to explicit command line flags.
>  - Make "statements before super()" support a preview feature.
>    
>    Thanks to Jim Laskey for help with preview logic.
>  - Small refactoring to avoid redundant test.
>  - ... and 15 more: https://git.openjdk.org/jdk/compare/c0aa6bf4...a5f8cc5e

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 3975:

> 3973:     }
> 3974: 
> 3975:     private class SuperThisChecker extends TreeScanner {

we usually create only one instance of these type of visitors that will be used very often and reuse it whenever necessary

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 4078:

> 4076: 
> 4077:         @Override
> 4078:         public void visitClassDef(JCClassDecl tree) {

will you be descending into lambdas with this visitor?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13656#discussion_r1256278772
PR Review Comment: https://git.openjdk.org/jdk/pull/13656#discussion_r1256331686

From acobbs at openjdk.org  Fri Jul  7 21:21:22 2023
From: acobbs at openjdk.org (Archie Cobbs)
Date: Fri, 7 Jul 2023 21:21:22 GMT
Subject: RFR: 8194743: Compiler implementation for Statements before
 super() [v9]
In-Reply-To: <NOF-YbVLoOgUEvt-pWZVkbKkLnkSH-9ek3IGUb7JBfo=.a6db8599-7c2b-4534-aeb2-1d5d67c9cc57@github.com>
References: <NOF-YbVLoOgUEvt-pWZVkbKkLnkSH-9ek3IGUb7JBfo=.a6db8599-7c2b-4534-aeb2-1d5d67c9cc57@github.com>
Message-ID: <QmXBmniuzRUophhhsLcU9_2lw669Q_ETdVbK7gt5OMg=.4695075b-70e7-4884-b83d-afe6ebc5ade2@github.com>

> This is a first draft of a patch for JEP 447.
> 
> Summary of changes:
> 
> 1. Track when we're within a constructor "prologue" via new flag `AttrContext.ctorPrologue`
> 1. Add checks for illegal early access to `this` in constructor prologues, and update existing checks to distinguish between static context vs. constructor prologue context
> 1. Verify allowed placement of `super()`/`this()` calls via new method `Check.checkSuperInitCalls()`
> 1. Remove/refactor assumptions in several places that `super()`/`this()` was always the first statement
> 
> The changes in `Flow.java` are an example of <span>#</span>4. `Flow.FlowAnalyzer` checks for uncaught checked exceptions. For initializer blocks, this was previously done by requiring that any checked exceptions thrown be declared as thrown by all constructors containing `super()`. This list of checked exceptions was being pre-calculated before recursing into the initial constructors. This worked because initializer blocks were executed at the beginning of each initial constructor right after `super()` is called.
> 
> Now initializer blocks are traversed as each `super()` invocation is encountered, reflecting what actually happens at runtime. Similarly, final fields are marked as DA after encountering `this()`, not automatically at the beginning of those  constructors. These changes produce equivalent checks, but are compatible with the new flexibility of placement of `super()`/`this()` as well as possible future changes that could occur along these same lines.

Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:

  Add unit test verifying super() can't appear inside a lambda.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13656/files
  - new: https://git.openjdk.org/jdk/pull/13656/files/c6cf80fc..b0b13b2a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13656&range=08
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13656&range=07-08

  Stats: 8 lines in 2 files changed: 7 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/13656.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13656/head:pull/13656

PR: https://git.openjdk.org/jdk/pull/13656

From acobbs at openjdk.org  Fri Jul  7 21:21:24 2023
From: acobbs at openjdk.org (Archie Cobbs)
Date: Fri, 7 Jul 2023 21:21:24 GMT
Subject: RFR: 8194743: Compiler implementation for Statements before
 super() [v7]
In-Reply-To: <IICas6P2cDXvh4Xw0-895JIPCp2-EO863Ke2p9MHeyM=.3e4aa9cd-2a8c-457f-a9b8-f24f53267856@github.com>
References: <NOF-YbVLoOgUEvt-pWZVkbKkLnkSH-9ek3IGUb7JBfo=.a6db8599-7c2b-4534-aeb2-1d5d67c9cc57@github.com>
 <sCPdoIjpEUwHJXuUpVYVsNtrFgdQKKE7QLBctyEUUpE=.87586eec-b76d-4520-adf5-b5a1259a6a5c@github.com>
 <IICas6P2cDXvh4Xw0-895JIPCp2-EO863Ke2p9MHeyM=.3e4aa9cd-2a8c-457f-a9b8-f24f53267856@github.com>
Message-ID: <_BhqTR2yUVWHaMFVmATGUtnv65xclNNY865Op5UceCo=.09fbff02-0b5d-4e3f-9f8d-5afcff6ea6a3@github.com>

On Fri, 7 Jul 2023 19:05:29 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
>> 
>>  - Merge branch 'master' into SuperInit
>>  - Fix mistake in previous merge commit 80ba6be4.
>>  - Merge branch 'master' into SuperInit
>>  - Rename unit test to be consistent with other feature exampless.
>>  - Update unit test after merged-in commit eaa80ad08.
>>  - Add unit tests with local class decl's prior to super().
>>  - Merge branch 'master' into SuperInit
>>  - Use @enablePreview in tests in preference to explicit command line flags.
>>  - Make "statements before super()" support a preview feature.
>>    
>>    Thanks to Jim Laskey for help with preview logic.
>>  - Small refactoring to avoid redundant test.
>>  - ... and 15 more: https://git.openjdk.org/jdk/compare/c0aa6bf4...a5f8cc5e
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 4078:
> 
>> 4076: 
>> 4077:         @Override
>> 4078:         public void visitClassDef(JCClassDecl tree) {
> 
> will you be descending into lambdas with this visitor?

Yes, that's the intent. For good measure, I just added an explicit test to verify that `super()` inside a lambda is not allowed in b0b13b2ad22.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13656#discussion_r1256489033

From acobbs at openjdk.org  Fri Jul  7 21:32:07 2023
From: acobbs at openjdk.org (Archie Cobbs)
Date: Fri, 7 Jul 2023 21:32:07 GMT
Subject: RFR: 8194743: Compiler implementation for Statements before
 super() [v10]
In-Reply-To: <NOF-YbVLoOgUEvt-pWZVkbKkLnkSH-9ek3IGUb7JBfo=.a6db8599-7c2b-4534-aeb2-1d5d67c9cc57@github.com>
References: <NOF-YbVLoOgUEvt-pWZVkbKkLnkSH-9ek3IGUb7JBfo=.a6db8599-7c2b-4534-aeb2-1d5d67c9cc57@github.com>
Message-ID: <2D9gRZAVazf7OQbPN4Ek0yEFhTsZq7V1z-HX1EMPSfg=.12665791-ecbd-4bcb-b55d-9b6dca8548b8@github.com>

> This is a first draft of a patch for JEP 447.
> 
> Summary of changes:
> 
> 1. Track when we're within a constructor "prologue" via new flag `AttrContext.ctorPrologue`
> 1. Add checks for illegal early access to `this` in constructor prologues, and update existing checks to distinguish between static context vs. constructor prologue context
> 1. Verify allowed placement of `super()`/`this()` calls via new method `Check.checkSuperInitCalls()`
> 1. Remove/refactor assumptions in several places that `super()`/`this()` was always the first statement
> 
> The changes in `Flow.java` are an example of <span>#</span>4. `Flow.FlowAnalyzer` checks for uncaught checked exceptions. For initializer blocks, this was previously done by requiring that any checked exceptions thrown be declared as thrown by all constructors containing `super()`. This list of checked exceptions was being pre-calculated before recursing into the initial constructors. This worked because initializer blocks were executed at the beginning of each initial constructor right after `super()` is called.
> 
> Now initializer blocks are traversed as each `super()` invocation is encountered, reflecting what actually happens at runtime. Similarly, final fields are marked as DA after encountering `this()`, not automatically at the beginning of those  constructors. These changes produce equivalent checks, but are compatible with the new flexibility of placement of `super()`/`this()` as well as possible future changes that could occur along these same lines.

Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:

  Create and cache a single instance of the oft-used SuperThisChecker.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13656/files
  - new: https://git.openjdk.org/jdk/pull/13656/files/b0b13b2a..599d761b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13656&range=09
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13656&range=08-09

  Stats: 14 lines in 1 file changed: 13 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/13656.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13656/head:pull/13656

PR: https://git.openjdk.org/jdk/pull/13656

From acobbs at openjdk.org  Fri Jul  7 21:32:10 2023
From: acobbs at openjdk.org (Archie Cobbs)
Date: Fri, 7 Jul 2023 21:32:10 GMT
Subject: RFR: 8194743: Compiler implementation for Statements before
 super() [v7]
In-Reply-To: <IICas6P2cDXvh4Xw0-895JIPCp2-EO863Ke2p9MHeyM=.3e4aa9cd-2a8c-457f-a9b8-f24f53267856@github.com>
References: <NOF-YbVLoOgUEvt-pWZVkbKkLnkSH-9ek3IGUb7JBfo=.a6db8599-7c2b-4534-aeb2-1d5d67c9cc57@github.com>
 <sCPdoIjpEUwHJXuUpVYVsNtrFgdQKKE7QLBctyEUUpE=.87586eec-b76d-4520-adf5-b5a1259a6a5c@github.com>
 <IICas6P2cDXvh4Xw0-895JIPCp2-EO863Ke2p9MHeyM=.3e4aa9cd-2a8c-457f-a9b8-f24f53267856@github.com>
Message-ID: <-OFSsQ30T3f664GaGFzWykIbonJefislVTFWJV1qkXU=.050ca4c3-8aa8-4c37-bbf1-413ef884512c@github.com>

On Fri, 7 Jul 2023 18:32:36 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
>> 
>>  - Merge branch 'master' into SuperInit
>>  - Fix mistake in previous merge commit 80ba6be4.
>>  - Merge branch 'master' into SuperInit
>>  - Rename unit test to be consistent with other feature exampless.
>>  - Update unit test after merged-in commit eaa80ad08.
>>  - Add unit tests with local class decl's prior to super().
>>  - Merge branch 'master' into SuperInit
>>  - Use @enablePreview in tests in preference to explicit command line flags.
>>  - Make "statements before super()" support a preview feature.
>>    
>>    Thanks to Jim Laskey for help with preview logic.
>>  - Small refactoring to avoid redundant test.
>>  - ... and 15 more: https://git.openjdk.org/jdk/compare/c0aa6bf4...a5f8cc5e
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 3975:
> 
>> 3973:     }
>> 3974: 
>> 3975:     private class SuperThisChecker extends TreeScanner {
> 
> we usually create only one instance of these type of visitors that will be used very often and reuse it whenever necessary

Thanks - fixed in 599d761b309.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13656#discussion_r1256499145

From acobbs at openjdk.org  Sat Jul  8 15:46:07 2023
From: acobbs at openjdk.org (Archie Cobbs)
Date: Sat, 8 Jul 2023 15:46:07 GMT
Subject: RFR: 8194743: Compiler implementation for Statements before
 super() [v11]
In-Reply-To: <NOF-YbVLoOgUEvt-pWZVkbKkLnkSH-9ek3IGUb7JBfo=.a6db8599-7c2b-4534-aeb2-1d5d67c9cc57@github.com>
References: <NOF-YbVLoOgUEvt-pWZVkbKkLnkSH-9ek3IGUb7JBfo=.a6db8599-7c2b-4534-aeb2-1d5d67c9cc57@github.com>
Message-ID: <RkivlLM6SydVKh0l8QNsytGjsBq19Cur-N1Mds2YMpY=.5c00bdc7-1461-4e57-af92-715db1c1c8d2@github.com>

> This is a first draft of a patch for JEP 447.
> 
> Summary of changes:
> 
> 1. Track when we're within a constructor "prologue" via new flag `AttrContext.ctorPrologue`
> 1. Add checks for illegal early access to `this` in constructor prologues, and update existing checks to distinguish between static context vs. constructor prologue context
> 1. Verify allowed placement of `super()`/`this()` calls via new method `Check.checkSuperInitCalls()`
> 1. Remove/refactor assumptions in several places that `super()`/`this()` was always the first statement
> 
> The changes in `Flow.java` are an example of <span>#</span>4. `Flow.FlowAnalyzer` checks for uncaught checked exceptions. For initializer blocks, this was previously done by requiring that any checked exceptions thrown be declared as thrown by all constructors containing `super()`. This list of checked exceptions was being pre-calculated before recursing into the initial constructors. This worked because initializer blocks were executed at the beginning of each initial constructor right after `super()` is called.
> 
> Now initializer blocks are traversed as each `super()` invocation is encountered, reflecting what actually happens at runtime. Similarly, final fields are marked as DA after encountering `this()`, not automatically at the beginning of those  constructors. These changes produce equivalent checks, but are compatible with the new flexibility of placement of `super()`/`this()` as well as possible future changes that could occur along these same lines.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:

 - Merge branch 'master' into SuperInit
 - Create and cache a single instance of the oft-used SuperThisChecker.
 - Add unit test verifying super() can't appear inside a lambda.
 - Use TreeInfo.isConstructor() for detecting constructors.
 - Merge branch 'master' into SuperInit
 - Fix mistake in previous merge commit 80ba6be4.
 - Merge branch 'master' into SuperInit
 - Rename unit test to be consistent with other feature exampless.
 - Update unit test after merged-in commit eaa80ad08.
 - Add unit tests with local class decl's prior to super().
 - ... and 19 more: https://git.openjdk.org/jdk/compare/4a1fcb60...e2f88137

-------------

Changes: https://git.openjdk.org/jdk/pull/13656/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13656&range=10
  Stats: 1419 lines in 24 files changed: 1149 ins; 165 del; 105 mod
  Patch: https://git.openjdk.org/jdk/pull/13656.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13656/head:pull/13656

PR: https://git.openjdk.org/jdk/pull/13656

From duke at openjdk.org  Tue Jul 11 16:58:28 2023
From: duke at openjdk.org (Jenny Shivayogi)
Date: Tue, 11 Jul 2023 16:58:28 GMT
Subject: RFR: 8311647: Memory leak in
 Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
Message-ID: <bPJ55UJHonMXkM46nDAcScveT8kHuIp_I8F4f3SGfxE=.786f7eb8-97b9-4e67-9f7f-e02d793456d8@github.com>

Allocated data on error path is deleted before return

-------------

Commit messages:
 - deleting allocated data before return

Changes: https://git.openjdk.org/jdk/pull/14832/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14832&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8311647
  Stats: 2 lines in 2 files changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/14832.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14832/head:pull/14832

PR: https://git.openjdk.org/jdk/pull/14832

From phh at openjdk.org  Tue Jul 11 19:57:06 2023
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 11 Jul 2023 19:57:06 GMT
Subject: RFR: 8311647: Memory leak in
 Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
In-Reply-To: <bPJ55UJHonMXkM46nDAcScveT8kHuIp_I8F4f3SGfxE=.786f7eb8-97b9-4e67-9f7f-e02d793456d8@github.com>
References: <bPJ55UJHonMXkM46nDAcScveT8kHuIp_I8F4f3SGfxE=.786f7eb8-97b9-4e67-9f7f-e02d793456d8@github.com>
Message-ID: <wRaP4fimWUHJCYgk0NLyxk4qeiuc9hOEXqeT9ZlMJ6Q=.c9522210-8cfd-4144-a4ad-17ea884f8f9b@github.com>

On Tue, 11 Jul 2023 16:51:15 GMT, Jenny Shivayogi <duke at openjdk.org> wrote:

> Allocated data on error path is deleted before return

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14832#pullrequestreview-1525062075

From shade at openjdk.org  Thu Jul 13 08:44:08 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Thu, 13 Jul 2023 08:44:08 GMT
Subject: RFR: 8311647: Memory leak in
 Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
In-Reply-To: <bPJ55UJHonMXkM46nDAcScveT8kHuIp_I8F4f3SGfxE=.786f7eb8-97b9-4e67-9f7f-e02d793456d8@github.com>
References: <bPJ55UJHonMXkM46nDAcScveT8kHuIp_I8F4f3SGfxE=.786f7eb8-97b9-4e67-9f7f-e02d793456d8@github.com>
Message-ID: <vl6Xq4g6ZaqjWjP27B-QG4GnPEgmlyB7P2xBHbpDOKs=.2085b0e9-9529-4b0c-be98-0a9fd3449f36@github.com>

On Tue, 11 Jul 2023 16:51:15 GMT, Jenny Shivayogi <duke at openjdk.org> wrote:

> Allocated data on error path is deleted before return

Changes requested by shade (Reviewer).

src/jdk.internal.le/linux/native/lible/CLibrary.cpp line 191:

> 189:     if (error != 0) {
> 190:         throw_errno(env);
> 191:         delete[] data;

While JNI would not transfer control immediately on `Throw`, and would only throw it on return, it is a good style to do cleanups first, and then do throw, followed by immediate return.

In other words, flip the order of `delete[]` and `throw_errno`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14832#pullrequestreview-1527918713
PR Review Comment: https://git.openjdk.org/jdk/pull/14832#discussion_r1262223066

From duke at openjdk.org  Thu Jul 13 16:43:14 2023
From: duke at openjdk.org (Jenny Shivayogi)
Date: Thu, 13 Jul 2023 16:43:14 GMT
Subject: RFR: 8311647: Memory leak in
 Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
In-Reply-To: <vl6Xq4g6ZaqjWjP27B-QG4GnPEgmlyB7P2xBHbpDOKs=.2085b0e9-9529-4b0c-be98-0a9fd3449f36@github.com>
References: <bPJ55UJHonMXkM46nDAcScveT8kHuIp_I8F4f3SGfxE=.786f7eb8-97b9-4e67-9f7f-e02d793456d8@github.com>
 <vl6Xq4g6ZaqjWjP27B-QG4GnPEgmlyB7P2xBHbpDOKs=.2085b0e9-9529-4b0c-be98-0a9fd3449f36@github.com>
Message-ID: <yLjKdewq5peF9dHZhqfGabudWEFnMk5zOQearxZkneE=.d9cd4f9a-ff4f-46be-9050-be7ac49a75a7@github.com>

On Thu, 13 Jul 2023 08:40:33 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Allocated data on error path is deleted before return
>
> src/jdk.internal.le/linux/native/lible/CLibrary.cpp line 191:
> 
>> 189:     if (error != 0) {
>> 190:         throw_errno(env);
>> 191:         delete[] data;
> 
> While JNI would not transfer control immediately on `Throw`, and would only throw it on return, it is a good style to do cleanups first, and then do throw, followed by immediate return.
> 
> In other words, flip the order of `delete[]` and `throw_errno`.

oh! got it

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14832#discussion_r1262811609

From duke at openjdk.org  Thu Jul 13 16:53:16 2023
From: duke at openjdk.org (Jenny Shivayogi)
Date: Thu, 13 Jul 2023 16:53:16 GMT
Subject: RFR: 8311647: Memory leak in
 Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
 [v2]
In-Reply-To: <bPJ55UJHonMXkM46nDAcScveT8kHuIp_I8F4f3SGfxE=.786f7eb8-97b9-4e67-9f7f-e02d793456d8@github.com>
References: <bPJ55UJHonMXkM46nDAcScveT8kHuIp_I8F4f3SGfxE=.786f7eb8-97b9-4e67-9f7f-e02d793456d8@github.com>
Message-ID: <MBqO27Ky3sNcqvLxCA8tJx_6r50Wl22ortEpdBzZwxE=.0324473d-333b-406e-924d-5f204c512b92@github.com>

> Allocated data on error path is deleted before return

Jenny Shivayogi has updated the pull request incrementally with one additional commit since the last revision:

  cleanup before throw

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14832/files
  - new: https://git.openjdk.org/jdk/pull/14832/files/e6f52905..80aedc23

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14832&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14832&range=00-01

  Stats: 4 lines in 2 files changed: 2 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/14832.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14832/head:pull/14832

PR: https://git.openjdk.org/jdk/pull/14832

From shade at openjdk.org  Thu Jul 13 16:53:18 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Thu, 13 Jul 2023 16:53:18 GMT
Subject: RFR: 8311647: Memory leak in
 Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
 [v2]
In-Reply-To: <MBqO27Ky3sNcqvLxCA8tJx_6r50Wl22ortEpdBzZwxE=.0324473d-333b-406e-924d-5f204c512b92@github.com>
References: <bPJ55UJHonMXkM46nDAcScveT8kHuIp_I8F4f3SGfxE=.786f7eb8-97b9-4e67-9f7f-e02d793456d8@github.com>
 <MBqO27Ky3sNcqvLxCA8tJx_6r50Wl22ortEpdBzZwxE=.0324473d-333b-406e-924d-5f204c512b92@github.com>
Message-ID: <OKKOWaWN4Pe9jtUiv-0DPQzaBQbYGvdCwdz0E6bu5i0=.0337bc8c-2100-4f8e-84cb-33631546f3bf@github.com>

On Thu, 13 Jul 2023 16:48:29 GMT, Jenny Shivayogi <duke at openjdk.org> wrote:

>> Allocated data on error path is deleted before return
>
> Jenny Shivayogi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   cleanup before throw

Looks fine to me. 
@lahodaj, want to take a look? It is your code :)

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14832#pullrequestreview-1528864405

From jlahoda at openjdk.org  Thu Jul 13 18:09:58 2023
From: jlahoda at openjdk.org (Jan Lahoda)
Date: Thu, 13 Jul 2023 18:09:58 GMT
Subject: RFR: 8311647: Memory leak in
 Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
 [v2]
In-Reply-To: <MBqO27Ky3sNcqvLxCA8tJx_6r50Wl22ortEpdBzZwxE=.0324473d-333b-406e-924d-5f204c512b92@github.com>
References: <bPJ55UJHonMXkM46nDAcScveT8kHuIp_I8F4f3SGfxE=.786f7eb8-97b9-4e67-9f7f-e02d793456d8@github.com>
 <MBqO27Ky3sNcqvLxCA8tJx_6r50Wl22ortEpdBzZwxE=.0324473d-333b-406e-924d-5f204c512b92@github.com>
Message-ID: <FDd7W8MqbnUNg9BMHWbaba_w6u2DqNGh3X1chbcm07k=.4981e646-f67c-4164-b5e3-e502f0344bb4@github.com>

On Thu, 13 Jul 2023 16:53:16 GMT, Jenny Shivayogi <duke at openjdk.org> wrote:

>> Allocated data on error path is deleted before return
>
> Jenny Shivayogi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   cleanup before throw

Looks good to me, thanks!

-------------

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14832#pullrequestreview-1529003658

From shade at openjdk.org  Thu Jul 13 18:50:58 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Thu, 13 Jul 2023 18:50:58 GMT
Subject: RFR: 8311647: Memory leak in
 Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
 [v2]
In-Reply-To: <MBqO27Ky3sNcqvLxCA8tJx_6r50Wl22ortEpdBzZwxE=.0324473d-333b-406e-924d-5f204c512b92@github.com>
References: <bPJ55UJHonMXkM46nDAcScveT8kHuIp_I8F4f3SGfxE=.786f7eb8-97b9-4e67-9f7f-e02d793456d8@github.com>
 <MBqO27Ky3sNcqvLxCA8tJx_6r50Wl22ortEpdBzZwxE=.0324473d-333b-406e-924d-5f204c512b92@github.com>
Message-ID: <b08LEauPRYjDWZ-_kRDx6gJbCZOhPDP2guW_VcHuioY=.5b1e659f-f0ca-4fb7-9740-0c33d27bfc81@github.com>

On Thu, 13 Jul 2023 16:53:16 GMT, Jenny Shivayogi <duke at openjdk.org> wrote:

>> Allocated data on error path is deleted before return
>
> Jenny Shivayogi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   cleanup before throw

Excellent, thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14832#issuecomment-1634730073

From phh at openjdk.org  Thu Jul 13 20:01:04 2023
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 13 Jul 2023 20:01:04 GMT
Subject: RFR: 8311647: Memory leak in
 Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
 [v2]
In-Reply-To: <MBqO27Ky3sNcqvLxCA8tJx_6r50Wl22ortEpdBzZwxE=.0324473d-333b-406e-924d-5f204c512b92@github.com>
References: <bPJ55UJHonMXkM46nDAcScveT8kHuIp_I8F4f3SGfxE=.786f7eb8-97b9-4e67-9f7f-e02d793456d8@github.com>
 <MBqO27Ky3sNcqvLxCA8tJx_6r50Wl22ortEpdBzZwxE=.0324473d-333b-406e-924d-5f204c512b92@github.com>
Message-ID: <KLapIgCb1LwOzWQAWZ40B17fXRTCbfxy5BmmNu1c7WA=.d0aff9d9-9b86-4613-929c-fcb745694bc8@github.com>

On Thu, 13 Jul 2023 16:53:16 GMT, Jenny Shivayogi <duke at openjdk.org> wrote:

>> Allocated data on error path is deleted before return
>
> Jenny Shivayogi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   cleanup before throw

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14832#pullrequestreview-1529156866

From duke at openjdk.org  Thu Jul 13 22:12:12 2023
From: duke at openjdk.org (Jenny Shivayogi)
Date: Thu, 13 Jul 2023 22:12:12 GMT
Subject: Integrated: 8311647: Memory leak in
 Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
In-Reply-To: <bPJ55UJHonMXkM46nDAcScveT8kHuIp_I8F4f3SGfxE=.786f7eb8-97b9-4e67-9f7f-e02d793456d8@github.com>
References: <bPJ55UJHonMXkM46nDAcScveT8kHuIp_I8F4f3SGfxE=.786f7eb8-97b9-4e67-9f7f-e02d793456d8@github.com>
Message-ID: <HDhLOReChixiSBQvROHec9i2HhivWTrabXgzlqWtcd8=.67678ded-8fe8-4c96-a05d-da659fe2dfac@github.com>

On Tue, 11 Jul 2023 16:51:15 GMT, Jenny Shivayogi <duke at openjdk.org> wrote:

> Allocated data on error path is deleted before return

This pull request has now been integrated.

Changeset: 43099a85
Author:    Jenny Shivayogi <kspeeyu at amazon.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/43099a85b16f036666d4e93106d2908ad75f9216
Stats:     2 lines in 2 files changed: 2 ins; 0 del; 0 mod

8311647: Memory leak in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r

Reviewed-by: phh, shade, jlahoda

-------------

PR: https://git.openjdk.org/jdk/pull/14832

From shade at openjdk.org  Fri Jul 14 09:30:32 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Fri, 14 Jul 2023 09:30:32 GMT
Subject: [jdk21] RFR: 8311647: Memory leak in
 Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
Message-ID: <EyhIiZv3_A6F3uD9PJBlo7kp8gIT6PxVUjDu-wU8NE0=.a0902159-0582-4b59-9a01-556d3a1884db@github.com>

Clean backport to fix a memory leak introduced in JDK 21.

-------------

Commit messages:
 - Backport 43099a85b16f036666d4e93106d2908ad75f9216

Changes: https://git.openjdk.org/jdk21/pull/126/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=126&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8311647
  Stats: 2 lines in 2 files changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk21/pull/126.diff
  Fetch: git fetch https://git.openjdk.org/jdk21.git pull/126/head:pull/126

PR: https://git.openjdk.org/jdk21/pull/126

From rriggs at openjdk.org  Fri Jul 14 14:24:17 2023
From: rriggs at openjdk.org (Roger Riggs)
Date: Fri, 14 Jul 2023 14:24:17 GMT
Subject: [jdk21] RFR: 8311647: Memory leak in
 Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
In-Reply-To: <EyhIiZv3_A6F3uD9PJBlo7kp8gIT6PxVUjDu-wU8NE0=.a0902159-0582-4b59-9a01-556d3a1884db@github.com>
References: <EyhIiZv3_A6F3uD9PJBlo7kp8gIT6PxVUjDu-wU8NE0=.a0902159-0582-4b59-9a01-556d3a1884db@github.com>
Message-ID: <wzCyZvBCgl12tEFnjcJGHNO7x7a-7se-i76raNLKqJc=.d2026330-dedb-4cc9-ba29-c7ca6e08a398@github.com>

On Fri, 14 Jul 2023 09:23:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Clean backport to fix a memory leak introduced in JDK 21.

Marked as reviewed by rriggs (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk21/pull/126#pullrequestreview-1530402136

From shade at openjdk.org  Fri Jul 14 14:52:21 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Fri, 14 Jul 2023 14:52:21 GMT
Subject: [jdk21] RFR: 8311647: Memory leak in
 Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
In-Reply-To: <EyhIiZv3_A6F3uD9PJBlo7kp8gIT6PxVUjDu-wU8NE0=.a0902159-0582-4b59-9a01-556d3a1884db@github.com>
References: <EyhIiZv3_A6F3uD9PJBlo7kp8gIT6PxVUjDu-wU8NE0=.a0902159-0582-4b59-9a01-556d3a1884db@github.com>
Message-ID: <hDIoZIqiDWwQzZWA2Ag_J2TnnztlUqGF1BrLw0Jh4wA=.b3ed8ef1-a9d7-4f62-92cb-b070afc2b962@github.com>

On Fri, 14 Jul 2023 09:23:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Clean backport to fix a memory leak introduced in JDK 21.

Thanks! The x86_32 test failure is unrelated.

-------------

PR Comment: https://git.openjdk.org/jdk21/pull/126#issuecomment-1635974924

From shade at openjdk.org  Fri Jul 14 14:52:21 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Fri, 14 Jul 2023 14:52:21 GMT
Subject: [jdk21] Integrated: 8311647: Memory leak in
 Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
In-Reply-To: <EyhIiZv3_A6F3uD9PJBlo7kp8gIT6PxVUjDu-wU8NE0=.a0902159-0582-4b59-9a01-556d3a1884db@github.com>
References: <EyhIiZv3_A6F3uD9PJBlo7kp8gIT6PxVUjDu-wU8NE0=.a0902159-0582-4b59-9a01-556d3a1884db@github.com>
Message-ID: <EckpAEgZ6Vl6zDWnQoYs6i9t-puIOkTbyt3Kv02o2oE=.32cf8682-343c-422f-b9da-4bd78ffd38d9@github.com>

On Fri, 14 Jul 2023 09:23:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Clean backport to fix a memory leak introduced in JDK 21.

This pull request has now been integrated.

Changeset: 49479dbe
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.org/jdk21/commit/49479dbe59ec548e12d811a321848a8af42f6fd2
Stats:     2 lines in 2 files changed: 2 ins; 0 del; 0 mod

8311647: Memory leak in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r

Reviewed-by: rriggs
Backport-of: 43099a85b16f036666d4e93106d2908ad75f9216

-------------

PR: https://git.openjdk.org/jdk21/pull/126

From naoto at openjdk.org  Fri Jul 14 17:16:26 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 14 Jul 2023 17:16:26 GMT
Subject: RFR: 8308591: JLine as the default Console provider
Message-ID: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>

This is to bring the JLine-based Console implementation as the default, which was the initial intention in [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding CSR has also been drafted.

-------------

Commit messages:
 - javadoc cleanup
 - Merge branch 'master' into JDK-8308591-JLine-Console
 - Merge branch 'master' into JDK-8308591-JLine-Console
 - static to instance method
 - isPlatformConsole()
 - Restored stream
 - lazy init
 - Avoid using stream
 - test fix
 - Make jdk.internal.le the default console module

Changes: https://git.openjdk.org/jdk/pull/14271/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14271&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8308591
  Stats: 66 lines in 5 files changed: 51 ins; 6 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/14271.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14271/head:pull/14271

PR: https://git.openjdk.org/jdk/pull/14271

From alanb at openjdk.org  Mon Jul 17 14:20:23 2023
From: alanb at openjdk.org (Alan Bateman)
Date: Mon, 17 Jul 2023 14:20:23 GMT
Subject: RFR: 8308591: JLine as the default Console provider
In-Reply-To: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
References: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
Message-ID: <A1lYvHlwA7uuICs3O0RvRo5wwAx5p_WkL8wImSzNNiE=.c31b6539-9f57-4d4c-b8cb-b8a3d21e0218@github.com>

On Thu, 1 Jun 2023 18:53:21 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This is to bring the JLine-based Console implementation as the default, which was the initial intention in [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding CSR has also been drafted.

This looks quite good. I think Console::isTerminal works as a method name but we might have to iterate a bit on the javadoc to more clearly define it.

For the CSR I think the behavior change to call out is that System::console will return a Console for cases where it didn't previously (at least not by default) and that will be observed by code that assumes non-null means isatty, cue the new method to provide a standard way to test this.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14271#issuecomment-1638243162

From naoto at openjdk.org  Mon Jul 17 17:32:15 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 17 Jul 2023 17:32:15 GMT
Subject: RFR: 8308591: JLine as the default Console provider
In-Reply-To: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
References: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
Message-ID: <0G2kLiQS38oxDf4Kshx3Uylf1x-HfvePVrUVAsT697U=.4879f7d0-a0c7-427c-abb8-8581bcd93838@github.com>

On Thu, 1 Jun 2023 18:53:21 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This is to bring the JLine-based Console implementation as the default, which was the initial intention in [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding CSR has also been drafted.

Thanks, Alan.

> This looks quite good. I think Console::isTerminal works as a method name but we might have to iterate a bit on the javadoc to more clearly define it.
> 

Do you think adding an `implNote` that describes the platform behavior, e.g., on Unix it is equivalent to calling `isatty(stdin/out)` and stdin/out file descriptor are valid character devices on Windows, would help?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14271#issuecomment-1638574326

From naoto at openjdk.org  Mon Jul 17 19:49:04 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 17 Jul 2023 19:49:04 GMT
Subject: RFR: 8308591: JLine as the default Console provider [v2]
In-Reply-To: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
References: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
Message-ID: <bssyqwK9bcS_NGwR7yARx0O4ZC297VxHRiMfDkfwufg=.b68f2de1-3223-44d1-a8b1-2bc9f799f3b1@github.com>

> This is to bring the JLine-based Console implementation as the default, which was the initial intention in [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding CSR has also been drafted.

Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:

 - Refine the method description
 - Merge branch 'master' into JDK-8308591-JLine-Console
 - javadoc cleanup
 - Merge branch 'master' into JDK-8308591-JLine-Console
 - Merge branch 'master' into JDK-8308591-JLine-Console
 - static to instance method
 - isPlatformConsole()
 - Restored stream
 - lazy init
 - Avoid using stream
 - ... and 2 more: https://git.openjdk.org/jdk/compare/0b242322...f6f22d60

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14271/files
  - new: https://git.openjdk.org/jdk/pull/14271/files/057611dc..f6f22d60

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14271&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14271&range=00-01

  Stats: 16701 lines in 558 files changed: 9529 ins; 6446 del; 726 mod
  Patch: https://git.openjdk.org/jdk/pull/14271.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14271/head:pull/14271

PR: https://git.openjdk.org/jdk/pull/14271

From naoto at openjdk.org  Mon Jul 17 19:55:34 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 17 Jul 2023 19:55:34 GMT
Subject: RFR: 8308591: JLine as the default Console provider [v3]
In-Reply-To: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
References: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
Message-ID: <3p8zJJNsU2YORzBfIpcC88ChpuA3ZvSS-OE4fEqh9YI=.eb0255e0-ddcb-4ba5-a783-b333a5f81fc4@github.com>

> This is to bring the JLine-based Console implementation as the default, which was the initial intention in [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding CSR has also been drafted.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  minor doc fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14271/files
  - new: https://git.openjdk.org/jdk/pull/14271/files/f6f22d60..b2a664ff

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14271&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14271&range=01-02

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/14271.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14271/head:pull/14271

PR: https://git.openjdk.org/jdk/pull/14271

From naoto at openjdk.org  Mon Jul 17 19:58:00 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 17 Jul 2023 19:58:00 GMT
Subject: RFR: 8308591: JLine as the default Console provider [v4]
In-Reply-To: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
References: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
Message-ID: <yWsfMA40jepE3oiQFkxPdcjceQLwpo_PoyPZdEtBkJg=.03468746-c2e1-483c-a928-246b298fc86b@github.com>

> This is to bring the JLine-based Console implementation as the default, which was the initial intention in [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding CSR has also been drafted.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  Unix -> POSIX

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14271/files
  - new: https://git.openjdk.org/jdk/pull/14271/files/b2a664ff..a6512a37

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14271&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14271&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/14271.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14271/head:pull/14271

PR: https://git.openjdk.org/jdk/pull/14271

From naoto at openjdk.org  Mon Jul 17 20:46:32 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 17 Jul 2023 20:46:32 GMT
Subject: RFR: 8308591: JLine as the default Console provider [v5]
In-Reply-To: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
References: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
Message-ID: <UaaPqwRl0njNVVWBohl1gngkiA1q0L5P4Oum8fyi9rI=.a0c698bc-ef05-4f81-bd9c-d2cd7a3bc19c@github.com>

> This is to bring the JLine-based Console implementation as the default, which was the initial intention in [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding CSR has also been drafted.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  `true`

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14271/files
  - new: https://git.openjdk.org/jdk/pull/14271/files/a6512a37..df5805a0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14271&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14271&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/14271.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14271/head:pull/14271

PR: https://git.openjdk.org/jdk/pull/14271

From alanb at openjdk.org  Tue Jul 18 15:25:05 2023
From: alanb at openjdk.org (Alan Bateman)
Date: Tue, 18 Jul 2023 15:25:05 GMT
Subject: RFR: 8308591: JLine as the default Console provider [v5]
In-Reply-To: <UaaPqwRl0njNVVWBohl1gngkiA1q0L5P4Oum8fyi9rI=.a0c698bc-ef05-4f81-bd9c-d2cd7a3bc19c@github.com>
References: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
 <UaaPqwRl0njNVVWBohl1gngkiA1q0L5P4Oum8fyi9rI=.a0c698bc-ef05-4f81-bd9c-d2cd7a3bc19c@github.com>
Message-ID: <dMJkxEjF1vu7tYMzfutc2_bhSVIgEa8Tb-Iy1vPYQZI=.ba2e7a93-1a9e-4a1d-89b7-d97f201b654d@github.com>

On Mon, 17 Jul 2023 20:46:32 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> This is to bring the JLine-based Console implementation as the default, which was the initial intention in [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   `true`

src/java.base/share/classes/java/io/Console.java line 354:

> 352:      * character devices are available to the {@code Console}. Otherwise it could
> 353:      * mean that the implementation of the {@code Console} may simulate those
> 354:      * devices within.

The implNote helps as this is a difficult method to specify in a platform independent way.

The class description uses "interactive command line" and  "will typically be connected to the keyboard and display" and maybe we could re-use that here. Here's a suggestion for the second paragraph:

"This method returns true if the console device, associated with the current Java virtual machine, is a terminal, typically an interactive command line connected to a keyboard and display."

I don't have any other comments on the implementation changes, they look fine.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14271#discussion_r1266938060

From naoto at openjdk.org  Tue Jul 18 17:08:34 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 18 Jul 2023 17:08:34 GMT
Subject: RFR: 8308591: JLine as the default Console provider [v6]
In-Reply-To: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
References: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
Message-ID: <E5aVsPvQsvoVLVhAUuaZyyHbu33OuWkplpP8SfresH0=.034792a1-0c6a-46c9-9a4c-cda96b8f0e3c@github.com>

> This is to bring the JLine-based Console implementation as the default, which was the initial intention in [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding CSR has also been drafted.

Naoto Sato has updated the pull request incrementally with two additional commits since the last revision:

 - @code
 - Reworded the second paragraph of the method description

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14271/files
  - new: https://git.openjdk.org/jdk/pull/14271/files/df5805a0..7065f3a5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14271&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14271&range=04-05

  Stats: 5 lines in 1 file changed: 0 ins; 2 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/14271.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14271/head:pull/14271

PR: https://git.openjdk.org/jdk/pull/14271

From naoto at openjdk.org  Tue Jul 18 17:09:05 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 18 Jul 2023 17:09:05 GMT
Subject: RFR: 8308591: JLine as the default Console provider [v5]
In-Reply-To: <dMJkxEjF1vu7tYMzfutc2_bhSVIgEa8Tb-Iy1vPYQZI=.ba2e7a93-1a9e-4a1d-89b7-d97f201b654d@github.com>
References: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
 <UaaPqwRl0njNVVWBohl1gngkiA1q0L5P4Oum8fyi9rI=.a0c698bc-ef05-4f81-bd9c-d2cd7a3bc19c@github.com>
 <dMJkxEjF1vu7tYMzfutc2_bhSVIgEa8Tb-Iy1vPYQZI=.ba2e7a93-1a9e-4a1d-89b7-d97f201b654d@github.com>
Message-ID: <b7PiLDr4ZN-oM0ZkXplibEDh9mnho1YG3n8S5X2_QvU=.0a22d422-e519-4db3-8c42-3dae40a9f3ad@github.com>

On Tue, 18 Jul 2023 15:21:50 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   `true`
>
> src/java.base/share/classes/java/io/Console.java line 354:
> 
>> 352:      * character devices are available to the {@code Console}. Otherwise it could
>> 353:      * mean that the implementation of the {@code Console} may simulate those
>> 354:      * devices within.
> 
> The implNote helps as this is a difficult method to specify in a platform independent way.
> 
> The class description uses "interactive command line" and  "will typically be connected to the keyboard and display" and maybe we could re-use that here. Here's a suggestion for the second paragraph:
> 
> "This method returns true if the console device, associated with the current Java virtual machine, is a terminal, typically an interactive command line connected to a keyboard and display."
> 
> I don't have any other comments on the implementation changes, they look fine.

Thanks. Replaced the second paragraph with your suggested sentence.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14271#discussion_r1267070257

From alanb at openjdk.org  Tue Jul 18 17:36:37 2023
From: alanb at openjdk.org (Alan Bateman)
Date: Tue, 18 Jul 2023 17:36:37 GMT
Subject: RFR: 8308591: JLine as the default Console provider [v6]
In-Reply-To: <E5aVsPvQsvoVLVhAUuaZyyHbu33OuWkplpP8SfresH0=.034792a1-0c6a-46c9-9a4c-cda96b8f0e3c@github.com>
References: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
 <E5aVsPvQsvoVLVhAUuaZyyHbu33OuWkplpP8SfresH0=.034792a1-0c6a-46c9-9a4c-cda96b8f0e3c@github.com>
Message-ID: <mz88jojez5Myj2hctA-hQIQWw8Ydl_LhVzpPfC1OYho=.60c0cd9f-2050-40d4-8b18-eb9ab78f68f4@github.com>

On Tue, 18 Jul 2023 17:08:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> This is to bring the JLine-based Console implementation as the default, which was the initial intention in [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - @code
>  - Reworded the second paragraph of the method description

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14271#pullrequestreview-1535589025

From naoto at openjdk.org  Thu Jul 20 16:13:47 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Thu, 20 Jul 2023 16:13:47 GMT
Subject: Integrated: 8308591: JLine as the default Console provider
In-Reply-To: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
References: <dgxfbS2VBBpNAUslrJJZkZNjfrGPGQKiqkJxlWL45C4=.953b8a65-4d16-4d20-b870-2e83e385e010@github.com>
Message-ID: <AgiSJogqoapJ1KcSKJimIXhU9mancqFp1Y7Y3wsOl0g=.68ef9e3f-8fe1-4dc2-ad65-f5ee0ef6a0a8@github.com>

On Thu, 1 Jun 2023 18:53:21 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> This is to bring the JLine-based Console implementation as the default, which was the initial intention in [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding CSR has also been drafted.

This pull request has now been integrated.

Changeset: bae22479
Author:    Naoto Sato <naoto at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/bae224793812cb0a0aa67e399062498d3b13fdb3
Stats:     68 lines in 5 files changed: 53 ins; 6 del; 9 mod

8308591: JLine as the default Console provider

Reviewed-by: alanb

-------------

PR: https://git.openjdk.org/jdk/pull/14271

From stuefe at openjdk.org  Tue Jul 25 14:39:00 2023
From: stuefe at openjdk.org (Thomas Stuefe)
Date: Tue, 25 Jul 2023 14:39:00 GMT
Subject: RFR: JDK-8308627: JDK-8306983 breaks Alpine
In-Reply-To: <6pj_k-DpdXLUaVZQZ8pRlTZ4KtrwCRyt0BfY7rnNFMQ=.5e0c19d6-34e6-4321-89cc-5c3d7d36a044@github.com>
References: <6pj_k-DpdXLUaVZQZ8pRlTZ4KtrwCRyt0BfY7rnNFMQ=.5e0c19d6-34e6-4321-89cc-5c3d7d36a044@github.com>
Message-ID: <HUijez1pefPxE-WIH9lXMm3lzd8KG2u7uibfDRVpf3A=.82db9b61-b048-4a60-bce1-8b63ce483e2c@github.com>

On Tue, 23 May 2023 08:59:02 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Trivial fix to get Alpine to build again after https://bugs.openjdk.org/browse/JDK-8306983

Duplicate. https://github.com/openjdk/jdk/pull/14080

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14097#issuecomment-1558981267

From stuefe at openjdk.org  Tue Jul 25 14:39:02 2023
From: stuefe at openjdk.org (Thomas Stuefe)
Date: Tue, 25 Jul 2023 14:39:02 GMT
Subject: Withdrawn: JDK-8308627: JDK-8306983 breaks Alpine
In-Reply-To: <6pj_k-DpdXLUaVZQZ8pRlTZ4KtrwCRyt0BfY7rnNFMQ=.5e0c19d6-34e6-4321-89cc-5c3d7d36a044@github.com>
References: <6pj_k-DpdXLUaVZQZ8pRlTZ4KtrwCRyt0BfY7rnNFMQ=.5e0c19d6-34e6-4321-89cc-5c3d7d36a044@github.com>
Message-ID: <RpZkIBVXnqlFNUNnaLv5mxzcmv4aZbfXHVjCntZf028=.9b38f130-00bf-4ce9-9c55-35fefded91d2@github.com>

On Tue, 23 May 2023 08:59:02 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Trivial fix to get Alpine to build again after https://bugs.openjdk.org/browse/JDK-8306983

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/14097

From vromero at openjdk.org  Tue Jul 25 20:13:45 2023
From: vromero at openjdk.org (Vicente Romero)
Date: Tue, 25 Jul 2023 20:13:45 GMT
Subject: RFR: 8194743: Compiler implementation for Statements before
 super() [v11]
In-Reply-To: <RkivlLM6SydVKh0l8QNsytGjsBq19Cur-N1Mds2YMpY=.5c00bdc7-1461-4e57-af92-715db1c1c8d2@github.com>
References: <NOF-YbVLoOgUEvt-pWZVkbKkLnkSH-9ek3IGUb7JBfo=.a6db8599-7c2b-4534-aeb2-1d5d67c9cc57@github.com>
 <RkivlLM6SydVKh0l8QNsytGjsBq19Cur-N1Mds2YMpY=.5c00bdc7-1461-4e57-af92-715db1c1c8d2@github.com>
Message-ID: <UNWy6unlW-QI1MnS31lizxTYWwdZQrhZ5UNsXxBZvWc=.bc959b25-1a6e-4fdd-9776-18f59fe537c8@github.com>

On Sat, 8 Jul 2023 15:46:07 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> This is a first draft of a patch for JEP 447.
>> 
>> Summary of changes:
>> 
>> 1. Track when we're within a constructor "prologue" via new flag `AttrContext.ctorPrologue`
>> 1. Add checks for illegal early access to `this` in constructor prologues, and update existing checks to distinguish between static context vs. constructor prologue context
>> 1. Verify allowed placement of `super()`/`this()` calls via new method `Check.checkSuperInitCalls()`
>> 1. Remove/refactor assumptions in several places that `super()`/`this()` was always the first statement
>> 
>> The changes in `Flow.java` are an example of <span>#</span>4. `Flow.FlowAnalyzer` checks for uncaught checked exceptions. For initializer blocks, this was previously done by requiring that any checked exceptions thrown be declared as thrown by all constructors containing `super()`. This list of checked exceptions was being pre-calculated before recursing into the initial constructors. This worked because initializer blocks were executed at the beginning of each initial constructor right after `super()` is called.
>> 
>> Now initializer blocks are traversed as each `super()` invocation is encountered, reflecting what actually happens at runtime. Similarly, final fields are marked as DA after encountering `this()`, not automatically at the beginning of those  constructors. These changes produce equivalent checks, but are compatible with the new flexibility of placement of `super()`/`this()` as well as possible future changes that could occur along these same lines.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:
> 
>  - Merge branch 'master' into SuperInit
>  - Create and cache a single instance of the oft-used SuperThisChecker.
>  - Add unit test verifying super() can't appear inside a lambda.
>  - Use TreeInfo.isConstructor() for detecting constructors.
>  - Merge branch 'master' into SuperInit
>  - Fix mistake in previous merge commit 80ba6be4.
>  - Merge branch 'master' into SuperInit
>  - Rename unit test to be consistent with other feature exampless.
>  - Update unit test after merged-in commit eaa80ad08.
>  - Add unit tests with local class decl's prior to super().
>  - ... and 19 more: https://git.openjdk.org/jdk/compare/4a1fcb60...e2f88137

looks good to me

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13656#pullrequestreview-1546376641

From jlu at openjdk.org  Wed Jul 26 20:47:11 2023
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 26 Jul 2023 20:47:11 GMT
Subject: RFR: 8312572: JDK 21 RDP2 L10n resource files update
Message-ID: <vXCU3IuIfquN7Fg7NzHZpC388vtyF_sbqgRWQrmKqVU=.2aef82f2-f476-4d9e-9f6e-68c13f1e151a@github.com>

Please review this PR which contains the IPS translations for updates to localized resources in the JDK since RDP1.

Included in this change are improved translations for certain values, which also includes global updates for translations of the words 'annotation' and 'file' for zh_CN.

The following files contain key/value resources that were added, updated, or removed in the original file. (This means that the localized versions of these files contain changes to translations that are a reflection of the original key/value changing, and are not just improved translations).

- src/java.base/share/classes/sun/launcher/resources/launcher.properties
- src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
- src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties
- src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resources/jdeps.properties
- src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties
- src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties

It is recommended to view the changes in UTF-8 native at https://cr.openjdk.org/~jlu/RDP2_Diffs/.

-------------

Commit messages:
 - Revert zh_CN translation of 'private' for consistency
 - Revert IPS newline changes to MsiInstallerStrings_en.wxl
 - Move CurrencyNames_xx.properties to jdk.localedata (no changes)
 - Remove extra quotes in 'main.usage' values in jdeprscan
 - Revert WinResources changing of 'resource.wxl-file-name' value
 - Standardize trailing WS in l10n.properties
 - Revert MsiInstallerStrings culture value changes
 - Apply WS Tool
 - Apply IPS translations

Changes: https://git.openjdk.org/jdk/pull/15047/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15047&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8312572
  Stats: 223 lines in 32 files changed: 36 ins; 15 del; 172 mod
  Patch: https://git.openjdk.org/jdk/pull/15047.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15047/head:pull/15047

PR: https://git.openjdk.org/jdk/pull/15047

From dnguyen at openjdk.org  Thu Jul 27 00:24:42 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 27 Jul 2023 00:24:42 GMT
Subject: RFR: 8312572: JDK 21 RDP2 L10n resource files update
In-Reply-To: <vXCU3IuIfquN7Fg7NzHZpC388vtyF_sbqgRWQrmKqVU=.2aef82f2-f476-4d9e-9f6e-68c13f1e151a@github.com>
References: <vXCU3IuIfquN7Fg7NzHZpC388vtyF_sbqgRWQrmKqVU=.2aef82f2-f476-4d9e-9f6e-68c13f1e151a@github.com>
Message-ID: <-EvTASKrIweBzLE7uRXAtnLmG4XXp5oN4Q6Qq4ETm3M=.37d25be2-2296-499e-a925-7ab24be4e99e@github.com>

On Wed, 26 Jul 2023 20:41:36 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which contains the translations for updates to localized resources in the JDK since RDP1.
> 
> Included in this change are improved translations for certain values, which also includes global updates for translations of the words 'annotation' and 'file' for zh_CN.
> 
> The following files contain key/value resources that were added, updated, or removed in the original file. (This means that the localized versions of these files contain changes to translations that are a reflection of the original key/value changing, and are not just improved translations).
> 
> - src/java.base/share/classes/sun/launcher/resources/launcher.properties
> - src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
> - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties
> - src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resources/jdeps.properties
> - src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties
> - src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties
> 
> It is recommended to view the changes in UTF-8 native at https://cr.openjdk.org/~jlu/RDP2_Diffs/.

src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n.properties line 185:

> 183: jshell.console.no.javadoc = <no documentation found>
> 184: jshell.console.do.nothing = Do nothing
> 185: jshell.console.choice = Choice:\u0020

I see this backslash is also being removed. It does seem misplaced since none of the other lines use it. But just double checking with you that this is the desired change because for the other locales, the change was to just translate the space to unicode.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15047#discussion_r1275600311

From jlu at openjdk.org  Thu Jul 27 06:51:48 2023
From: jlu at openjdk.org (Justin Lu)
Date: Thu, 27 Jul 2023 06:51:48 GMT
Subject: RFR: 8312572: JDK 21 RDP2 L10n resource files update
In-Reply-To: <-EvTASKrIweBzLE7uRXAtnLmG4XXp5oN4Q6Qq4ETm3M=.37d25be2-2296-499e-a925-7ab24be4e99e@github.com>
References: <vXCU3IuIfquN7Fg7NzHZpC388vtyF_sbqgRWQrmKqVU=.2aef82f2-f476-4d9e-9f6e-68c13f1e151a@github.com>
 <-EvTASKrIweBzLE7uRXAtnLmG4XXp5oN4Q6Qq4ETm3M=.37d25be2-2296-499e-a925-7ab24be4e99e@github.com>
Message-ID: <BTGa-RsKKoRdt_7wbgU_LRoenJQtW_bLV1ifxXxrFY4=.08d867b7-6363-4b1f-9e07-d886e075cdd6@github.com>

On Thu, 27 Jul 2023 00:16:34 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Please review this PR which contains the translations for updates to localized resources in the JDK since RDP1.
>> 
>> Included in this change are improved translations for certain values, which also includes global updates for translations of the words 'annotation' and 'file' for zh_CN.
>> 
>> The following files contain key/value resources that were added, updated, or removed in the original file. (This means that the localized versions of these files contain changes to translations that are a reflection of the original key/value changing, and are not just improved translations).
>> 
>> - src/java.base/share/classes/sun/launcher/resources/launcher.properties
>> - src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
>> - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties
>> - src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resources/jdeps.properties
>> - src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties
>> - src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties
>> 
>> It is recommended to view the changes in UTF-8 native at https://cr.openjdk.org/~jlu/RDP2_Diffs/.
>
> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n.properties line 185:
> 
>> 183: jshell.console.no.javadoc = <no documentation found>
>> 184: jshell.console.do.nothing = Do nothing
>> 185: jshell.console.choice = Choice:\u0020
> 
> I see this backslash is also being removed. It does seem misplaced since none of the other lines use it. But just double checking with you that this is the desired change because for the other locales, the change was to just translate the space to unicode.

Thanks for reviewing Damon, the `` is used to signify the white space after the `:` is intentional. However, using a trailing `\u0020` is more intentional and clear, and allows for consistency between the original and localized versions, so I manually made this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15047#discussion_r1275806234

From dnguyen at openjdk.org  Thu Jul 27 16:55:51 2023
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 27 Jul 2023 16:55:51 GMT
Subject: RFR: 8312572: JDK 21 RDP2 L10n resource files update
In-Reply-To: <BTGa-RsKKoRdt_7wbgU_LRoenJQtW_bLV1ifxXxrFY4=.08d867b7-6363-4b1f-9e07-d886e075cdd6@github.com>
References: <vXCU3IuIfquN7Fg7NzHZpC388vtyF_sbqgRWQrmKqVU=.2aef82f2-f476-4d9e-9f6e-68c13f1e151a@github.com>
 <-EvTASKrIweBzLE7uRXAtnLmG4XXp5oN4Q6Qq4ETm3M=.37d25be2-2296-499e-a925-7ab24be4e99e@github.com>
 <BTGa-RsKKoRdt_7wbgU_LRoenJQtW_bLV1ifxXxrFY4=.08d867b7-6363-4b1f-9e07-d886e075cdd6@github.com>
Message-ID: <UOrz91rra5bod31BzvAbODUb2nlHlqYxe_lqWX4cPHs=.edffbff6-f814-4f57-9eaa-089cf59f841a@github.com>

On Thu, 27 Jul 2023 06:48:32 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n.properties line 185:
>> 
>>> 183: jshell.console.no.javadoc = <no documentation found>
>>> 184: jshell.console.do.nothing = Do nothing
>>> 185: jshell.console.choice = Choice:\u0020
>> 
>> I see this backslash is also being removed. It does seem misplaced since none of the other lines use it. But just double checking with you that this is the desired change because for the other locales, the change was to just translate the space to unicode.
>
> Thanks for reviewing Damon, the `` is used to signify the white space after the `:` is intentional. However, using a trailing `\u0020` is more intentional and clear, and allows for consistency between the original and localized versions, so I manually made this change.

Sure, I agree. Just checking to see if this was a product of the translation tool used, because if so, this might've been a mistake or issue with the tool. Looks fine here then

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15047#discussion_r1276566404

From naoto at openjdk.org  Thu Jul 27 17:59:40 2023
From: naoto at openjdk.org (Naoto Sato)
Date: Thu, 27 Jul 2023 17:59:40 GMT
Subject: RFR: 8312572: JDK 21 RDP2 L10n resource files update
In-Reply-To: <vXCU3IuIfquN7Fg7NzHZpC388vtyF_sbqgRWQrmKqVU=.2aef82f2-f476-4d9e-9f6e-68c13f1e151a@github.com>
References: <vXCU3IuIfquN7Fg7NzHZpC388vtyF_sbqgRWQrmKqVU=.2aef82f2-f476-4d9e-9f6e-68c13f1e151a@github.com>
Message-ID: <_lkKzTNMcBXmMJ12xdYHuY7huc4G4sM7nPdN6ZtmrOk=.7b163449-bf71-4f74-a0aa-3881f0645dec@github.com>

On Wed, 26 Jul 2023 20:41:36 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which contains the translations for updates to localized resources in the JDK since RDP1.
> 
> Included in this change are improved translations for certain values, which also includes global updates for translations of the words 'annotation' and 'file' for zh_CN.
> 
> The following files contain key/value resources that were added, updated, or removed in the original file. (This means that the localized versions of these files contain changes to translations that are a reflection of the original key/value changing, and are not just improved translations).
> 
> - src/java.base/share/classes/sun/launcher/resources/launcher.properties
> - src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
> - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties
> - src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resources/jdeps.properties
> - src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties
> - src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties
> 
> It is recommended to view the changes in UTF-8 native at https://cr.openjdk.org/~jlu/RDP2_Diffs/.

Haven't looked at each translation, but good to me overall.

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15047#pullrequestreview-1550448645

From dholmes at openjdk.org  Mon Jul 31 08:39:02 2023
From: dholmes at openjdk.org (David Holmes)
Date: Mon, 31 Jul 2023 08:39:02 GMT
Subject: [jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC
Message-ID: <yYCsVWqbTRBVViIaRDn3RgaLKIaBvDgJiFUc0hfV0MI=.bb51767b-b678-465e-ae28-0af1b21c289b@github.com>

Main changes are to use 21 instead of 21-ea. In addition the following files contain additional updates from the closed sources:

- src/java.base/share/man/java.1

 [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion
 [JDK-8221633](https://bugs.openjdk.org/browse/JDK-8221633): StartFlightRecording: consider moving mention of multiple comma-separated parameters to the front

There are also some formatting differences related to:

 [JDK-8309670](https://bugs.openjdk.org/browse/JDK-8309670): java -help output for --module-path / -p is incomplete

Likely a different version of pandoc was used.

- src/java.base/share/man/keytool.1

 [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage contains a special character

- src/jdk.compiler/share/man/javac.1

 [JDK-8308456](https://bugs.openjdk.org/browse/JDK-8308456): Update javac tool page for -proc:full

also some formatting differences.

- src/jdk.jartool/share/man/jarsigner.1

 [JDK-8303928](https://bugs.openjdk.org/browse/JDK-8303928): Update jarsigner man page after [JDK-8303410](https://bugs.openjdk.org/browse/JDK-8303410)

- src/jdk.jcmd/share/man/jcmd.1

 [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion

- src/jdk.jdeps/share/man/jdeps.1

 [JDK-8301207](https://bugs.openjdk.org/browse/JDK-8301207): (jdeps) Deprecate jdeps -profile option

- src/jdk.jfr/share/man/jfr.1

Formatting changes.

- src/jdk.jshell/share/man/jshell.1

 [JDK-8308988](https://bugs.openjdk.org/browse/JDK-8308988): Update JShell manpage to include TOOLING description

-------------

Commit messages:
 - 8300937: Update nroff pages in JDK 21 before RC

Changes: https://git.openjdk.org/jdk21/pull/151/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=151&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8300937
  Stats: 163 lines in 28 files changed: 37 ins; 60 del; 66 mod
  Patch: https://git.openjdk.org/jdk21/pull/151.diff
  Fetch: git fetch https://git.openjdk.org/jdk21.git pull/151/head:pull/151

PR: https://git.openjdk.org/jdk21/pull/151

From dfuchs at openjdk.org  Mon Jul 31 14:24:57 2023
From: dfuchs at openjdk.org (Daniel Fuchs)
Date: Mon, 31 Jul 2023 14:24:57 GMT
Subject: [jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC
In-Reply-To: <yYCsVWqbTRBVViIaRDn3RgaLKIaBvDgJiFUc0hfV0MI=.bb51767b-b678-465e-ae28-0af1b21c289b@github.com>
References: <yYCsVWqbTRBVViIaRDn3RgaLKIaBvDgJiFUc0hfV0MI=.bb51767b-b678-465e-ae28-0af1b21c289b@github.com>
Message-ID: <ZCnxqhxOMB5j9kYy7elrAETowcCKkK5EtGoxN0qhzjU=.7bc683d4-e058-4217-8977-ee839554aca4@github.com>

On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Main changes are to use 21 instead of 21-ea. In addition the following files contain additional updates from the closed sources:
> 
> - src/java.base/share/man/java.1
> 
>  [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion
>  [JDK-8221633](https://bugs.openjdk.org/browse/JDK-8221633): StartFlightRecording: consider moving mention of multiple comma-separated parameters to the front
> 
> There are also some formatting differences related to:
> 
>  [JDK-8309670](https://bugs.openjdk.org/browse/JDK-8309670): java -help output for --module-path / -p is incomplete
> 
> Likely a different version of pandoc was used.
> 
> - src/java.base/share/man/keytool.1
> 
>  [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage contains a special character
> 
> - src/jdk.compiler/share/man/javac.1
> 
>  [JDK-8308456](https://bugs.openjdk.org/browse/JDK-8308456): Update javac tool page for -proc:full
> 
> also some formatting differences.
> 
> - src/jdk.jartool/share/man/jarsigner.1
> 
>  [JDK-8303928](https://bugs.openjdk.org/browse/JDK-8303928): Update jarsigner man page after [JDK-8303410](https://bugs.openjdk.org/browse/JDK-8303410)
> 
> - src/jdk.jcmd/share/man/jcmd.1
> 
>  [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion
> 
> - src/jdk.jdeps/share/man/jdeps.1
> 
>  [JDK-8301207](https://bugs.openjdk.org/browse/JDK-8301207): (jdeps) Deprecate jdeps -profile option
> 
> - src/jdk.jfr/share/man/jfr.1
> 
> Formatting changes.
> 
> - src/jdk.jshell/share/man/jshell.1
> 
>  [JDK-8308988](https://bugs.openjdk.org/browse/JDK-8308988): Update JShell manpage to include TOOLING description

Changes to jwebserver.1 look good to me.

-------------

PR Comment: https://git.openjdk.org/jdk21/pull/151#issuecomment-1658469731

From mchung at openjdk.org  Mon Jul 31 16:48:58 2023
From: mchung at openjdk.org (Mandy Chung)
Date: Mon, 31 Jul 2023 16:48:58 GMT
Subject: [jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC
In-Reply-To: <yYCsVWqbTRBVViIaRDn3RgaLKIaBvDgJiFUc0hfV0MI=.bb51767b-b678-465e-ae28-0af1b21c289b@github.com>
References: <yYCsVWqbTRBVViIaRDn3RgaLKIaBvDgJiFUc0hfV0MI=.bb51767b-b678-465e-ae28-0af1b21c289b@github.com>
Message-ID: <Ka8_23z0VV93yF6loJ1RvpM37WznPRDQnonXsQVtUvc=.e6b134fc-7ada-4a2e-aeff-5dc02b8f956a@github.com>

On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Main changes are to use 21 instead of 21-ea. In addition the following files contain additional updates from the closed sources:
> 
> - src/java.base/share/man/java.1
> 
>  [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion
>  [JDK-8221633](https://bugs.openjdk.org/browse/JDK-8221633): StartFlightRecording: consider moving mention of multiple comma-separated parameters to the front
> 
> There are also some formatting differences related to:
> 
>  [JDK-8309670](https://bugs.openjdk.org/browse/JDK-8309670): java -help output for --module-path / -p is incomplete
> 
> Likely a different version of pandoc was used.
> 
> - src/java.base/share/man/keytool.1
> 
>  [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage contains a special character
> 
> - src/jdk.compiler/share/man/javac.1
> 
>  [JDK-8308456](https://bugs.openjdk.org/browse/JDK-8308456): Update javac tool page for -proc:full
> 
> also some formatting differences.
> 
> - src/jdk.jartool/share/man/jarsigner.1
> 
>  [JDK-8303928](https://bugs.openjdk.org/browse/JDK-8303928): Update jarsigner man page after [JDK-8303410](https://bugs.openjdk.org/browse/JDK-8303410)
> 
> - src/jdk.jcmd/share/man/jcmd.1
> 
>  [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion
> 
> - src/jdk.jdeps/share/man/jdeps.1
> 
>  [JDK-8301207](https://bugs.openjdk.org/browse/JDK-8301207): (jdeps) Deprecate jdeps -profile option
> 
> - src/jdk.jfr/share/man/jfr.1
> 
> Formatting changes.
> 
> - src/jdk.jshell/share/man/jshell.1
> 
>  [JDK-8308988](https://bugs.openjdk.org/browse/JDK-8308988): Update JShell manpage to include TOOLING description

Changes in java and jdeps are good.

-------------

Marked as reviewed by mchung (Reviewer).

PR Review: https://git.openjdk.org/jdk21/pull/151#pullrequestreview-1555334390

From iris at openjdk.org  Mon Jul 31 17:02:58 2023
From: iris at openjdk.org (Iris Clark)
Date: Mon, 31 Jul 2023 17:02:58 GMT
Subject: [jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC
In-Reply-To: <yYCsVWqbTRBVViIaRDn3RgaLKIaBvDgJiFUc0hfV0MI=.bb51767b-b678-465e-ae28-0af1b21c289b@github.com>
References: <yYCsVWqbTRBVViIaRDn3RgaLKIaBvDgJiFUc0hfV0MI=.bb51767b-b678-465e-ae28-0af1b21c289b@github.com>
Message-ID: <IDTZVPoehnNAcfQAtY7KWm0s1jo7RMzhdttwdxoH6vI=.00094ef1-8a19-4884-b3f4-cd8ffb3e40e9@github.com>

On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Main changes are to use 21 instead of 21-ea. In addition the following files contain additional updates from the closed sources:
> 
> - src/java.base/share/man/java.1
> 
>  [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion
>  [JDK-8221633](https://bugs.openjdk.org/browse/JDK-8221633): StartFlightRecording: consider moving mention of multiple comma-separated parameters to the front
> 
> There are also some formatting differences related to:
> 
>  [JDK-8309670](https://bugs.openjdk.org/browse/JDK-8309670): java -help output for --module-path / -p is incomplete
> 
> Likely a different version of pandoc was used.
> 
> - src/java.base/share/man/keytool.1
> 
>  [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage contains a special character
> 
> - src/jdk.compiler/share/man/javac.1
> 
>  [JDK-8308456](https://bugs.openjdk.org/browse/JDK-8308456): Update javac tool page for -proc:full
> 
> also some formatting differences.
> 
> - src/jdk.jartool/share/man/jarsigner.1
> 
>  [JDK-8303928](https://bugs.openjdk.org/browse/JDK-8303928): Update jarsigner man page after [JDK-8303410](https://bugs.openjdk.org/browse/JDK-8303410)
> 
> - src/jdk.jcmd/share/man/jcmd.1
> 
>  [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion
> 
> - src/jdk.jdeps/share/man/jdeps.1
> 
>  [JDK-8301207](https://bugs.openjdk.org/browse/JDK-8301207): (jdeps) Deprecate jdeps -profile option
> 
> - src/jdk.jfr/share/man/jfr.1
> 
> Formatting changes.
> 
> - src/jdk.jshell/share/man/jshell.1
> 
>  [JDK-8308988](https://bugs.openjdk.org/browse/JDK-8308988): Update JShell manpage to include TOOLING description

Looks good.

The flow changes are unfortunate, but a tool update has the potential to have far more wide-spread changes.  I'm happy that's all there was.

-------------

Marked as reviewed by iris (Reviewer).

PR Review: https://git.openjdk.org/jdk21/pull/151#pullrequestreview-1555365638

From egahlin at openjdk.org  Mon Jul 31 18:51:50 2023
From: egahlin at openjdk.org (Erik Gahlin)
Date: Mon, 31 Jul 2023 18:51:50 GMT
Subject: [jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC
In-Reply-To: <yYCsVWqbTRBVViIaRDn3RgaLKIaBvDgJiFUc0hfV0MI=.bb51767b-b678-465e-ae28-0af1b21c289b@github.com>
References: <yYCsVWqbTRBVViIaRDn3RgaLKIaBvDgJiFUc0hfV0MI=.bb51767b-b678-465e-ae28-0af1b21c289b@github.com>
Message-ID: <9NqTSNFI28Ew52fVBR40-QdAioWNizm9lnuMHr8hVoo=.0f709ec1-8ec2-4e6e-a30c-f69f2026200b@github.com>

On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Main changes are to use 21 instead of 21-ea. In addition the following files contain additional updates from the closed sources:
> 
> - src/java.base/share/man/java.1
> 
>  [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion
>  [JDK-8221633](https://bugs.openjdk.org/browse/JDK-8221633): StartFlightRecording: consider moving mention of multiple comma-separated parameters to the front
> 
> There are also some formatting differences related to:
> 
>  [JDK-8309670](https://bugs.openjdk.org/browse/JDK-8309670): java -help output for --module-path / -p is incomplete
> 
> Likely a different version of pandoc was used.
> 
> - src/java.base/share/man/keytool.1
> 
>  [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage contains a special character
> 
> - src/jdk.compiler/share/man/javac.1
> 
>  [JDK-8308456](https://bugs.openjdk.org/browse/JDK-8308456): Update javac tool page for -proc:full
> 
> also some formatting differences.
> 
> - src/jdk.jartool/share/man/jarsigner.1
> 
>  [JDK-8303928](https://bugs.openjdk.org/browse/JDK-8303928): Update jarsigner man page after [JDK-8303410](https://bugs.openjdk.org/browse/JDK-8303410)
> 
> - src/jdk.jcmd/share/man/jcmd.1
> 
>  [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion
> 
> - src/jdk.jdeps/share/man/jdeps.1
> 
>  [JDK-8301207](https://bugs.openjdk.org/browse/JDK-8301207): (jdeps) Deprecate jdeps -profile option
> 
> - src/jdk.jfr/share/man/jfr.1
> 
> Formatting changes.
> 
> - src/jdk.jshell/share/man/jshell.1
> 
>  [JDK-8308988](https://bugs.openjdk.org/browse/JDK-8308988): Update JShell manpage to include TOOLING description

Marked as reviewed by egahlin (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk21/pull/151#pullrequestreview-1555541442

From dholmes at openjdk.org  Mon Jul 31 21:13:03 2023
From: dholmes at openjdk.org (David Holmes)
Date: Mon, 31 Jul 2023 21:13:03 GMT
Subject: [jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC
In-Reply-To: <yYCsVWqbTRBVViIaRDn3RgaLKIaBvDgJiFUc0hfV0MI=.bb51767b-b678-465e-ae28-0af1b21c289b@github.com>
References: <yYCsVWqbTRBVViIaRDn3RgaLKIaBvDgJiFUc0hfV0MI=.bb51767b-b678-465e-ae28-0af1b21c289b@github.com>
Message-ID: <Ksw1iyNt46vuKnXO6vAKBi1F1nBZQTCyYlahDuhFwPw=.c6de8a61-0add-4be7-b8ed-3f6e65f9a164@github.com>

On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Main changes are to use 21 instead of 21-ea. In addition the following files contain additional updates from the closed sources:
> 
> - src/java.base/share/man/java.1
> 
>  [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion
>  [JDK-8221633](https://bugs.openjdk.org/browse/JDK-8221633): StartFlightRecording: consider moving mention of multiple comma-separated parameters to the front
> 
> There are also some formatting differences related to:
> 
>  [JDK-8309670](https://bugs.openjdk.org/browse/JDK-8309670): java -help output for --module-path / -p is incomplete
> 
> Likely a different version of pandoc was used.
> 
> - src/java.base/share/man/keytool.1
> 
>  [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage contains a special character
> 
> - src/jdk.compiler/share/man/javac.1
> 
>  [JDK-8308456](https://bugs.openjdk.org/browse/JDK-8308456): Update javac tool page for -proc:full
> 
> also some formatting differences.
> 
> - src/jdk.jartool/share/man/jarsigner.1
> 
>  [JDK-8303928](https://bugs.openjdk.org/browse/JDK-8303928): Update jarsigner man page after [JDK-8303410](https://bugs.openjdk.org/browse/JDK-8303410)
> 
> - src/jdk.jcmd/share/man/jcmd.1
> 
>  [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion
> 
> - src/jdk.jdeps/share/man/jdeps.1
> 
>  [JDK-8301207](https://bugs.openjdk.org/browse/JDK-8301207): (jdeps) Deprecate jdeps -profile option
> 
> - src/jdk.jfr/share/man/jfr.1
> 
> Formatting changes.
> 
> - src/jdk.jshell/share/man/jshell.1
> 
>  [JDK-8308988](https://bugs.openjdk.org/browse/JDK-8308988): Update JShell manpage to include TOOLING description

Thanks for the reviews everyone.

-------------

PR Comment: https://git.openjdk.org/jdk21/pull/151#issuecomment-1659164663

From dholmes at openjdk.org  Mon Jul 31 21:13:04 2023
From: dholmes at openjdk.org (David Holmes)
Date: Mon, 31 Jul 2023 21:13:04 GMT
Subject: [jdk21] Integrated: 8300937: Update nroff pages in JDK 21 before RC
In-Reply-To: <yYCsVWqbTRBVViIaRDn3RgaLKIaBvDgJiFUc0hfV0MI=.bb51767b-b678-465e-ae28-0af1b21c289b@github.com>
References: <yYCsVWqbTRBVViIaRDn3RgaLKIaBvDgJiFUc0hfV0MI=.bb51767b-b678-465e-ae28-0af1b21c289b@github.com>
Message-ID: <CmpiBFKECHa2MW7JqbiBo7dLDr_HgLSwsIUwHl1DsRw=.a6c3df50-b0c2-492d-973f-83defe84514a@github.com>

On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Main changes are to use 21 instead of 21-ea. In addition the following files contain additional updates from the closed sources:
> 
> - src/java.base/share/man/java.1
> 
>  [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion
>  [JDK-8221633](https://bugs.openjdk.org/browse/JDK-8221633): StartFlightRecording: consider moving mention of multiple comma-separated parameters to the front
> 
> There are also some formatting differences related to:
> 
>  [JDK-8309670](https://bugs.openjdk.org/browse/JDK-8309670): java -help output for --module-path / -p is incomplete
> 
> Likely a different version of pandoc was used.
> 
> - src/java.base/share/man/keytool.1
> 
>  [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage contains a special character
> 
> - src/jdk.compiler/share/man/javac.1
> 
>  [JDK-8308456](https://bugs.openjdk.org/browse/JDK-8308456): Update javac tool page for -proc:full
> 
> also some formatting differences.
> 
> - src/jdk.jartool/share/man/jarsigner.1
> 
>  [JDK-8303928](https://bugs.openjdk.org/browse/JDK-8303928): Update jarsigner man page after [JDK-8303410](https://bugs.openjdk.org/browse/JDK-8303410)
> 
> - src/jdk.jcmd/share/man/jcmd.1
> 
>  [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion
> 
> - src/jdk.jdeps/share/man/jdeps.1
> 
>  [JDK-8301207](https://bugs.openjdk.org/browse/JDK-8301207): (jdeps) Deprecate jdeps -profile option
> 
> - src/jdk.jfr/share/man/jfr.1
> 
> Formatting changes.
> 
> - src/jdk.jshell/share/man/jshell.1
> 
>  [JDK-8308988](https://bugs.openjdk.org/browse/JDK-8308988): Update JShell manpage to include TOOLING description

This pull request has now been integrated.

Changeset: 0439d584
Author:    David Holmes <dholmes at openjdk.org>
URL:       https://git.openjdk.org/jdk21/commit/0439d584221f4d92fd1f4097a331f83dcdb2c12c
Stats:     163 lines in 28 files changed: 37 ins; 60 del; 66 mod

8300937: Update nroff pages in JDK 21 before RC

Reviewed-by: mchung, iris, egahlin

-------------

PR: https://git.openjdk.org/jdk21/pull/151