RFR: 8308943: jdk.internal.le build fails on AIX
Jan Lahoda
jlahoda at openjdk.org
Thu Jun 1 11:16:15 UTC 2023
On Fri, 26 May 2023 11:49:34 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
> Build of `jdk.internal.le` fails on AIX, because code in the `unix` directory expects `jdk.internal.org.jline.terminal.impl.jna.JDKNativePty` for each platform (unix-like), but it does not for AIX.
>
> We could add a stub of this class into the `aix` directory (methods could throw an exception, which would automatically switch JLine into the "external executable" mode, if enabled). But, it might be better to use the `ServiceLoader`, and simply register a platform-specific provider as a service. This patch is attempting to do the latter.
In the end, I've used a simpler version that was done under https://github.com/openjdk/jdk/pull/14247. Thanks for the review/efforts anyway!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14176#issuecomment-1571852225
More information about the kulla-dev
mailing list