RFR: 8194743: Compiler implementation for Statements before super() [v6]

Archie Cobbs acobbs at openjdk.org
Tue Jun 13 15:14:45 UTC 2023


On Tue, 13 Jun 2023 04:06:07 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
>> 
>>  - Fix mistake in previous merge commit 80ba6be4.
>>  - Merge branch 'master' into SuperInit
>>  - Rename unit test to be consistent with other feature exampless.
>>  - Update unit test after merged-in commit eaa80ad08.
>>  - Add unit tests with local class decl's prior to super().
>>  - Merge branch 'master' into SuperInit
>>  - Use @enablePreview in tests in preference to explicit command line flags.
>>  - Make "statements before super()" support a preview feature.
>>    
>>    Thanks to Jim Laskey for help with preview logic.
>>  - Small refactoring to avoid redundant test.
>>  - Fix typo in comment.
>>  - ... and 14 more: https://git.openjdk.org/jdk/compare/c72b5474...276e449d
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java line 241:
> 
>> 239:         RECORD_PATTERNS(JDK21, Fragments.FeatureDeconstructionPatterns, DiagKind.PLURAL),
>> 240:         STRING_TEMPLATES(JDK21, Fragments.FeatureStringTemplates, DiagKind.PLURAL),
>> 241:         SUPER_INIT(JDK21, Fragments.FeatureSuperInit, DiagKind.NORMAL),
> 
> Now JDK mainline is 22, this should update the target version too.

Thanks - should be fixed in a5f8cc5e8ff.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13656#discussion_r1228297557


More information about the kulla-dev mailing list