RFR: 8302344: Compiler Implementation for Unnamed patterns and variables (Preview) [v13]

Jan Lahoda jlahoda at openjdk.org
Fri May 5 09:29:42 UTC 2023


On Thu, 4 May 2023 20:47:54 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add test
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java line 438:
> 
>> 436:     }
>> 437: 
>> 438:     public boolean isUnnamed() {
> 
> Should this method get the '@Override @DefinedBy(Api.LANGUAGE_MODEL)' markup?

+1 (I am a bit surprised the tests don't complain, that might be something to look at as well)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13528#discussion_r1185809422


More information about the kulla-dev mailing list