RFR: 8308544: Fix compilation regression from JDK-8306983 on musl libc [v2]

Thomas Stuefe stuefe at openjdk.org
Tue May 23 15:19:08 UTC 2023


On Tue, 23 May 2023 07:29:28 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> Since [JDK-8306983](https://bugs.openjdk.org/browse/JDK-8306983) compilation on Alpine Linux using musl libc:
>> 
>> ../src/jdk.internal.le/linux/native/lible/CLibrary.cpp: In function 'void Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_tcgetattr(JNIEnv*, jobject, jint, jobject)':
>> ../src/jdk.internal.le/linux/native/lible/CLibrary.cpp:116:45: error: 'struct termios' has no member named 'c_ispeed'; did you mean '__c_ispeed'?
>>   116 | env->SetIntField(result, c_ispeed, data.c_ispeed);
>>       | ^~~~~~~~
>>       | __c_ispeed
>> ../src/jdk.internal.le/linux/native/lible/CLibrary.cpp:117:45: error: 'struct termios' has no member named 'c_ospeed'; did you mean '__c_ospeed'?
>>   117 | env->SetIntField(result, c_ospeed, data.c_ospeed);
>>       | ^~~~~~~~
>>       | __c_ospeed
>> ../src/jdk.internal.le/linux/native/lible/CLibrary.cpp: In function 'void Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_tcsetattr(JNIEnv*, jobject, jint, jint, jobject)':
>> ../src/jdk.internal.le/linux/native/lible/CLibrary.cpp:136:10: error: 'struct termios' has no member named 'c_ispeed'; did you mean '__c_ispeed'?
>>   136 | data.c_ispeed = env->GetIntField(input, c_ispeed);
>>       | ^~~~~~~~
>>       | __c_ispeed
>> ../src/jdk.internal.le/linux/native/lible/CLibrary.cpp:137:10: error: 'struct termios' has no member named 'c_ospeed'; did you mean '__c_ospeed'?
>>    ... (rest of output omitted)
>
> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change author's e-mail.

Okay. I had a slightly different fix, but I'll close that as duplicate: https://github.com/openjdk/jdk/pull/14097

Marked as reviewed by stuefe (Reviewer).

@jankratochvil can you please repeat the integrate? Thanks.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14080#pullrequestreview-1439260947
PR Review: https://git.openjdk.org/jdk/pull/14080#pullrequestreview-1439261679
PR Comment: https://git.openjdk.org/jdk/pull/14080#issuecomment-1559093987


More information about the kulla-dev mailing list