RFR: 8308943: jdk.internal.le build fails on AIX

Matthias Baesken mbaesken at openjdk.org
Tue May 30 08:52:58 UTC 2023


On Fri, 26 May 2023 11:49:34 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> Build of `jdk.internal.le` fails on AIX, because code in the `unix` directory expects `jdk.internal.org.jline.terminal.impl.jna.JDKNativePty` for each platform (unix-like), but it does not for AIX.
> 
> We could add a stub of this class into the `aix` directory (methods could throw an exception, which would automatically switch JLine into the "external executable" mode, if enabled). But, it might be better to use the `ServiceLoader`, and simply register a platform-specific provider as a service. This patch is attempting to do the latter.

LGTM

-------------

Marked as reviewed by mbaesken (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14176#pullrequestreview-1450436363


More information about the kulla-dev mailing list