RFR: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
Adam Sotona
asotona at openjdk.org
Mon Nov 13 17:43:57 UTC 2023
On Mon, 13 Nov 2023 15:23:05 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
> JShell by default runs the user's snippets in a separate JVM. This is usually reliable, but during tests, it sometimes happens the remote/separate JVM does not start properly, and the tests fail.
>
> This patch tries to change the default JShell execution in tests so that if the start of the separate JVM fails, the "local" (in process) execution is used. This should improve the stability of the tests.
>
> Non-test JShell execution remains unmodified.
>
> Note that individual tests can override this behavior, for example when they want to test a specific execution.
Looks good.
-------------
Marked as reviewed by asotona (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16632#pullrequestreview-1727867345
More information about the kulla-dev
mailing list