RFR: 8319311: JShell Process Builder should be configurable

[Adam Sotona]

On Mon, 13 Nov 2023 07:52:35 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> JShell has a two parts: the main process, which compiles the user's snippets, and possibly interacts with the user, and an "agent" that executes the executable code produced from the snippets. Then "agent" is typically (although not necessarily) a separate process. The clients of the JShell API are free to override the agent behavior, selecting either from the list of existing agents, or creating their own.
> 
> There is, however, a desire to use agent that is mostly equivalent to the default JDI-based agent, but with some adjustments.
> 
> This patch proposes to limit the amount of code needed to create an agent derived from the default agent.
> 
> The solution has two parts:
> 
>  - a new interface, JdiStarter is created, which the API client can use to provide code that starts the external JVM for snippet execution
>  - the existing JdiInitiator is enhanced so that the user can override the process creation itself.
> 
> Please also review the CSR:
> https://bugs.openjdk.org/browse/JDK-8319923

Looks good.

-------------

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16627#pullrequestreview-1741551612