RFR: 8312475: org.jline.util.PumpReader signed byte problem

Jan Lahoda jlahoda at openjdk.org
Mon Oct 23 10:57:37 UTC 2023


On Thu, 5 Oct 2023 12:06:12 GMT, Michal Sobierski <duke at openjdk.org> wrote:

> Added casting to `& 0xFF` to the InputStream read method return value.

Makes sense - has this been reported upstream yet? Alternatively, `Byte.toUnsignedInt` could be used.

In any case, I suspect this class is not used in the JDK, so I don't expect any impact from this.

-------------

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16053#pullrequestreview-1692250749


More information about the kulla-dev mailing list