RFR: 8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0

Jan Lahoda jlahoda at openjdk.org
Tue Apr 23 09:52:37 UTC 2024


There is a structure called `winsize`, that is read on Linux and Mac to get the size of the terminal. This is part of JLine, which we use. This structure has fields of type `short`. But, our native counterpart (which is not from JLine, because JLine uses JNA to retrieve the values) uses `GetIntField`/`SetIntField` to access the data.

This patch fixes that to use `GetShortField`/`SetShortField`.

-------------

Commit messages:
 - Adjusting MacOSX code as well.
 - 8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0

Changes: https://git.openjdk.org/jdk/pull/18910/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18910&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328703
  Stats: 16 lines in 2 files changed: 0 ins; 0 del; 16 mod
  Patch: https://git.openjdk.org/jdk/pull/18910.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18910/head:pull/18910

PR: https://git.openjdk.org/jdk/pull/18910


More information about the kulla-dev mailing list