RFR: 8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0

Aleksey Shipilev shade at openjdk.org
Tue Apr 23 11:45:31 UTC 2024


On Tue, 23 Apr 2024 09:48:22 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> There is a structure called `winsize`, that is read on Linux and Mac to get the size of the terminal. This is part of JLine, which we use. This structure has fields of type `short`. But, our native counterpart (which is not from JLine, because JLine uses JNA to retrieve the values) uses `GetIntField`/`SetIntField` to access the data.
> 
> This patch fixes that to use `GetShortField`/`SetShortField`.

Marked as reviewed by shade (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18910#pullrequestreview-2016998679


More information about the kulla-dev mailing list