RFR: 8341833: incomplete snippet from loaded files from command line is ignored

Jan Lahoda jlahoda at openjdk.org
Fri Dec 20 17:37:46 UTC 2024


If JShell is run with a parameter that is a file, and the file ends with an incomplete snippet, the incomplete snippet is ignored.

For example:

t.jsh:
class {


 jshell  /tmp/t.jsh
|  Welcome to JShell -- Version 21.0.5
|  For an introduction type: /help intro

jshell>


This PR proposes to produce an explicit error in this case:

$ jshell /tmp/t.jsh 
Building target 'default (exploded-image)' in configuration 'linux-x86_64-server-release'
Finished building target 'default (exploded-image)' in configuration 'linux-x86_64-server-release'
Incomplete input: class {
|  Welcome to JShell -- Version 25-internal
|  For an introduction type: /help intro

jshell>

-------------

Commit messages:
 - 8341833: incomplete snippet from loaded files from command line is ignored

Changes: https://git.openjdk.org/jdk/pull/22850/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22850&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8341833
  Stats: 36 lines in 3 files changed: 35 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22850.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22850/head:pull/22850

PR: https://git.openjdk.org/jdk/pull/22850


More information about the kulla-dev mailing list