RFR: 8337037: compiler internal options are not printing the stacktrace after a compiler crash [v2]

[Vicente Romero]

On Thu, 25 Jul 2024 09:54:22 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> Looks good. Two observation (no need to do anything, mostly for your consideration):
> 
>     * Given that the new exception type is used across different types (e.g. Types and Resolve), it would perhaps make sense to put it in the `util` package?
> 
>     * I noticed that the changes to Type.SignatureGenerator have caused a cascade effect on all the subclasses. I wonder: perhaps SignatureGenerator should be an member inner class, so that it can read its "doe" bit from `Types` directly? After all, clients all have a `types` instance available when creating a subclass of the signature generator, so that would work for them too, but would avoid a bit of repetition.

thanks for your comments, I have made the proposed modifications plus a few other minor changes

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20314#issuecomment-2250839730