RFR: 8332314: Add window size configuration option to JavaShellToolBuilder interface

Archie Cobbs acobbs at openjdk.org
Mon Jun 3 22:33:35 UTC 2024


On Fri, 31 May 2024 06:16:09 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> When launching JShell programmatically (i.e., from a Java program instead of the command line) for an interactive session, it's not currently possible to inform JShell what the terminal window's dimensions are. As a result, JShell defaults to 80x24 and line editing becomes almost impossible because of the scrambled screen contents unless you happen to be using an 80x24 window, which these days is very unlikely.
>> 
>> This patch adds a new method `JavaShellToolBuilder.windowSize()` which allows passing a "hint" for the number of rows & columns.
>
> Sorry for belated reply. This makes sense to me.

Hi @lahodaj, if you get a chance, please review the CSR [JDK-8333379](https://bugs.openjdk.org/browse/JDK-8333379) or recommend someone else who might be a good reviewer. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19226#issuecomment-2146221755


More information about the kulla-dev mailing list