RFR: 8332314: Add window size configuration option to JavaShellToolBuilder interface [v2]
Archie Cobbs
acobbs at openjdk.org
Thu Jun 13 16:04:48 UTC 2024
On Thu, 13 Jun 2024 14:50:13 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
>> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - Bump @since tag 23 -> 24.
>> - Merge branch 'master' into JavaShellToolBuilder.windowSize
>> - Update copyright years.
>> - Fix typo in exception message.
>> - Add new method JavaShellToolBuilder.windowSize().
>
> src/jdk.jshell/share/classes/jdk/jshell/tool/JavaShellToolBuilder.java line 224:
>
>> 222: * @param rows number of displayed rows
>> 223: * @return the {@code JavaShellToolBuilder} instance
>> 224: * @since 23
>
> Suggestion:
>
> * @since 24
Thanks - fixed in 39fb097.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19226#discussion_r1638461540
More information about the kulla-dev
mailing list