RFR: 8332314: Add window size configuration option to JavaShellToolBuilder interface [v2]

[Archie Cobbs]

On Tue, 18 Jun 2024 12:00:18 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Bump @since tag 23 -> 24.
>>  - Merge branch 'master' into JavaShellToolBuilder.windowSize
>>  - Update copyright years.
>>  - Fix typo in exception message.
>>  - Add new method JavaShellToolBuilder.windowSize().
>
> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellToolBuilder.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2016, 2024 Oracle and/or its affiliates. All rights reserved.
> 
> (Assuming the header is intended:) there must be a comma after the year (i.e. `2024,` instead of `2024`).

Thanks - fixed in 1769df6.

> src/jdk.jshell/share/classes/jdk/jshell/tool/JavaShellToolBuilder.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2016, 2024 Oracle and/or its affiliates. All rights reserved.
> 
> (Assuming the header is intended:) there must be a comma after the year (i.e. `2024,` instead of `2024`).

Thanks - fixed in 1769df6.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19226#discussion_r1644746518
PR Review Comment: https://git.openjdk.org/jdk/pull/19226#discussion_r1644746629