RFR: 8332014: since-checker - Fix @ since tags in jdk.jshell [v2]
Jan Lahoda
jlahoda at openjdk.org
Wed Jun 26 10:07:13 UTC 2024
On Fri, 10 May 2024 02:25:26 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Please review this small change that aims to make the `@since` in this module more accurate, these bugs were reported by the checker tool at #18934
>>
>> -field: jdk.jshell.Snippet.SubKind:RECORD_SUBKIND
>> This should have `@since` 17 as it was a Preview element in JDK 14-16
>>
>> -method: java.util.List jdk.jshell.SourceCodeAnalysis.sourceToSnippets(java.lang.String)
>> -method: int jdk.jshell.tool.JavaShellToolBuilder.start(java.lang.String[])
>>
>> both should have `@since` 10 instead of 9
>>
>> Thanks
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>
> update copyright year
Looks good to me. Thanks!
-------------
Marked as reviewed by jlahoda (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19166#pullrequestreview-2141340529
More information about the kulla-dev
mailing list