Integrated: 8332014: since-checker - Fix @ since tags in jdk.jshell

Nizar Benalla nbenalla at openjdk.org
Thu Jun 27 06:25:16 UTC 2024


On Fri, 10 May 2024 01:51:06 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Please review this small change that aims to make the `@since` in this module more accurate, these bugs were reported by the checker tool at #18934 
> 
> -field: jdk.jshell.Snippet.SubKind:RECORD_SUBKIND
> This should have `@since` 17 as it was a Preview element in JDK 14-16
> 
> -method: java.util.List jdk.jshell.SourceCodeAnalysis.sourceToSnippets(java.lang.String)
> -method: int jdk.jshell.tool.JavaShellToolBuilder.start(java.lang.String[])
> 
> both should have `@since` 10 instead of 9
> 
> Thanks

This pull request has now been integrated.

Changeset: 0fc5b271
Author:    Nizar Benalla <nbenalla at openjdk.org>
Committer: Jan Lahoda <jlahoda at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/0fc5b2711fbdde972c40bfef2977dd9d70e09581
Stats:     7 lines in 3 files changed: 5 ins; 1 del; 1 mod

8332014: since-checker - Fix @ since tags in jdk.jshell

Reviewed-by: jlahoda

-------------

PR: https://git.openjdk.org/jdk/pull/19166


More information about the kulla-dev mailing list