RFR: 8326333: jshell <TAB> completion on arrays is incomplete

Guoxiong Li gli at openjdk.org
Sat Mar 9 04:56:56 UTC 2024


On Fri, 8 Mar 2024 08:40:19 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> Inside jshell, arrays don't show `Object` method in array code completion, i.e.:
> 
> jshell> String[] arr = null;
> arr ==> null
> 
> jshell> arr.<code-completion-here>
> 
> 
> will only show `length`. This patch adds `j.l.Object` methods to the suggestions for arrays.

The copyright of `SourceCodeAnalysisImpl.java` needs to be adjusted too. Thanks.

test/langtools/jdk/jshell/CompletionSuggestionTest.java line 814:

> 812:     }
> 813: 
> 814:     //JDK-8326333

Such simple bug-id seems unnecessary or uncomplete.  It is better to privode some description content.

-------------

Changes requested by gli (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18163#pullrequestreview-1926091601
PR Review Comment: https://git.openjdk.org/jdk/pull/18163#discussion_r1518478351


More information about the kulla-dev mailing list