From asotona at openjdk.org  Fri Nov  1 16:25:38 2024
From: asotona at openjdk.org (Adam Sotona)
Date: Fri, 1 Nov 2024 16:25:38 GMT
Subject: RFR: 8342936: Enhance java.io.IO with parameter-less println() and
 readln() [v3]
In-Reply-To: <GIU_Xlc5Yj__L93sxQnPyri420Zyhh3m4GEFrOJz7xE=.bf03cd11-9d67-49be-b122-2c213b2ef45e@github.com>
References: <O5G5fg6g32p4GTr5PMibH7sSMCMr4C8rQ-c7-ChV_4w=.072b449f-2a57-4360-b406-b1d89ca43ea4@github.com>
 <GIU_Xlc5Yj__L93sxQnPyri420Zyhh3m4GEFrOJz7xE=.bf03cd11-9d67-49be-b122-2c213b2ef45e@github.com>
Message-ID: <PJMzwrFb7FB7XTAUr9oOP4m8XVJLSQw80TqN8sni9vo=.eafc1ea9-b7cb-4bcd-8d89-bab16dcc56cc@github.com>

On Tue, 29 Oct 2024 08:13:22 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`, with the (hopefully) obvious semantics, plus the corresponding wiring to make those work. This may become part of JEP 495:
>> https://openjdk.org/jeps/495
>
> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing test for Console.readln/readLine, ensuring the proper methods are called.

Marked as reviewed by asotona (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21693#pullrequestreview-2410405267

From acobbs at openjdk.org  Sat Nov  2 16:01:04 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Sat, 2 Nov 2024 16:01:04 GMT
Subject: RFR: 8343481: Remove unnecessary @SuppressWarnings annotations (kulla)
Message-ID: <kHGjUJ8TrO5alHLad3YI2Z_yox4gaZi-gAY4gf7KHoY=.d32ba2ed-d666-427b-a994-23d2e3a178af@github.com>

Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

-------------

Commit messages:
 - Remove unnecessary @SuppressWarnings annotations.

Changes: https://git.openjdk.org/jdk/pull/21855/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21855&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8343481
  Stats: 16 lines in 15 files changed: 0 ins; 16 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21855.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21855/head:pull/21855

PR: https://git.openjdk.org/jdk/pull/21855

From acobbs at openjdk.org  Sat Nov  2 17:23:46 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Sat, 2 Nov 2024 17:23:46 GMT
Subject: RFR: 8343481: Remove unnecessary @SuppressWarnings annotations
 (kulla) [v2]
In-Reply-To: <kHGjUJ8TrO5alHLad3YI2Z_yox4gaZi-gAY4gf7KHoY=.d32ba2ed-d666-427b-a994-23d2e3a178af@github.com>
References: <kHGjUJ8TrO5alHLad3YI2Z_yox4gaZi-gAY4gf7KHoY=.d32ba2ed-d666-427b-a994-23d2e3a178af@github.com>
Message-ID: <fH1baVue5naF0IhO4_kVobvzH3vJI_K_ISEhZDVEx0w=.1ec87336-836f-4db4-8e83-6bc432b7abcc@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Remove two more "this-escape" supressions.
 - Merge branch 'master' into SuppressWarningsCleanup-kulla
 - Remove unnecessary @SuppressWarnings annotations.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21855/files
  - new: https://git.openjdk.org/jdk/pull/21855/files/cfba5912..af3b0477

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21855&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21855&range=00-01

  Stats: 2635 lines in 109 files changed: 1658 ins; 658 del; 319 mod
  Patch: https://git.openjdk.org/jdk/pull/21855.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21855/head:pull/21855

PR: https://git.openjdk.org/jdk/pull/21855

From acobbs at openjdk.org  Sun Nov  3 03:11:48 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Sun, 3 Nov 2024 03:11:48 GMT
Subject: RFR: 8343481: Remove unnecessary @SuppressWarnings annotations
 (kulla) [v3]
In-Reply-To: <kHGjUJ8TrO5alHLad3YI2Z_yox4gaZi-gAY4gf7KHoY=.d32ba2ed-d666-427b-a994-23d2e3a178af@github.com>
References: <kHGjUJ8TrO5alHLad3YI2Z_yox4gaZi-gAY4gf7KHoY=.d32ba2ed-d666-427b-a994-23d2e3a178af@github.com>
Message-ID: <h-PqI29qKPsbmLSZpSa2W_ENmkQMR6ymRn60DGnMQfo=.6f34f2ab-05e8-49d0-a5d4-3d95b6e0e8fd@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Update copyright years.
 - Merge branch 'master' into SuppressWarningsCleanup-kulla
 - Remove two more "this-escape" supressions.
 - Merge branch 'master' into SuppressWarningsCleanup-kulla
 - Remove unnecessary @SuppressWarnings annotations.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21855/files
  - new: https://git.openjdk.org/jdk/pull/21855/files/af3b0477..91228ed1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21855&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21855&range=01-02

  Stats: 591 lines in 17 files changed: 420 ins; 93 del; 78 mod
  Patch: https://git.openjdk.org/jdk/pull/21855.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21855/head:pull/21855

PR: https://git.openjdk.org/jdk/pull/21855

From jpai at openjdk.org  Sun Nov  3 07:14:27 2024
From: jpai at openjdk.org (Jaikiran Pai)
Date: Sun, 3 Nov 2024 07:14:27 GMT
Subject: RFR: 8342936: Enhance java.io.IO with parameter-less println() and
 readln() [v3]
In-Reply-To: <GIU_Xlc5Yj__L93sxQnPyri420Zyhh3m4GEFrOJz7xE=.bf03cd11-9d67-49be-b122-2c213b2ef45e@github.com>
References: <O5G5fg6g32p4GTr5PMibH7sSMCMr4C8rQ-c7-ChV_4w=.072b449f-2a57-4360-b406-b1d89ca43ea4@github.com>
 <GIU_Xlc5Yj__L93sxQnPyri420Zyhh3m4GEFrOJz7xE=.bf03cd11-9d67-49be-b122-2c213b2ef45e@github.com>
Message-ID: <r-YU3OKicECOrNJsaz-bVVOhjsppRdzWZQFG7tTbgJI=.26845050-e5b5-43a7-9fef-255a35a5a053@github.com>

On Tue, 29 Oct 2024 08:13:22 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`, with the (hopefully) obvious semantics, plus the corresponding wiring to make those work. This may become part of JEP 495:
>> https://openjdk.org/jeps/495
>
> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing test for Console.readln/readLine, ensuring the proper methods are called.

Marked as reviewed by jpai (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21693#pullrequestreview-2411792540

From jpai at openjdk.org  Sun Nov  3 07:14:29 2024
From: jpai at openjdk.org (Jaikiran Pai)
Date: Sun, 3 Nov 2024 07:14:29 GMT
Subject: RFR: 8342936: Enhance java.io.IO with parameter-less println() and
 readln() [v3]
In-Reply-To: <VVo-KS0EHccB-fz2dYkNj9FQj5JSLEiZI8OOyvgZJ4A=.915ba6b9-7295-4e47-ad7d-64b2934abe04@github.com>
References: <O5G5fg6g32p4GTr5PMibH7sSMCMr4C8rQ-c7-ChV_4w=.072b449f-2a57-4360-b406-b1d89ca43ea4@github.com>
 <GIU_Xlc5Yj__L93sxQnPyri420Zyhh3m4GEFrOJz7xE=.bf03cd11-9d67-49be-b122-2c213b2ef45e@github.com>
 <OY4ARfcr0reNyMfiNqT9vAeOZYvE_a5K4Ziy3VZSW8M=.7030b12e-ae29-45b4-b963-7bf7482d5b27@github.com>
 <VVo-KS0EHccB-fz2dYkNj9FQj5JSLEiZI8OOyvgZJ4A=.915ba6b9-7295-4e47-ad7d-64b2934abe04@github.com>
Message-ID: <YOZHzZ7hnUtMLpojnWroPMW41JlztD6yfZrnEKU5AxE=.2f31de8e-5ea2-4b2e-a9c2-48da6b55a8d0@github.com>

On Wed, 30 Oct 2024 12:25:34 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> src/java.base/share/classes/java/io/Console.java line 184:
>> 
>>> 182:      */
>>> 183:     @PreviewFeature(feature = PreviewFeature.Feature.IMPLICIT_CLASSES)
>>> 184:     public Console println() {
>> 
>> Hello Jan, with the introduction of the simplified `java.io.IO` class, some of whose APIs are wrappers around the `java.io.Console` class APIs, it's understandable that we will start seeing new methods being introduced on the `Console` class.
>> 
>> For this specific new `println()` method on the `Console` class, do you think this method will/should be introduced irrespective of the `IO` class usage? In other words, considering a theoretic case where there may be a situation to abandon the implicit classes preview feature or do it in a different way, would we still want this `println()` method to stay on the `Console`? If yes, then perhaps we should drop the `@PreviewFeature` annotation from this new method and introduce it as a regular new API? Same question for the new `readln()` method on the `Console`.
>
> I don't think this PR is the right place to add the methods permanently to `Console`. I am not objecting to that, but it seems the if those would be added independently of `java.io.IO`, it needs a separate discussion and decision. And I believe that, if needed, that should be done outside of and independently on the framework of `java.io.IO` and JEP 495, as both of these are preview features.

Hello Jan, I agree that if we are going to introduce the parameter-less `println()` and `readln()` APIs on `Console` class independently of the preview feature, then it should be done in a separate PR and with a separate discussion. I was going to suggest that we should probably do that, but I notice that the existing `readln` and `println` methods which take a parameter are already marked preview feature methods in Java 23 https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/io/Console.html#preview-println(java.lang.Object). Given that, I believe what you have here in this PR - marking these new parameter-less methods on `Console` as preview feature, is the right thing to do.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21693#discussion_r1826918451

From duke at openjdk.org  Tue Nov  5 09:52:30 2024
From: duke at openjdk.org (vulinh64)
Date: Tue, 5 Nov 2024 09:52:30 GMT
Subject: RFR: 8342936: Enhance java.io.IO with parameter-less println() and
 readln() [v3]
In-Reply-To: <GIU_Xlc5Yj__L93sxQnPyri420Zyhh3m4GEFrOJz7xE=.bf03cd11-9d67-49be-b122-2c213b2ef45e@github.com>
References: <O5G5fg6g32p4GTr5PMibH7sSMCMr4C8rQ-c7-ChV_4w=.072b449f-2a57-4360-b406-b1d89ca43ea4@github.com>
 <GIU_Xlc5Yj__L93sxQnPyri420Zyhh3m4GEFrOJz7xE=.bf03cd11-9d67-49be-b122-2c213b2ef45e@github.com>
Message-ID: <TENfziWlBy_10TuYwbsZnB8t0ukvO9afP7hYGefVn6g=.032e07ff-ec74-42f5-9249-500d34c573d9@github.com>

On Tue, 29 Oct 2024 08:13:22 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`, with the (hopefully) obvious semantics, plus the corresponding wiring to make those work. This may become part of JEP 495:
>> https://openjdk.org/jeps/495
>
> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing test for Console.readln/readLine, ensuring the proper methods are called.

My question (please don't bash me, I am new): Any chance we can set the encoding of console? I tested on Java 23 and the encoding is `windows-1252` so it will not display unicode characters correctly.

![image](https://github.com/user-attachments/assets/cd4cb1a7-8dec-4bb7-ae76-121f3a9369b0)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21693#issuecomment-2456709109

From jlahoda at openjdk.org  Tue Nov  5 11:24:29 2024
From: jlahoda at openjdk.org (Jan Lahoda)
Date: Tue, 5 Nov 2024 11:24:29 GMT
Subject: RFR: 8342936: Enhance java.io.IO with parameter-less println() and
 readln() [v3]
In-Reply-To: <TENfziWlBy_10TuYwbsZnB8t0ukvO9afP7hYGefVn6g=.032e07ff-ec74-42f5-9249-500d34c573d9@github.com>
References: <O5G5fg6g32p4GTr5PMibH7sSMCMr4C8rQ-c7-ChV_4w=.072b449f-2a57-4360-b406-b1d89ca43ea4@github.com>
 <GIU_Xlc5Yj__L93sxQnPyri420Zyhh3m4GEFrOJz7xE=.bf03cd11-9d67-49be-b122-2c213b2ef45e@github.com>
 <TENfziWlBy_10TuYwbsZnB8t0ukvO9afP7hYGefVn6g=.032e07ff-ec74-42f5-9249-500d34c573d9@github.com>
Message-ID: <LiTAbYtJFss17_WBgUfpKC4vn0o3SR6xQO2y11XMGp8=.09906daf-5f67-450d-8cb2-db9c4779ab7a@github.com>

On Tue, 5 Nov 2024 09:48:29 GMT, vulinh64 <duke at openjdk.org> wrote:

> My question (please don't bash me, I am new): Any chance we can set the encoding of console? I tested on Java 23 (Windows) and the encoding is `windows-1252` so it will not display unicode characters correctly.

I believe that after https://github.com/openjdk/jdk/pull/21569, the `Console` encoding used by the JDK can be overwritten with `stdout.encoding`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21693#issuecomment-2456910087

From naoto at openjdk.org  Tue Nov  5 18:14:29 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 5 Nov 2024 18:14:29 GMT
Subject: RFR: 8342936: Enhance java.io.IO with parameter-less println() and
 readln() [v3]
In-Reply-To: <GIU_Xlc5Yj__L93sxQnPyri420Zyhh3m4GEFrOJz7xE=.bf03cd11-9d67-49be-b122-2c213b2ef45e@github.com>
References: <O5G5fg6g32p4GTr5PMibH7sSMCMr4C8rQ-c7-ChV_4w=.072b449f-2a57-4360-b406-b1d89ca43ea4@github.com>
 <GIU_Xlc5Yj__L93sxQnPyri420Zyhh3m4GEFrOJz7xE=.bf03cd11-9d67-49be-b122-2c213b2ef45e@github.com>
Message-ID: <oiwrvkaNtK6NaRNEF8ichKEGA7tI-m5qN0OeTPsD42M=.aedcc497-685c-4e3a-ac84-4da3e45892cd@github.com>

On Tue, 29 Oct 2024 08:13:22 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`, with the (hopefully) obvious semantics, plus the corresponding wiring to make those work. This may become part of JEP 495:
>> https://openjdk.org/jeps/495
>
> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing test for Console.readln/readLine, ensuring the proper methods are called.

> > My question (please don't bash me, I am new): Any chance we can set the encoding of console? I tested on Java 23 (Windows) and the encoding is `windows-1252` so it will not display unicode characters correctly.
> 
> I believe that after #21569, the `Console` encoding used by the JDK can be overwritten with `stdout.encoding`.

Yes, that is in place. Will be available in JDK24: https://bugs.openjdk.org/browse/JDK-8342208

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21693#issuecomment-2457858145

From vromero at openjdk.org  Fri Nov  8 14:49:21 2024
From: vromero at openjdk.org (Vicente Romero)
Date: Fri, 8 Nov 2024 14:49:21 GMT
Subject: RFR: 8341176: Permit access to diagnostics for transient snippets
In-Reply-To: <jMe6RVqjj_5uG_2ggwNfw908tjctTYda03bpsPRbhXQ=.a3aa7969-1095-4cc9-8ff9-0ed1a5dd7be9@github.com>
References: <jMe6RVqjj_5uG_2ggwNfw908tjctTYda03bpsPRbhXQ=.a3aa7969-1095-4cc9-8ff9-0ed1a5dd7be9@github.com>
Message-ID: <m8EvB2xc1ipSO-OtEIkvfa7EA5fXGPk0txCKP-gmgxA=.314dd730-2c34-4138-94a5-e6143e80167d@github.com>

On Mon, 30 Sep 2024 11:30:47 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> JShell permits to create transient snippets using `SourceCodeAnalysis.sourceToSnippets`, for the purpose of alternative UI clients. But, the alternative UI clients might need to get the diagnostics for the snippets, but the existing `JShell.diagnostics(Snippet)` will not work for the transient snippets.
> 
> This patch proposes to enhance the `JShell.diagnostics(Snippet)` with an ability to return best-effort diagnostics for these transient snippets.
> 
> Please also review the CSR:
> https://bugs.openjdk.org/browse/JDK-8341200

lgtm

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21261#pullrequestreview-2424000086

From acobbs at openjdk.org  Fri Nov  8 16:15:38 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Fri, 8 Nov 2024 16:15:38 GMT
Subject: RFR: 8341495: JShell crashes with
 java.util.MissingFormatArgumentException [v5]
In-Reply-To: <n_M3f8tr3lNvwZUK42N-KiUJAm53_-SdXDn_cVsWrHQ=.9ef37f15-3276-4288-9db5-db71ccff0eb6@github.com>
References: <n_M3f8tr3lNvwZUK42N-KiUJAm53_-SdXDn_cVsWrHQ=.9ef37f15-3276-4288-9db5-db71ccff0eb6@github.com>
Message-ID: <H9MF-6OV2Nyh0pEhzaHcLv6c_imHrP4y1nuzc-QaDTE=.7a6224f2-3524-40a3-8499-4fd88328bb36@github.com>

> JShell prints some of its output using `printf()` formatted strings. However, there are a few spots where a string `str` to be printed is passed directly as a format string like `format(str)` instead of indirectly like `format("%s", str)`, even though the string `str` contains unknown or arbitrary content outside of JShell's control. As a result, JShell can crash suddenly with a `MissingFormatArgumentException` or similar exception if the string `str` happens to contain a `%` format specifier, etc.
> 
> Please review this patch which attempts to fix the places where an unknown string is passed directly as a format string.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge branch 'master' into JDK-8341495
 - Rename another String parameter to "format" to reflect its purpose.
 - Revert previous change to unrelated JLine prompt substitution.
 - Use replace() instead of replaceAll() for literal string substitution.
 - Fix  prefixing/postfixing logic broken by previous commit.
 - Avoid invoking out.printf() with unknown format strings that might contain escapes.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21339/files
  - new: https://git.openjdk.org/jdk/pull/21339/files/4e692b45..70f053fa

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21339&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21339&range=03-04

  Stats: 273069 lines in 3030 files changed: 170402 ins; 75142 del; 27525 mod
  Patch: https://git.openjdk.org/jdk/pull/21339.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21339/head:pull/21339

PR: https://git.openjdk.org/jdk/pull/21339

From acobbs at openjdk.org  Fri Nov  8 16:22:34 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Fri, 8 Nov 2024 16:22:34 GMT
Subject: RFR: 8341495: JShell crashes with
 java.util.MissingFormatArgumentException [v6]
In-Reply-To: <n_M3f8tr3lNvwZUK42N-KiUJAm53_-SdXDn_cVsWrHQ=.9ef37f15-3276-4288-9db5-db71ccff0eb6@github.com>
References: <n_M3f8tr3lNvwZUK42N-KiUJAm53_-SdXDn_cVsWrHQ=.9ef37f15-3276-4288-9db5-db71ccff0eb6@github.com>
Message-ID: <yu5xgJZYKERu--t1mqAx7SpgOM4P2AmzoOGDMDmUQYg=.efedbb6b-871d-4fcb-b988-60e25c8667ce@github.com>

> JShell prints some of its output using `printf()` formatted strings. However, there are a few spots where a string `str` to be printed is passed directly as a format string like `format(str)` instead of indirectly like `format("%s", str)`, even though the string `str` contains unknown or arbitrary content outside of JShell's control. As a result, JShell can crash suddenly with a `MissingFormatArgumentException` or similar exception if the string `str` happens to contain a `%` format specifier, etc.
> 
> Please review this patch which attempts to fix the places where an unknown string is passed directly as a format string.

Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:

  Update copyright year in properties files.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21339/files
  - new: https://git.openjdk.org/jdk/pull/21339/files/70f053fa..7373faf2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21339&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21339&range=04-05

  Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/21339.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21339/head:pull/21339

PR: https://git.openjdk.org/jdk/pull/21339

From liach at openjdk.org  Fri Nov  8 16:22:39 2024
From: liach at openjdk.org (Chen Liang)
Date: Fri, 8 Nov 2024 16:22:39 GMT
Subject: RFR: 8341495: JShell crashes with
 java.util.MissingFormatArgumentException [v5]
In-Reply-To: <H9MF-6OV2Nyh0pEhzaHcLv6c_imHrP4y1nuzc-QaDTE=.7a6224f2-3524-40a3-8499-4fd88328bb36@github.com>
References: <n_M3f8tr3lNvwZUK42N-KiUJAm53_-SdXDn_cVsWrHQ=.9ef37f15-3276-4288-9db5-db71ccff0eb6@github.com>
 <H9MF-6OV2Nyh0pEhzaHcLv6c_imHrP4y1nuzc-QaDTE=.7a6224f2-3524-40a3-8499-4fd88328bb36@github.com>
Message-ID: <WJR8rxf3l1Vg_tyaBdgHztG32lHeA9c_fwAzQBZhaF8=.f10a11c6-b4f8-4851-a0ba-e0a06fa4d799@github.com>

On Fri, 8 Nov 2024 16:15:38 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> JShell prints some of its output using `printf()` formatted strings. However, there are a few spots where a string `str` to be printed is passed directly as a format string like `format(str)` instead of indirectly like `format("%s", str)`, even though the string `str` contains unknown or arbitrary content outside of JShell's control. As a result, JShell can crash suddenly with a `MissingFormatArgumentException` or similar exception if the string `str` happens to contain a `%` format specifier, etc.
>> 
>> Please review this patch which attempts to fix the places where an unknown string is passed directly as a format string.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8341495
>  - Rename another String parameter to "format" to reflect its purpose.
>  - Revert previous change to unrelated JLine prompt substitution.
>  - Use replace() instead of replaceAll() for literal string substitution.
>  - Fix  prefixing/postfixing logic broken by previous commit.
>  - Avoid invoking out.printf() with unknown format strings that might contain escapes.

@lahodaj Can you take a look at this fix?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21339#issuecomment-2465183314

From acobbs at openjdk.org  Fri Nov  8 19:07:28 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Fri, 8 Nov 2024 19:07:28 GMT
Subject: RFR: 8343481: Remove unnecessary @SuppressWarnings annotations
 (kulla) [v4]
In-Reply-To: <kHGjUJ8TrO5alHLad3YI2Z_yox4gaZi-gAY4gf7KHoY=.d32ba2ed-d666-427b-a994-23d2e3a178af@github.com>
References: <kHGjUJ8TrO5alHLad3YI2Z_yox4gaZi-gAY4gf7KHoY=.d32ba2ed-d666-427b-a994-23d2e3a178af@github.com>
Message-ID: <iKAnZAo7W5stZs68PknKaUMN4_b-r5h9sKSMchoVwoA=.0de5f578-9463-4b56-8631-574cc1f7fa83@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge branch 'master' into SuppressWarningsCleanup-kulla
 - Update copyright years.
 - Merge branch 'master' into SuppressWarningsCleanup-kulla
 - Remove two more "this-escape" supressions.
 - Merge branch 'master' into SuppressWarningsCleanup-kulla
 - Remove unnecessary @SuppressWarnings annotations.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21855/files
  - new: https://git.openjdk.org/jdk/pull/21855/files/91228ed1..a3fbad1c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21855&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21855&range=02-03

  Stats: 131587 lines in 749 files changed: 103986 ins; 9680 del; 17921 mod
  Patch: https://git.openjdk.org/jdk/pull/21855.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21855/head:pull/21855

PR: https://git.openjdk.org/jdk/pull/21855

From jlahoda at openjdk.org  Mon Nov 11 09:37:40 2024
From: jlahoda at openjdk.org (Jan Lahoda)
Date: Mon, 11 Nov 2024 09:37:40 GMT
Subject: Integrated: 8341176: Permit access to diagnostics for transient
 snippets
In-Reply-To: <jMe6RVqjj_5uG_2ggwNfw908tjctTYda03bpsPRbhXQ=.a3aa7969-1095-4cc9-8ff9-0ed1a5dd7be9@github.com>
References: <jMe6RVqjj_5uG_2ggwNfw908tjctTYda03bpsPRbhXQ=.a3aa7969-1095-4cc9-8ff9-0ed1a5dd7be9@github.com>
Message-ID: <g_mS45ZOUC4r_OVeBflGSONu3uW2D7eAK7pvjf3slY4=.4c76a4db-dd97-41a4-a4a2-d56d9f87b7c7@github.com>

On Mon, 30 Sep 2024 11:30:47 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> JShell permits to create transient snippets using `SourceCodeAnalysis.sourceToSnippets`, for the purpose of alternative UI clients. But, the alternative UI clients might need to get the diagnostics for the snippets, but the existing `JShell.diagnostics(Snippet)` will not work for the transient snippets.
> 
> This patch proposes to enhance the `JShell.diagnostics(Snippet)` with an ability to return best-effort diagnostics for these transient snippets.
> 
> Please also review the CSR:
> https://bugs.openjdk.org/browse/JDK-8341200

This pull request has now been integrated.

Changeset: 5ca6698b
Author:    Jan Lahoda <jlahoda at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5ca6698ba418e82ff93471fbb495759850f26f63
Stats:     91 lines in 4 files changed: 84 ins; 0 del; 7 mod

8341176: Permit access to diagnostics for transient snippets

Reviewed-by: vromero

-------------

PR: https://git.openjdk.org/jdk/pull/21261

From acobbs at openjdk.org  Wed Nov 13 16:53:03 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Wed, 13 Nov 2024 16:53:03 GMT
Subject: RFR: 8343481: Remove unnecessary @SuppressWarnings annotations
 (kulla) [v5]
In-Reply-To: <kHGjUJ8TrO5alHLad3YI2Z_yox4gaZi-gAY4gf7KHoY=.d32ba2ed-d666-427b-a994-23d2e3a178af@github.com>
References: <kHGjUJ8TrO5alHLad3YI2Z_yox4gaZi-gAY4gf7KHoY=.d32ba2ed-d666-427b-a994-23d2e3a178af@github.com>
Message-ID: <0ffa89tPmxvnQFqQPalxKv9ZJfNjByqxc73JQJReNbE=.abb952c8-b881-4438-a3c0-788f7788b6f7@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

 - Merge branch 'master' into SuppressWarningsCleanup-kulla
 - Merge branch 'master' into SuppressWarningsCleanup-kulla
 - Update copyright years.
 - Merge branch 'master' into SuppressWarningsCleanup-kulla
 - Remove two more "this-escape" supressions.
 - Merge branch 'master' into SuppressWarningsCleanup-kulla
 - Remove unnecessary @SuppressWarnings annotations.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21855/files
  - new: https://git.openjdk.org/jdk/pull/21855/files/a3fbad1c..92d02591

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21855&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21855&range=03-04

  Stats: 95175 lines in 2626 files changed: 19948 ins; 68244 del; 6983 mod
  Patch: https://git.openjdk.org/jdk/pull/21855.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21855/head:pull/21855

PR: https://git.openjdk.org/jdk/pull/21855

From jjg at openjdk.org  Wed Nov 13 18:11:11 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 13 Nov 2024 18:11:11 GMT
Subject: RFR: 8344056: Use markdown format for man pages
In-Reply-To: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
Message-ID: <poXB1Eqc6-PMAJbrqpAf9c5t3wzhkFIRJz_r356snx0=.ff1deb7a-1842-4909-87cf-a6e205ab3187@github.com>

On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
> 
> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
> 
> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.

Without looking in detail at the changes, this is indeed a welcome and long-overdue change!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22081#issuecomment-2474339519

From ihse at openjdk.org  Wed Nov 13 18:11:11 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Wed, 13 Nov 2024 18:11:11 GMT
Subject: RFR: 8344056: Use markdown format for man pages
Message-ID: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>

Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.

Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.

This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.

-------------

Commit messages:
 - Replace tabs with spaces
 - Remove logic for copying .1 man pages
 - Insert GPL header
 - Add missing Windows man pages for kerberos and accessibility
 - Replace generated troff man pages with markdown version

Changes: https://git.openjdk.org/jdk/pull/22081/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22081&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344056
  Stats: 41443 lines in 65 files changed: 18943 ins; 22500 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/22081.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22081/head:pull/22081

PR: https://git.openjdk.org/jdk/pull/22081

From kevinw at openjdk.org  Wed Nov 13 20:21:08 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 13 Nov 2024 20:21:08 GMT
Subject: RFR: 8344056: Use markdown format for man pages
In-Reply-To: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
Message-ID: <Ii7cVmWIyFLR4Q5q7TAl2NENV2_ixQJAGYEqdbdzkCc=.1bec7144-ad3e-4818-98f8-643daadba001@github.com>

On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
> 
> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
> 
> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.

I think this means the one-true-master copy of a man page is now the public .md file.
All contributors can now change and improve man pages, and would be expected to make necessary man page updates when making other changes.
(Which is great, I just didn't see it being explicitly said.)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22081#issuecomment-2474701337

From cstein at openjdk.org  Wed Nov 13 20:56:51 2024
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 13 Nov 2024 20:56:51 GMT
Subject: RFR: 8344056: Use markdown format for man pages
In-Reply-To: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
Message-ID: <PHyC5A7Ex4Q-AenCRUvAu_Jov2pnSGiIiCmmsfcRg44=.19e00289-a896-48a7-8ea8-05f63ed0b3e8@github.com>

On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
> 
> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
> 
> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.

So glad to see progress here!

https://github.com/openjdk/jdk/blob/1484153c1a092cefc20270b35aa1e508280843a4/test/langtools/jdk/javadoc/tool/CheckManPageOptions.java#L141

should read `return findRootDir().resolve("src/jdk.javadoc/share/man/javadoc.md");` now.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22081#issuecomment-2474760888

From jjg at openjdk.org  Wed Nov 13 21:21:32 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 13 Nov 2024 21:21:32 GMT
Subject: RFR: 8344056: Use markdown format for man pages
In-Reply-To: <Ii7cVmWIyFLR4Q5q7TAl2NENV2_ixQJAGYEqdbdzkCc=.1bec7144-ad3e-4818-98f8-643daadba001@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <Ii7cVmWIyFLR4Q5q7TAl2NENV2_ixQJAGYEqdbdzkCc=.1bec7144-ad3e-4818-98f8-643daadba001@github.com>
Message-ID: <hs9l_aVDMpskTmhf_ovJv8cHP9FepHgxV3UCdxSe7DE=.230ad939-6314-4add-a921-7dea6249c191@github.com>

On Wed, 13 Nov 2024 20:17:24 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> I think this means the one-true-master copy of a man page is now the public .md file. All contributors can now change and improve man pages, and would be expected to make necessary man page updates when making other changes. (Which is great, I just didn't see it being explicitly said.)

Yes, related: 
Non-trivial updates to these pages should be approved in a CSR, maybe along with any code changes that may make such an update necessary.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22081#issuecomment-2474804913

From dholmes at openjdk.org  Wed Nov 13 21:35:39 2024
From: dholmes at openjdk.org (David Holmes)
Date: Wed, 13 Nov 2024 21:35:39 GMT
Subject: RFR: 8344056: Use markdown format for man pages
In-Reply-To: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
Message-ID: <ZLu8_dld82FRJWl9AYY_4d8oRvBl1G0uPk6VG-QmEdc=.4175dfca-a423-4296-a24c-069ce3264dc0@github.com>

On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
> 
> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
> 
> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.

Great to finally see this happen!

Just one glitch with the GPL headers.

Thanks

src/java.base/share/man/java.md line 9:

> 7: # published by the Free Software Foundation.  Oracle designates this
> 8: # particular file as subject to the "Classpath" exception as provided
> 9: # by Oracle in the LICENSE file that accompanied this code.

Documentation files should not have the Classpath exception.

make/data/license-templates/gpl-header

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22081#pullrequestreview-2434474132
PR Review Comment: https://git.openjdk.org/jdk/pull/22081#discussion_r1841189067

From cstein at openjdk.org  Wed Nov 13 21:35:40 2024
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 13 Nov 2024 21:35:40 GMT
Subject: RFR: 8344056: Use markdown format for man pages
In-Reply-To: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
Message-ID: <XOo88TaSl5QEwAEJISAsUq0BYBtieHSYSBQHovdgdEU=.9894ac56-793f-4ec1-901b-eb476eec2a51@github.com>

On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
> 
> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
> 
> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.

A missing `.1` to `.md` file extension change in `javadoc`'s manpage self-test `CheckManPageOptions.java` is causing the CI to fail.

Details in https://github.com/openjdk/jdk/pull/22081#issuecomment-2474760888

-------------

Changes requested by cstein (Committer).

PR Review: https://git.openjdk.org/jdk/pull/22081#pullrequestreview-2434491865

From iris at openjdk.org  Wed Nov 13 21:59:34 2024
From: iris at openjdk.org (Iris Clark)
Date: Wed, 13 Nov 2024 21:59:34 GMT
Subject: RFR: 8344056: Use markdown format for man pages
In-Reply-To: <ZLu8_dld82FRJWl9AYY_4d8oRvBl1G0uPk6VG-QmEdc=.4175dfca-a423-4296-a24c-069ce3264dc0@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <ZLu8_dld82FRJWl9AYY_4d8oRvBl1G0uPk6VG-QmEdc=.4175dfca-a423-4296-a24c-069ce3264dc0@github.com>
Message-ID: <QyBh2MR7GEWc2oQ3NimEgV8rHcbvbLEoOK_vAwVaMjo=.2fc260cc-25c2-47fd-8bc1-57d0f45e7d62@github.com>

On Wed, 13 Nov 2024 21:27:02 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
>> 
>> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
>> 
>> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.
>
> src/java.base/share/man/java.md line 9:
> 
>> 7: # published by the Free Software Foundation.  Oracle designates this
>> 8: # particular file as subject to the "Classpath" exception as provided
>> 9: # by Oracle in the LICENSE file that accompanied this code.
> 
> Documentation files should not have the Classpath exception.
> 
> make/data/license-templates/gpl-header

Agree.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22081#discussion_r1841231909

From jlahoda at openjdk.org  Thu Nov 14 08:26:31 2024
From: jlahoda at openjdk.org (Jan Lahoda)
Date: Thu, 14 Nov 2024 08:26:31 GMT
Subject: Integrated: 8342936: Enhance java.io.IO with parameter-less println()
 and readln()
In-Reply-To: <O5G5fg6g32p4GTr5PMibH7sSMCMr4C8rQ-c7-ChV_4w=.072b449f-2a57-4360-b406-b1d89ca43ea4@github.com>
References: <O5G5fg6g32p4GTr5PMibH7sSMCMr4C8rQ-c7-ChV_4w=.072b449f-2a57-4360-b406-b1d89ca43ea4@github.com>
Message-ID: <wKRTRSG5GtR8ghs8xoE_PI6FlNEF94TYP3Ab9eysiEM=.b1f0d92a-1af1-4082-b0f8-c7adc0ed7e0e@github.com>

On Thu, 24 Oct 2024 19:27:47 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`, with the (hopefully) obvious semantics, plus the corresponding wiring to make those work. This may become part of JEP 495:
> https://openjdk.org/jeps/495

This pull request has now been integrated.

Changeset: c3776db4
Author:    Jan Lahoda <jlahoda at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c3776db498193d45088ed19e2a1d2697281fd590
Stats:     231 lines in 14 files changed: 212 ins; 8 del; 11 mod

8342936: Enhance java.io.IO with parameter-less println() and readln()

Reviewed-by: asotona, jpai, naoto

-------------

PR: https://git.openjdk.org/jdk/pull/21693

From dfuchs at openjdk.org  Thu Nov 14 09:05:42 2024
From: dfuchs at openjdk.org (Daniel Fuchs)
Date: Thu, 14 Nov 2024 09:05:42 GMT
Subject: RFR: 8344056: Use markdown format for man pages
In-Reply-To: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
Message-ID: <AycUeSLX9L93ofeVSrDSkhF7_vgwwoT0_h8_Hq_4qko=.03fef401-4f94-41bf-82c7-1b50d35e2ee0@github.com>

On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
> 
> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
> 
> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.

The jwebserver.md looks OK to me.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22081#pullrequestreview-2435435938

From ihse at openjdk.org  Thu Nov 14 11:11:54 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Thu, 14 Nov 2024 11:11:54 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v2]
In-Reply-To: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
Message-ID: <XPX7mNek8KcN7ri7h8gqRZFBeKjSmu_XiHuvE-cR0Ws=.7292fd84-de4b-4163-8cf3-93838a32f1c4@github.com>

> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
> 
> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
> 
> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.

Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:

 - Fix CheckManPageOptions test
 - Remove classpath exception

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22081/files
  - new: https://git.openjdk.org/jdk/pull/22081/files/ffb41ba0..a8d4ea50

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22081&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22081&range=00-01

  Stats: 106 lines in 36 files changed: 0 ins; 70 del; 36 mod
  Patch: https://git.openjdk.org/jdk/pull/22081.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22081/head:pull/22081

PR: https://git.openjdk.org/jdk/pull/22081

From ihse at openjdk.org  Thu Nov 14 11:12:52 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Thu, 14 Nov 2024 11:12:52 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v2]
In-Reply-To: <QyBh2MR7GEWc2oQ3NimEgV8rHcbvbLEoOK_vAwVaMjo=.2fc260cc-25c2-47fd-8bc1-57d0f45e7d62@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <ZLu8_dld82FRJWl9AYY_4d8oRvBl1G0uPk6VG-QmEdc=.4175dfca-a423-4296-a24c-069ce3264dc0@github.com>
 <QyBh2MR7GEWc2oQ3NimEgV8rHcbvbLEoOK_vAwVaMjo=.2fc260cc-25c2-47fd-8bc1-57d0f45e7d62@github.com>
Message-ID: <Y-yOZblThvBgNy5r1E59_WVTTgFIunkj4KdvlR3Aq7M=.cbfd247a-a955-482c-a150-621a0f683637@github.com>

On Wed, 13 Nov 2024 21:55:53 GMT, Iris Clark <iris at openjdk.org> wrote:

>> src/java.base/share/man/java.md line 9:
>> 
>>> 7: # published by the Free Software Foundation.  Oracle designates this
>>> 8: # particular file as subject to the "Classpath" exception as provided
>>> 9: # by Oracle in the LICENSE file that accompanied this code.
>> 
>> Documentation files should not have the Classpath exception.
>> 
>> make/data/license-templates/gpl-header
>
> Agree.

Yeah, sorry for that, and thanks for catching it. 

I just copied the header from a build file, since it was conveniently already formatted with the leading `#`. I just assumed that this was the pure GPL and did not check close enough to verify. But it turns out that most of the build system files actually have the classpath exception, which makes no sense. 

I've filed https://bugs.openjdk.org/browse/JDK-8344191 to deal with that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22081#discussion_r1842039722

From ihse at openjdk.org  Thu Nov 14 12:28:23 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Thu, 14 Nov 2024 12:28:23 GMT
Subject: RFR: 8344191: Build code should not have classpath exception
Message-ID: <U0XAHfEgxgfvcpBaj8aOZgQgk0cU-GyAMyeJ9cyJrUA=.84aeedaa-ef83-48e9-9eea-1de1e8d0afd6@github.com>

In several (most? all?) of the build system files, the copyright header includes the classpath exception. This makes no sense, and should be removed. 

I have removed the classpath exception from makefiles, autoconf, shell scripts, properties files, configuration files, IDE support files, build tools and data.

The only places where the classpath exception is still kept in the make directory is as text strings in some build tools, which generate source code that is bundled with `src.zip`, and thus *must* have the classpath exception.

This is a huge and autogenerated, but content-wise trivial, PR, and I know such are hard to review. I recommend looking at the entire diff file instead of checking this file-by-file in the Github web GUI. (That's bound to be a painful experience)

-------------

Commit messages:
 - Update build tools, data and IDE support
 - Update makefiles, autoconf, shell scripts, properties files and configuration files

Changes: https://git.openjdk.org/jdk/pull/22104/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22104&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344191
  Stats: 2054 lines in 555 files changed: 0 ins; 1118 del; 936 mod
  Patch: https://git.openjdk.org/jdk/pull/22104.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22104/head:pull/22104

PR: https://git.openjdk.org/jdk/pull/22104

From cstein at openjdk.org  Thu Nov 14 12:31:46 2024
From: cstein at openjdk.org (Christian Stein)
Date: Thu, 14 Nov 2024 12:31:46 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v2]
In-Reply-To: <XPX7mNek8KcN7ri7h8gqRZFBeKjSmu_XiHuvE-cR0Ws=.7292fd84-de4b-4163-8cf3-93838a32f1c4@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <XPX7mNek8KcN7ri7h8gqRZFBeKjSmu_XiHuvE-cR0Ws=.7292fd84-de4b-4163-8cf3-93838a32f1c4@github.com>
Message-ID: <B5wPJ1nOlZ8FqUq_BanQIjs_CFKZPbhmTHd_MwKHnYk=.4e63cd9e-02be-4e45-b79c-bc325ccd75e5@github.com>

On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
>> 
>> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
>> 
>> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix CheckManPageOptions test
>  - Remove classpath exception

Now `CheckManPageOptions` finds the `.md` file (good) and its checks fail (bad). A candidate for an ignore list as fixing it is out of scope of this PR?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22081#issuecomment-2476233883

From ihse at openjdk.org  Thu Nov 14 12:44:45 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Thu, 14 Nov 2024 12:44:45 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v2]
In-Reply-To: <B5wPJ1nOlZ8FqUq_BanQIjs_CFKZPbhmTHd_MwKHnYk=.4e63cd9e-02be-4e45-b79c-bc325ccd75e5@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <XPX7mNek8KcN7ri7h8gqRZFBeKjSmu_XiHuvE-cR0Ws=.7292fd84-de4b-4163-8cf3-93838a32f1c4@github.com>
 <B5wPJ1nOlZ8FqUq_BanQIjs_CFKZPbhmTHd_MwKHnYk=.4e63cd9e-02be-4e45-b79c-bc325ccd75e5@github.com>
Message-ID: <hGn-UQ8cj7rW04rBdwPSG7vy4_fy-L3GIw_IDz3CXvc=.cf326c7c-0f31-483c-939d-8e5193c1e609@github.com>

On Thu, 14 Nov 2024 12:29:38 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Now `CheckManPageOptions` finds the `.md` file (good) and its checks fail (bad). 

*sigh*

> A candidate for an ignore list as fixing it is out of scope of this PR?

Let me have a look at it first. It seems the test has the indention to handle markdown files, so maybe there is an easy fix.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22081#issuecomment-2476258243

From duke at openjdk.org  Thu Nov 14 13:34:44 2024
From: duke at openjdk.org (Abdelhak Zaaim)
Date: Thu, 14 Nov 2024 13:34:44 GMT
Subject: RFR: 8344191: Build code should not have classpath exception
In-Reply-To: <U0XAHfEgxgfvcpBaj8aOZgQgk0cU-GyAMyeJ9cyJrUA=.84aeedaa-ef83-48e9-9eea-1de1e8d0afd6@github.com>
References: <U0XAHfEgxgfvcpBaj8aOZgQgk0cU-GyAMyeJ9cyJrUA=.84aeedaa-ef83-48e9-9eea-1de1e8d0afd6@github.com>
Message-ID: <_LlSFeUxsE5NIZ1tl6Fx_PV0NiHyVfwlkYD-91GkfOQ=.a5f09f9e-6116-4f3b-8860-c1e21474e213@github.com>

On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> In several (most? all?) of the build system files, the copyright header includes the classpath exception. This makes no sense, and should be removed. 
> 
> I have removed the classpath exception from makefiles, autoconf, shell scripts, properties files, configuration files, IDE support files, build tools and data.
> 
> The only places where the classpath exception is still kept in the make directory is as text strings in some build tools, which generate source code that is bundled with `src.zip`, and thus *must* have the classpath exception.
> 
> This is a huge and autogenerated, but content-wise trivial, PR, and I know such are hard to review. I recommend looking at the entire diff file instead of checking this file-by-file in the Github web GUI. (That's bound to be a painful experience)

Marked as reviewed by abdelhak-zaaim at github.com (no known OpenJDK username).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22104#pullrequestreview-2436096366

From jjg at openjdk.org  Thu Nov 14 15:26:22 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 14 Nov 2024 15:26:22 GMT
Subject: RFR: 8344191: Build code should not have classpath exception
In-Reply-To: <U0XAHfEgxgfvcpBaj8aOZgQgk0cU-GyAMyeJ9cyJrUA=.84aeedaa-ef83-48e9-9eea-1de1e8d0afd6@github.com>
References: <U0XAHfEgxgfvcpBaj8aOZgQgk0cU-GyAMyeJ9cyJrUA=.84aeedaa-ef83-48e9-9eea-1de1e8d0afd6@github.com>
Message-ID: <M9HkddCRkOHWT_JM7FBHAO4iFklBcnSdRrMwFYStuv0=.5cc2c74b-c7ec-4d2a-981d-93e1f5c4500a@github.com>

On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> In several (most? all?) of the build system files, the copyright header includes the classpath exception. This makes no sense, and should be removed. 
> 
> I have removed the classpath exception from makefiles, autoconf, shell scripts, properties files, configuration files, IDE support files, build tools and data.
> 
> The only places where the classpath exception is still kept in the make directory is as text strings in some build tools, which generate source code that is bundled with `src.zip`, and thus *must* have the classpath exception.
> 
> This is a huge and autogenerated, but content-wise trivial, PR, and I know such are hard to review. I recommend looking at the entire diff file instead of checking this file-by-file in the Github web GUI. (That's bound to be a painful experience)

The policy has long been to use Classpath Exception in the `src` and `make` directories, but not in the `test` directories. If you're changing the policy, you might want to check and update any documentation where the policy might be written down.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22104#issuecomment-2476698524

From iris at openjdk.org  Thu Nov 14 18:43:38 2024
From: iris at openjdk.org (Iris Clark)
Date: Thu, 14 Nov 2024 18:43:38 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v2]
In-Reply-To: <XPX7mNek8KcN7ri7h8gqRZFBeKjSmu_XiHuvE-cR0Ws=.7292fd84-de4b-4163-8cf3-93838a32f1c4@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <XPX7mNek8KcN7ri7h8gqRZFBeKjSmu_XiHuvE-cR0Ws=.7292fd84-de4b-4163-8cf3-93838a32f1c4@github.com>
Message-ID: <hD8dWtCFGyH64MyqGEoAP1aMt9E32eY7_ArUkRi0cT4=.c18c2075-5daf-4cda-9a81-2f968a343734@github.com>

On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
>> 
>> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
>> 
>> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix CheckManPageOptions test
>  - Remove classpath exception

Thanks for updating all the licenses to GPL.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22081#pullrequestreview-2436927254

From ihse at openjdk.org  Fri Nov 15 00:10:24 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 15 Nov 2024 00:10:24 GMT
Subject: RFR: 8344191: Build code should not have classpath exception
In-Reply-To: <M9HkddCRkOHWT_JM7FBHAO4iFklBcnSdRrMwFYStuv0=.5cc2c74b-c7ec-4d2a-981d-93e1f5c4500a@github.com>
References: <U0XAHfEgxgfvcpBaj8aOZgQgk0cU-GyAMyeJ9cyJrUA=.84aeedaa-ef83-48e9-9eea-1de1e8d0afd6@github.com>
 <M9HkddCRkOHWT_JM7FBHAO4iFklBcnSdRrMwFYStuv0=.5cc2c74b-c7ec-4d2a-981d-93e1f5c4500a@github.com>
Message-ID: <_ewi33QvJz3HiyEkrJ64eWTUOl52LKXiMkWF4SUfxgM=.33f058b7-f21f-4259-abd2-0cb7e7a2da1a@github.com>

On Thu, 14 Nov 2024 15:23:35 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> The policy has long been to use Classpath Exception in the src and make directories, but not in the test directories. If you're changing the policy, you might want to check and update any documentation where the policy might be written down.

I did not know there was such a policy. My understanding is that the classpath exception only makes sense for java files that are distributed as part of the JDK. That `test` was excluded from classpath should therefore be a logical consequence that it is not distributed. And `src` is not generally using CPE; for instance, Hotspot does not have CPE.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22104#issuecomment-2477665315

From dholmes at openjdk.org  Fri Nov 15 01:25:30 2024
From: dholmes at openjdk.org (David Holmes)
Date: Fri, 15 Nov 2024 01:25:30 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v2]
In-Reply-To: <XPX7mNek8KcN7ri7h8gqRZFBeKjSmu_XiHuvE-cR0Ws=.7292fd84-de4b-4163-8cf3-93838a32f1c4@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <XPX7mNek8KcN7ri7h8gqRZFBeKjSmu_XiHuvE-cR0Ws=.7292fd84-de4b-4163-8cf3-93838a32f1c4@github.com>
Message-ID: <C-MBQ_G52h3Y1bIQRfxQJOSVS3pmOv6CRy1fxzR0K4M=.67e32bdd-26cd-4450-ba03-766af4e2e98e@github.com>

On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
>> 
>> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
>> 
>> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix CheckManPageOptions test
>  - Remove classpath exception

LGTM!

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22081#pullrequestreview-2437489438

From dholmes at openjdk.org  Fri Nov 15 01:29:49 2024
From: dholmes at openjdk.org (David Holmes)
Date: Fri, 15 Nov 2024 01:29:49 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v2]
In-Reply-To: <XPX7mNek8KcN7ri7h8gqRZFBeKjSmu_XiHuvE-cR0Ws=.7292fd84-de4b-4163-8cf3-93838a32f1c4@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <XPX7mNek8KcN7ri7h8gqRZFBeKjSmu_XiHuvE-cR0Ws=.7292fd84-de4b-4163-8cf3-93838a32f1c4@github.com>
Message-ID: <3zUMDU3HQSNpvZPbBDrPN7p_6TIubczvegxSSU50S2o=.cf9f50f1-d605-46ea-9780-de3f9cf04a94@github.com>

On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
>> 
>> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
>> 
>> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix CheckManPageOptions test
>  - Remove classpath exception

> > Now `CheckManPageOptions` finds the `.md` file (good) and its checks fail (bad).
> 
> _sigh_
> 
> > A candidate for an ignore list as fixing it is out of scope of this PR?
> 
> Let me have a look at it first. It seems the test has the indention to handle markdown files, so maybe there is an easy fix.

I'm somewhat surprised that the full src tree is available to this test when it runs. I was expecting it to examine the .1 files in the JDK image.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22081#issuecomment-2477764902

From ihse at openjdk.org  Fri Nov 15 14:46:33 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 15 Nov 2024 14:46:33 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v3]
In-Reply-To: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
Message-ID: <B2bFkUUIkxApuvoU42qg-A_wv_J1b5lxSNPzbILjWPs=.2f6d2d4f-4268-4cc8-8981-6e8e8736a757@github.com>

> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
> 
> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
> 
> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.

Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:

  Fix regexes in CheckManPageOptions

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22081/files
  - new: https://git.openjdk.org/jdk/pull/22081/files/a8d4ea50..dbef493e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22081&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22081&range=01-02

  Stats: 12 lines in 1 file changed: 3 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/22081.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22081/head:pull/22081

PR: https://git.openjdk.org/jdk/pull/22081

From ihse at openjdk.org  Fri Nov 15 14:46:34 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 15 Nov 2024 14:46:34 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v2]
In-Reply-To: <XPX7mNek8KcN7ri7h8gqRZFBeKjSmu_XiHuvE-cR0Ws=.7292fd84-de4b-4163-8cf3-93838a32f1c4@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <XPX7mNek8KcN7ri7h8gqRZFBeKjSmu_XiHuvE-cR0Ws=.7292fd84-de4b-4163-8cf3-93838a32f1c4@github.com>
Message-ID: <OnOhR_4neUIpLLJXyytczQFw_jwjywxQ-o7XAvWVjF4=.971a3357-fa72-4c7c-9025-f295e252dc9f@github.com>

On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
>> 
>> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
>> 
>> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix CheckManPageOptions test
>  - Remove classpath exception

The CheckManPageOptions test had regexps that were not up to date with the latest changes in the markdown file. I fixed those and now the test passes.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22081#issuecomment-2479038178

From ihse at openjdk.org  Fri Nov 15 14:46:34 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 15 Nov 2024 14:46:34 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v2]
In-Reply-To: <3zUMDU3HQSNpvZPbBDrPN7p_6TIubczvegxSSU50S2o=.cf9f50f1-d605-46ea-9780-de3f9cf04a94@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <XPX7mNek8KcN7ri7h8gqRZFBeKjSmu_XiHuvE-cR0Ws=.7292fd84-de4b-4163-8cf3-93838a32f1c4@github.com>
 <3zUMDU3HQSNpvZPbBDrPN7p_6TIubczvegxSSU50S2o=.cf9f50f1-d605-46ea-9780-de3f9cf04a94@github.com>
Message-ID: <H49OafS1oIU1W-O1uMBrGYPeARoh_4nPqPp0cyzjt_k=.fd859280-4110-441d-9ddc-e7e08bb909c9@github.com>

On Fri, 15 Nov 2024 01:25:43 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix CheckManPageOptions test
>>  - Remove classpath exception
>
>> > Now `CheckManPageOptions` finds the `.md` file (good) and its checks fail (bad).
>> 
>> _sigh_
>> 
>> > A candidate for an ignore list as fixing it is out of scope of this PR?
>> 
>> Let me have a look at it first. It seems the test has the indention to handle markdown files, so maybe there is an easy fix.
> 
> I'm somewhat surprised that the full src tree is available to this test when it runs. I was expecting it to examine the .1 files in the JDK image.

@dholmes-ora 

>  I was expecting it to examine the .1 files in the JDK image.

It's been like that since the test was created in https://bugs.openjdk.org/browse/JDK-8274211, so there is no change in this PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22081#issuecomment-2479042569

From ihse at openjdk.org  Fri Nov 15 14:50:21 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 15 Nov 2024 14:50:21 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v4]
In-Reply-To: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
Message-ID: <MFJE1GFfhbL6V-n8X7LqAYMOBKz9l6G3Kop8QwRPYSg=.bfe25f26-140c-4235-8686-85bbac7f6915@github.com>

> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
> 
> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
> 
> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.

Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:

  It's somewhat nicer to use \\s instead of space character in regex

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22081/files
  - new: https://git.openjdk.org/jdk/pull/22081/files/dbef493e..7cba61b5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22081&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22081&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22081.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22081/head:pull/22081

PR: https://git.openjdk.org/jdk/pull/22081

From cstein at openjdk.org  Fri Nov 15 15:04:51 2024
From: cstein at openjdk.org (Christian Stein)
Date: Fri, 15 Nov 2024 15:04:51 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v3]
In-Reply-To: <B2bFkUUIkxApuvoU42qg-A_wv_J1b5lxSNPzbILjWPs=.2f6d2d4f-4268-4cc8-8981-6e8e8736a757@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <B2bFkUUIkxApuvoU42qg-A_wv_J1b5lxSNPzbILjWPs=.2f6d2d4f-4268-4cc8-8981-6e8e8736a757@github.com>
Message-ID: <Hc2bnxpU3L_6aq6ywU83kGh6MnUKh7XftL5OuwKErGg=.4c54e3d8-2169-4d25-bfa9-9d2b957e6981@github.com>

On Fri, 15 Nov 2024 14:46:33 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
>> 
>> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
>> 
>> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix regexes in CheckManPageOptions

test/langtools/jdk/javadoc/tool/CheckManPageOptions.java line 277:

> 275: 
> 276:         // In the defining areas, option names are represented as follows:
> 277:         //      `OPTION` or `OPTION`

`OPTION` or `OPTION` ... where's the difference?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22081#discussion_r1843959156

From ihse at openjdk.org  Fri Nov 15 15:11:46 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 15 Nov 2024 15:11:46 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v3]
In-Reply-To: <Hc2bnxpU3L_6aq6ywU83kGh6MnUKh7XftL5OuwKErGg=.4c54e3d8-2169-4d25-bfa9-9d2b957e6981@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <B2bFkUUIkxApuvoU42qg-A_wv_J1b5lxSNPzbILjWPs=.2f6d2d4f-4268-4cc8-8981-6e8e8736a757@github.com>
 <Hc2bnxpU3L_6aq6ywU83kGh6MnUKh7XftL5OuwKErGg=.4c54e3d8-2169-4d25-bfa9-9d2b957e6981@github.com>
Message-ID: <_OybV6gt9rVOlg2n8GG48jDzgFsqLQ6GLi4R5TvZWTI=.b1f68ebb-dcd5-4fe1-b001-21628221d218@github.com>

On Fri, 15 Nov 2024 15:00:39 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix regexes in CheckManPageOptions
>
> test/langtools/jdk/javadoc/tool/CheckManPageOptions.java line 277:
> 
>> 275: 
>> 276:         // In the defining areas, option names are represented as follows:
>> 277:         //      `OPTION` or `OPTION`
> 
> `OPTION` or `OPTION` ... where's the difference?

Some options have multiple variants displayed on a single row, like:

 `--classpath` or `-cp`



This was handled in the troff format but not updated for markdown.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22081#discussion_r1843969778

From cstein at openjdk.org  Fri Nov 15 16:04:19 2024
From: cstein at openjdk.org (Christian Stein)
Date: Fri, 15 Nov 2024 16:04:19 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v4]
In-Reply-To: <MFJE1GFfhbL6V-n8X7LqAYMOBKz9l6G3Kop8QwRPYSg=.bfe25f26-140c-4235-8686-85bbac7f6915@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <MFJE1GFfhbL6V-n8X7LqAYMOBKz9l6G3Kop8QwRPYSg=.bfe25f26-140c-4235-8686-85bbac7f6915@github.com>
Message-ID: <h-yi4F3ylqaiXJhUvdkQYwbgW7lbhzlFqCpNo_y5pDg=.cd652669-b8ac-4c35-9d02-1a6ec551df87@github.com>

On Fri, 15 Nov 2024 14:50:21 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
>> 
>> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
>> 
>> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   It's somewhat nicer to use \\s instead of space character in regex

Marked as reviewed by cstein (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22081#pullrequestreview-2439039366

From dholmes at openjdk.org  Sat Nov 16 12:24:42 2024
From: dholmes at openjdk.org (David Holmes)
Date: Sat, 16 Nov 2024 12:24:42 GMT
Subject: RFR: 8344191: Build code should not have classpath exception
In-Reply-To: <_ewi33QvJz3HiyEkrJ64eWTUOl52LKXiMkWF4SUfxgM=.33f058b7-f21f-4259-abd2-0cb7e7a2da1a@github.com>
References: <U0XAHfEgxgfvcpBaj8aOZgQgk0cU-GyAMyeJ9cyJrUA=.84aeedaa-ef83-48e9-9eea-1de1e8d0afd6@github.com>
 <M9HkddCRkOHWT_JM7FBHAO4iFklBcnSdRrMwFYStuv0=.5cc2c74b-c7ec-4d2a-981d-93e1f5c4500a@github.com>
 <_ewi33QvJz3HiyEkrJ64eWTUOl52LKXiMkWF4SUfxgM=.33f058b7-f21f-4259-abd2-0cb7e7a2da1a@github.com>
Message-ID: <yBnJF8M2Mq6PH2pwEFI1aHQZcOvjPAubcXJJUBfFtMg=.1c674802-e31e-4f50-9d28-b05b31697604@github.com>

On Fri, 15 Nov 2024 00:07:07 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> The policy has long been to use Classpath Exception in the `src` and `make` directories, but not in the `test` directories. If you're changing the policy, you might want to check and update any documentation where the policy might be written down.

What policy is that? The Classpath exception is for executing classfiles. It is meaningless in any other context.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22104#issuecomment-2480542305

From iris at openjdk.org  Mon Nov 18 01:35:07 2024
From: iris at openjdk.org (Iris Clark)
Date: Mon, 18 Nov 2024 01:35:07 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v4]
In-Reply-To: <MFJE1GFfhbL6V-n8X7LqAYMOBKz9l6G3Kop8QwRPYSg=.bfe25f26-140c-4235-8686-85bbac7f6915@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <MFJE1GFfhbL6V-n8X7LqAYMOBKz9l6G3Kop8QwRPYSg=.bfe25f26-140c-4235-8686-85bbac7f6915@github.com>
Message-ID: <Tp6ovDvXsen9cOyCVWF5mUyuqKBmLJsV0CCd99cOflk=.08ed9a29-6f05-4987-ba14-828ffd450b27@github.com>

On Fri, 15 Nov 2024 14:50:21 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
>> 
>> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
>> 
>> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   It's somewhat nicer to use \\s instead of space character in regex

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22081#pullrequestreview-2441317522

From ihse at openjdk.org  Mon Nov 18 09:29:52 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Mon, 18 Nov 2024 09:29:52 GMT
Subject: Integrated: 8344056: Use markdown format for man pages
In-Reply-To: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
Message-ID: <_LM2L_tT9Q4OZvoeWztNyLUkzQcLPQIE_En639Pu_lA=.31310c87-64b4-4b97-bb0c-f044e312e9ef@github.com>

On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
> 
> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
> 
> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.

This pull request has now been integrated.

Changeset: 475feb06
Author:    Magnus Ihse Bursie <ihse at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/475feb064bb6b9dfd34fc52762e3e0ab825254ec
Stats:     41386 lines in 66 files changed: 18876 ins; 22500 del; 10 mod

8344056: Use markdown format for man pages

Reviewed-by: cstein, iris, dholmes

-------------

PR: https://git.openjdk.org/jdk/pull/22081

From jlahoda at openjdk.org  Tue Nov 19 12:08:27 2024
From: jlahoda at openjdk.org (Jan Lahoda)
Date: Tue, 19 Nov 2024 12:08:27 GMT
Subject: RFR: 8341631: JShell should auto-import java.io.IO.*
Message-ID: <NX712ai1DYMQ3iSCUEC8gCIJy4imgvRB2ucIThM2-uU=.f38ddf03-b22c-47aa-991b-827f5cdd11d2@github.com>

Adding `import static java.io.IO.*;` to the preview-default script of JShell. Also fixing JShell's console to handle the new `IO` methods properly.

-------------

Commit messages:
 - Cleanup.
 - Fixing readln.
 - Post merge fixes.
 - Merge branch 'master' into JDK-8341631
 - Merge branch 'JDK-8342936-readln' into JDK-8341631
 - Fixing test for Console.readln/readLine, ensuring the proper methods are called.
 - Removing incorrect sentence about writing a prompt for the prompt-less readln method.
 - Adding support for IO.readln()
 - 8342936: Enhance java.io.IO with parameter-less println()
 - Fixing handling of Console input.
 - ... and 1 more: https://git.openjdk.org/jdk/compare/76a55c3c...9b6de872

Changes: https://git.openjdk.org/jdk/pull/22237/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22237&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8341631
  Stats: 141 lines in 7 files changed: 124 ins; 0 del; 17 mod
  Patch: https://git.openjdk.org/jdk/pull/22237.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22237/head:pull/22237

PR: https://git.openjdk.org/jdk/pull/22237

From asotona at openjdk.org  Tue Nov 19 13:29:47 2024
From: asotona at openjdk.org (Adam Sotona)
Date: Tue, 19 Nov 2024 13:29:47 GMT
Subject: RFR: 8341631: JShell should auto-import java.io.IO.*
In-Reply-To: <NX712ai1DYMQ3iSCUEC8gCIJy4imgvRB2ucIThM2-uU=.f38ddf03-b22c-47aa-991b-827f5cdd11d2@github.com>
References: <NX712ai1DYMQ3iSCUEC8gCIJy4imgvRB2ucIThM2-uU=.f38ddf03-b22c-47aa-991b-827f5cdd11d2@github.com>
Message-ID: <iNHzmni7fvyMHCmCeghgh76TNEXbVzuxQuDKuR_uleM=.cc383f90-2744-4985-9842-8fac7b3b7d08@github.com>

On Tue, 19 Nov 2024 12:03:08 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> Adding `import static java.io.IO.*;` to the preview-default script of JShell. Also fixing JShell's console to handle the new `IO` methods properly.

Looks good to me.

-------------

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22237#pullrequestreview-2445479259

From cstein at openjdk.org  Tue Nov 19 15:52:53 2024
From: cstein at openjdk.org (Christian Stein)
Date: Tue, 19 Nov 2024 15:52:53 GMT
Subject: RFR: 8341631: JShell should auto-import java.io.IO.*
In-Reply-To: <NX712ai1DYMQ3iSCUEC8gCIJy4imgvRB2ucIThM2-uU=.f38ddf03-b22c-47aa-991b-827f5cdd11d2@github.com>
References: <NX712ai1DYMQ3iSCUEC8gCIJy4imgvRB2ucIThM2-uU=.f38ddf03-b22c-47aa-991b-827f5cdd11d2@github.com>
Message-ID: <NUOA3iQvpFg8uP6Q3DKqabDNJL4py7sCsvVhWGfuh5U=.2356183b-8c45-4602-8d25-23f7d93ecb8e@github.com>

On Tue, 19 Nov 2024 12:03:08 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> Adding `import static java.io.IO.*;` to the preview-default script of JShell. Also fixing JShell's console to handle the new `IO` methods properly.

Let there be IO ? changes look good.

-------------

Marked as reviewed by cstein (Committer).

PR Review: https://git.openjdk.org/jdk/pull/22237#pullrequestreview-2445890014

From eirbjo at openjdk.org  Tue Nov 19 16:30:50 2024
From: eirbjo at openjdk.org (Eirik =?UTF-8?B?QmrDuHJzbsO4cw==?=)
Date: Tue, 19 Nov 2024 16:30:50 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v4]
In-Reply-To: <MFJE1GFfhbL6V-n8X7LqAYMOBKz9l6G3Kop8QwRPYSg=.bfe25f26-140c-4235-8686-85bbac7f6915@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <MFJE1GFfhbL6V-n8X7LqAYMOBKz9l6G3Kop8QwRPYSg=.bfe25f26-140c-4235-8686-85bbac7f6915@github.com>
Message-ID: <dSX5F0cz58F6KPMi0eaZDqRmHQTGA_hjJBGk9lJXqS4=.b1cbd6d0-9e9e-4166-905e-e59988720bd8@github.com>

On Fri, 15 Nov 2024 14:50:21 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo.
>> 
>> Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then convert it to troff.
>> 
>> This closed-markdown to open-troff processing needs to be done manually by an Oracle engineer. This is done regularly at the start and end of a new release cycle, adding to the burden of creating a new release. It is also done (if any of the reviewers knows about the process) whenever an Oracle engineer updates a man page. If a community contributor changes the behavior of a tool, an Oracle engineer needs to change the documentation for them, since they cannot do it themselves.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   It's somewhat nicer to use \\s instead of space character in regex

Is the warning log when pandoc is not installed a bit loud?


% make images
Building target 'images' in configuration 'macosx-x86_64-server-release'
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Warning: pandoc not found. Not generating man pages
Finished building target 'images' in configuration 'macosx-x86_64-server-release'

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22081#issuecomment-2486187436

From acobbs at openjdk.org  Tue Nov 19 22:48:18 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Tue, 19 Nov 2024 22:48:18 GMT
Subject: RFR: 8343481: Remove unnecessary @SuppressWarnings annotations
 (kulla) [v5]
In-Reply-To: <0ffa89tPmxvnQFqQPalxKv9ZJfNjByqxc73JQJReNbE=.abb952c8-b881-4438-a3c0-788f7788b6f7@github.com>
References: <kHGjUJ8TrO5alHLad3YI2Z_yox4gaZi-gAY4gf7KHoY=.d32ba2ed-d666-427b-a994-23d2e3a178af@github.com>
 <0ffa89tPmxvnQFqQPalxKv9ZJfNjByqxc73JQJReNbE=.abb952c8-b881-4438-a3c0-788f7788b6f7@github.com>
Message-ID: <5BSxsh0kwbyDuIAfYzPITFvC69c5lGBL_6HFglyxPuE=.fa1f6a6d-b5d5-46e5-b636-43b16d060b47@github.com>

On Wed, 13 Nov 2024 16:53:03 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Merge branch 'master' into SuppressWarningsCleanup-kulla
>  - Merge branch 'master' into SuppressWarningsCleanup-kulla
>  - Update copyright years.
>  - Merge branch 'master' into SuppressWarningsCleanup-kulla
>  - Remove two more "this-escape" supressions.
>  - Merge branch 'master' into SuppressWarningsCleanup-kulla
>  - Remove unnecessary @SuppressWarnings annotations.

Question for @lahodaj ... I'm realizing now that most of the files patched here are imports from JLine.

Is it important to minimize changes to these imported files? If so I can revert the JLine changes in this patch; there would then only be two patched files in `jdk.jshell` remaining.

Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21855#issuecomment-2486880435

From jlahoda at openjdk.org  Wed Nov 20 07:40:16 2024
From: jlahoda at openjdk.org (Jan Lahoda)
Date: Wed, 20 Nov 2024 07:40:16 GMT
Subject: RFR: 8343481: Remove unnecessary @SuppressWarnings annotations
 (kulla) [v5]
In-Reply-To: <5BSxsh0kwbyDuIAfYzPITFvC69c5lGBL_6HFglyxPuE=.fa1f6a6d-b5d5-46e5-b636-43b16d060b47@github.com>
References: <kHGjUJ8TrO5alHLad3YI2Z_yox4gaZi-gAY4gf7KHoY=.d32ba2ed-d666-427b-a994-23d2e3a178af@github.com>
 <0ffa89tPmxvnQFqQPalxKv9ZJfNjByqxc73JQJReNbE=.abb952c8-b881-4438-a3c0-788f7788b6f7@github.com>
 <5BSxsh0kwbyDuIAfYzPITFvC69c5lGBL_6HFglyxPuE=.fa1f6a6d-b5d5-46e5-b636-43b16d060b47@github.com>
Message-ID: <BpiUfeD_Q2ANf9wUqobgxYUaSVyTHhVKjYTpXL1k7OI=.c06ddec1-8080-457f-a614-d4f393c8e811@github.com>

On Tue, 19 Nov 2024 22:28:01 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> Question for @lahodaj ... I'm realizing now that most of the files patched here are imports from JLine.
> 
> Is it important to minimize changes to these imported files? If so I can revert the JLine changes in this patch; there would then only be two patched files in `jdk.jshell` remaining.
> 
> Thanks.

Yes, it would be preferable to not touch the JLine code here, unless there's a compelling reason to do so. Ideally, the changes could be contributed to JLine, and we would adopt them at some point as part of a JLine upgrade.

Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21855#issuecomment-2487738252

From jlahoda at openjdk.org  Wed Nov 20 09:27:25 2024
From: jlahoda at openjdk.org (Jan Lahoda)
Date: Wed, 20 Nov 2024 09:27:25 GMT
Subject: Integrated: 8341631: JShell should auto-import java.io.IO.*
In-Reply-To: <NX712ai1DYMQ3iSCUEC8gCIJy4imgvRB2ucIThM2-uU=.f38ddf03-b22c-47aa-991b-827f5cdd11d2@github.com>
References: <NX712ai1DYMQ3iSCUEC8gCIJy4imgvRB2ucIThM2-uU=.f38ddf03-b22c-47aa-991b-827f5cdd11d2@github.com>
Message-ID: <b3nwc33AH-pAnGs3CdEJgC6CC2XjK0CVupVcosA8o0Q=.bac91941-7c9d-496f-92fc-ac376c407f3d@github.com>

On Tue, 19 Nov 2024 12:03:08 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> Adding `import static java.io.IO.*;` to the preview-default script of JShell. Also fixing JShell's console to handle the new `IO` methods properly.

This pull request has now been integrated.

Changeset: cf158bc6
Author:    Jan Lahoda <jlahoda at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/cf158bc6cdadfdfa944b8ec1d3dc7069c8f055a9
Stats:     141 lines in 7 files changed: 124 ins; 0 del; 17 mod

8341631: JShell should auto-import java.io.IO.*

Reviewed-by: asotona, cstein

-------------

PR: https://git.openjdk.org/jdk/pull/22237

From acobbs at openjdk.org  Wed Nov 20 15:27:43 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Wed, 20 Nov 2024 15:27:43 GMT
Subject: RFR: 8343481: Remove unnecessary @SuppressWarnings annotations
 (kulla) [v6]
In-Reply-To: <kHGjUJ8TrO5alHLad3YI2Z_yox4gaZi-gAY4gf7KHoY=.d32ba2ed-d666-427b-a994-23d2e3a178af@github.com>
References: <kHGjUJ8TrO5alHLad3YI2Z_yox4gaZi-gAY4gf7KHoY=.d32ba2ed-d666-427b-a994-23d2e3a178af@github.com>
Message-ID: <SKlURr9PpctPiKtvQMsUPvwAEkgaWnF6Td9ycej1eM4=.c09ddf03-6dc8-4e86-bdb4-11505d09a6f3@github.com>

> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:

 - Revert changes to files imported from JLine to minimize diffs.
 - Merge branch 'master' into SuppressWarningsCleanup-kulla
 - Merge branch 'master' into SuppressWarningsCleanup-kulla
 - Merge branch 'master' into SuppressWarningsCleanup-kulla
 - Update copyright years.
 - Merge branch 'master' into SuppressWarningsCleanup-kulla
 - Remove two more "this-escape" supressions.
 - Merge branch 'master' into SuppressWarningsCleanup-kulla
 - Remove unnecessary @SuppressWarnings annotations.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21855/files
  - new: https://git.openjdk.org/jdk/pull/21855/files/92d02591..94484883

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21855&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21855&range=04-05

  Stats: 85406 lines in 1316 files changed: 40828 ins; 38049 del; 6529 mod
  Patch: https://git.openjdk.org/jdk/pull/21855.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21855/head:pull/21855

PR: https://git.openjdk.org/jdk/pull/21855

From acobbs at openjdk.org  Wed Nov 20 15:27:43 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Wed, 20 Nov 2024 15:27:43 GMT
Subject: RFR: 8343481: Remove unnecessary @SuppressWarnings annotations
 (kulla) [v5]
In-Reply-To: <BpiUfeD_Q2ANf9wUqobgxYUaSVyTHhVKjYTpXL1k7OI=.c06ddec1-8080-457f-a614-d4f393c8e811@github.com>
References: <kHGjUJ8TrO5alHLad3YI2Z_yox4gaZi-gAY4gf7KHoY=.d32ba2ed-d666-427b-a994-23d2e3a178af@github.com>
 <0ffa89tPmxvnQFqQPalxKv9ZJfNjByqxc73JQJReNbE=.abb952c8-b881-4438-a3c0-788f7788b6f7@github.com>
 <5BSxsh0kwbyDuIAfYzPITFvC69c5lGBL_6HFglyxPuE=.fa1f6a6d-b5d5-46e5-b636-43b16d060b47@github.com>
 <BpiUfeD_Q2ANf9wUqobgxYUaSVyTHhVKjYTpXL1k7OI=.c06ddec1-8080-457f-a614-d4f393c8e811@github.com>
Message-ID: <jQtqpyTK5w7rAuTEJsE80amYp3fIJT-TDsWx_-VpOx8=.88161dc2-577e-40b1-af63-bb87b57501f5@github.com>

On Wed, 20 Nov 2024 07:37:56 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> Yes, it would be preferable to not touch the JLine code here, unless there's a compelling reason to do so.

Makes sense. Reverted in 94484883706.

> Ideally, the changes could be contributed to JLine, and we would adopt them at some point as part of a JLine upgrade.

I'll work on that.

Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21855#issuecomment-2488876724

From acobbs at openjdk.org  Wed Nov 20 15:50:17 2024
From: acobbs at openjdk.org (Archie Cobbs)
Date: Wed, 20 Nov 2024 15:50:17 GMT
Subject: RFR: 8343481: Remove unnecessary @SuppressWarnings annotations
 (kulla) [v5]
In-Reply-To: <jQtqpyTK5w7rAuTEJsE80amYp3fIJT-TDsWx_-VpOx8=.88161dc2-577e-40b1-af63-bb87b57501f5@github.com>
References: <kHGjUJ8TrO5alHLad3YI2Z_yox4gaZi-gAY4gf7KHoY=.d32ba2ed-d666-427b-a994-23d2e3a178af@github.com>
 <0ffa89tPmxvnQFqQPalxKv9ZJfNjByqxc73JQJReNbE=.abb952c8-b881-4438-a3c0-788f7788b6f7@github.com>
 <5BSxsh0kwbyDuIAfYzPITFvC69c5lGBL_6HFglyxPuE=.fa1f6a6d-b5d5-46e5-b636-43b16d060b47@github.com>
 <BpiUfeD_Q2ANf9wUqobgxYUaSVyTHhVKjYTpXL1k7OI=.c06ddec1-8080-457f-a614-d4f393c8e811@github.com>
 <jQtqpyTK5w7rAuTEJsE80amYp3fIJT-TDsWx_-VpOx8=.88161dc2-577e-40b1-af63-bb87b57501f5@github.com>
Message-ID: <feI2UD9NgpC3C0lkFRqnay0XZlm7OvGlsYWmaQG_Wf8=.488f0876-e3e2-4a47-a2ba-0442b01204c1@github.com>

On Wed, 20 Nov 2024 15:24:32 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> > Ideally, the changes could be contributed to JLine, and we would adopt them at some point as part of a JLine upgrade.
> 
> I'll work on that.

Hah, that doesn't work - in the JDK the imported JLine code is built as part of an internal module, so the `this-escape` warning does not apply to the classes where it's being suppressed, unlike in the normal JLine build.

So eventually if/when the `suppression` warning becomes active we'll just do something like this instead...

--- a/make/modules/jdk.internal.le/Java.gmk
+++ b/make/modules/jdk.internal.le/Java.gmk
@@ -23,6 +23,6 @@
 # questions.
 #
 
-DISABLED_WARNINGS_java += dangling-doc-comments this-escape
+DISABLED_WARNINGS_java += dangling-doc-comments this-escape suppression
 
 COPY += .properties .caps .txt

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21855#issuecomment-2488940711

From ihse at openjdk.org  Wed Nov 20 16:24:30 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Wed, 20 Nov 2024 16:24:30 GMT
Subject: RFR: 8344056: Use markdown format for man pages [v4]
In-Reply-To: <dSX5F0cz58F6KPMi0eaZDqRmHQTGA_hjJBGk9lJXqS4=.b1cbd6d0-9e9e-4166-905e-e59988720bd8@github.com>
References: <4IMAP2YybZ72bK3HxFTZJ4N5QenXeLQfoIkrjHmZWqg=.ffe66ac0-e675-44cf-bfde-7947f36c699b@github.com>
 <MFJE1GFfhbL6V-n8X7LqAYMOBKz9l6G3Kop8QwRPYSg=.bfe25f26-140c-4235-8686-85bbac7f6915@github.com>
 <dSX5F0cz58F6KPMi0eaZDqRmHQTGA_hjJBGk9lJXqS4=.b1cbd6d0-9e9e-4166-905e-e59988720bd8@github.com>
Message-ID: <Lm9JH4ilJQSzUz6NveUUZGWppeHKqun_9SXOSwcwhhs=.125acdbf-545e-4d79-aabf-da2bcdc0d6a6@github.com>

On Tue, 19 Nov 2024 16:27:54 GMT, Eirik Bj?rsn?s <eirbjo at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   It's somewhat nicer to use \\s instead of space character in regex
>
> Is the warning log when pandoc is not installed a bit loud?
> 
> 
> % make images
> Building target 'images' in configuration 'macosx-x86_64-server-release'
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Warning: pandoc not found. Not generating man pages
> Finished building target 'images' in configuration 'macosx-x86_64-server-release'

@eirbjo Yes, that was not intentional. https://bugs.openjdk.org/browse/JDK-8344559.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22081#issuecomment-2489029819