Integrated: 8341176: Permit access to diagnostics for transient snippets
Jan Lahoda
jlahoda at openjdk.org
Mon Nov 11 09:37:40 UTC 2024
On Mon, 30 Sep 2024 11:30:47 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
> JShell permits to create transient snippets using `SourceCodeAnalysis.sourceToSnippets`, for the purpose of alternative UI clients. But, the alternative UI clients might need to get the diagnostics for the snippets, but the existing `JShell.diagnostics(Snippet)` will not work for the transient snippets.
>
> This patch proposes to enhance the `JShell.diagnostics(Snippet)` with an ability to return best-effort diagnostics for these transient snippets.
>
> Please also review the CSR:
> https://bugs.openjdk.org/browse/JDK-8341200
This pull request has now been integrated.
Changeset: 5ca6698b
Author: Jan Lahoda <jlahoda at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/5ca6698ba418e82ff93471fbb495759850f26f63
Stats: 91 lines in 4 files changed: 84 ins; 0 del; 7 mod
8341176: Permit access to diagnostics for transient snippets
Reviewed-by: vromero
-------------
PR: https://git.openjdk.org/jdk/pull/21261
More information about the kulla-dev
mailing list